NetBSD Problem Report #51871

From www@NetBSD.org  Sat Jan 14 06:01:36 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 9559D7A287
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 14 Jan 2017 06:01:36 +0000 (UTC)
Message-Id: <20170114060135.7275C7A2B6@mollari.NetBSD.org>
Date: Sat, 14 Jan 2017 06:01:35 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/kernel/t_mqueue: add fcntl.h for O_* fcntl/open constants
X-Send-Pr-Version: www-1.0

>Number:         51871
>Category:       bin
>Synopsis:       [PATCH] tests/kernel/t_mqueue: add fcntl.h for O_* fcntl/open constants
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 14 06:05:00 +0000 2017
>Closed-Date:    Sun Jan 15 20:22:42 +0000 2017
>Last-Modified:  Sun Jan 15 20:22:42 +0000 2017
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
- Add fcntl.h #include for O_RDWR, etc for portability.
- Sort #includes per style(9).
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51871: [PATCH] tests/kernel/t_mqueue: add fcntl.h for O_*
 fcntl/open constants
Date: Fri, 13 Jan 2017 22:05:28 -0800

 --Apple-Mail=_70ED57DD-1256-476A-9B78-97D5A786BBAD
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 Patch attached.
 -Ngie

 --Apple-Mail=_70ED57DD-1256-476A-9B78-97D5A786BBAD
 Content-Disposition: attachment;
 	filename=t_mqueue-add-fcntl_h-for-O_-constants-sort-headers.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="t_mqueue-add-fcntl_h-for-O_-constants-sort-headers.patch"
 Content-Transfer-Encoding: 7bit

 ? kernel/obj
 ? kernel/arch/obj
 ? kernel/arch/amd64/obj
 ? kernel/kqueue/obj
 ? kernel/kqueue/read/obj
 ? kernel/kqueue/write/obj
 ? kernel/tty/obj
 Index: kernel/t_mqueue.c
 ===================================================================
 RCS file: /cvsroot/src/tests/kernel/t_mqueue.c,v
 retrieving revision 1.5
 diff -u -r1.5 t_mqueue.c
 --- kernel/t_mqueue.c	10 Jan 2017 22:10:22 -0000	1.5
 +++ kernel/t_mqueue.c	14 Jan 2017 06:00:08 -0000
 @@ -6,17 +6,17 @@
   * This file is in the Public Domain.
   */

 -#include <atf-c.h>
  #include <sys/stat.h>

 +#include <atf-c.h>
 +#include <errno.h>
 +#include <fcntl.h>
 +#include <mqueue.h>
  #include <stdio.h>
  #include <stdlib.h>
  #include <string.h>
 -#include <errno.h>
  #include <unistd.h>

 -#include <mqueue.h>
 -
  #define	MQ_PRIO_BASE	24

  static void

 --Apple-Mail=_70ED57DD-1256-476A-9B78-97D5A786BBAD--

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51871 CVS commit: src/tests/kernel
Date: Sat, 14 Jan 2017 15:57:24 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Sat Jan 14 20:57:24 UTC 2017

 Modified Files:
 	src/tests/kernel: t_mqueue.c

 Log Message:
 PR/51871: Ngie Cooper: add fcntl.h for O_* fcntl/open constants


 To generate a diff of this commit:
 cvs rdiff -u -r1.5 -r1.6 src/tests/kernel/t_mqueue.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Sun, 15 Jan 2017 20:22:42 +0000
State-Changed-Why:
christos committed it. thanks!


>Unformatted:

Home	PR Database Search