NetBSD Problem Report #51874

From www@NetBSD.org  Sat Jan 14 08:18:35 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 80E397A297
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 14 Jan 2017 08:18:35 +0000 (UTC)
Message-Id: <20170114081834.3E7657A2B6@mollari.NetBSD.org>
Date: Sat, 14 Jan 2017 08:18:34 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/lib/setjmp/t_{set,thread}jmp: add __unused to signo in signal handlers
X-Send-Pr-Version: www-1.0

>Number:         51874
>Category:       bin
>Synopsis:       [PATCH] tests/lib/setjmp/t_{set,thread}jmp: add __unused to signo in signal handlers
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 14 08:20:00 +0000 2017
>Closed-Date:    Sun Jan 15 20:27:37 +0000 2017
>Last-Modified:  Sun Jan 15 20:27:37 +0000 2017
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
Add __unused to signo in signal handlers to fix -Wunused warnings.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51874: [PATCH] tests/lib/setjmp/t_{set,thread}jmp: add
 __unused to signo in signal handlers
Date: Sat, 14 Jan 2017 00:33:44 -0800

 --Apple-Mail=_14E9A594-E223-4FA8-9EE5-C117C60E1580
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 Patch attached.
 -Ngie

 --Apple-Mail=_14E9A594-E223-4FA8-9EE5-C117C60E1580
 Content-Disposition: attachment;
 	filename=setjmp-sprinkle-__unused-on-signo.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="setjmp-sprinkle-__unused-on-signo.patch"
 Content-Transfer-Encoding: 7bit

 ? lib/libc/setjmp/obj
 Index: lib/libc/setjmp/t_setjmp.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libc/setjmp/t_setjmp.c,v
 retrieving revision 1.1
 diff -u -r1.1 t_setjmp.c
 --- lib/libc/setjmp/t_setjmp.c	27 Dec 2010 19:35:31 -0000	1.1
 +++ lib/libc/setjmp/t_setjmp.c	14 Jan 2017 08:17:16 -0000
 @@ -87,7 +87,7 @@
  static int expectsignal;

  static void
 -aborthandler(int signo)
 +aborthandler(int signo __unused)
  {
  	ATF_REQUIRE_MSG(expectsignal, "kill(SIGABRT) succeeded");
  	atf_tc_pass();
 Index: lib/libc/setjmp/t_threadjmp.c
 ===================================================================
 RCS file: /cvsroot/src/tests/lib/libc/setjmp/t_threadjmp.c,v
 retrieving revision 1.1
 diff -u -r1.1 t_threadjmp.c
 --- lib/libc/setjmp/t_threadjmp.c	21 Apr 2011 18:58:20 -0000	1.1
 +++ lib/libc/setjmp/t_threadjmp.c	14 Jan 2017 08:17:16 -0000
 @@ -91,7 +91,7 @@
  static int expectsignal;

  static void
 -aborthandler(int signo)
 +aborthandler(int signo __unused)
  {
  	ATF_REQUIRE(myself == pthread_self());
  	ATF_REQUIRE_MSG(expectsignal, "kill(SIGABRT) succeeded");

 --Apple-Mail=_14E9A594-E223-4FA8-9EE5-C117C60E1580--

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51874 CVS commit: src/tests/lib/libc/setjmp
Date: Sat, 14 Jan 2017 16:08:17 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Sat Jan 14 21:08:17 UTC 2017

 Modified Files:
 	src/tests/lib/libc/setjmp: t_setjmp.c t_threadjmp.c

 Log Message:
 PR/51874: Ngie Cooper: Add __unused to signal handlers


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libc/setjmp/t_setjmp.c \
     src/tests/lib/libc/setjmp/t_threadjmp.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Sun, 15 Jan 2017 20:27:37 +0000
State-Changed-Why:
christos committed it. thanks!


>Unformatted:

Home	PR Database Search