NetBSD Problem Report #51876

From www@NetBSD.org  Sat Jan 14 13:33:48 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id C05F17A26D
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 14 Jan 2017 13:33:48 +0000 (UTC)
Message-Id: <20170114133347.C00497A287@mollari.NetBSD.org>
Date: Sat, 14 Jan 2017 13:33:47 +0000 (UTC)
From: yaneurabeya@gmail.com
Reply-To: yaneurabeya@gmail.com
To: gnats-bugs@NetBSD.org
Subject: [PATCH] tests/usr.sbin/mtree: kyua 0.11 $TMPDIR fixes
X-Send-Pr-Version: www-1.0

>Number:         51876
>Category:       bin
>Synopsis:       [PATCH] tests/usr.sbin/mtree: kyua 0.11 $TMPDIR fixes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 14 13:35:01 +0000 2017
>Closed-Date:    Sun Jan 15 20:33:29 +0000 2017
>Last-Modified:  Sun Jan 15 20:33:29 +0000 2017
>Originator:     Ngie Cooper
>Release:        7.0.2
>Organization:
>Environment:
n/a
>Description:
kyua 0.11 puts files in $TMPDIR, which means that comparisons across runs aren't stable.

Root the mtree files under a subdirectory instead so kyua's data capturing doesn't affect the results.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51876: [PATCH] tests/usr.sbin/mtree: kyua 0.11 $TMPDIR fixes
Date: Sat, 14 Jan 2017 05:38:16 -0800

 --Apple-Mail=_E40624A1-516E-4D97-ABED-A3E7D673EBA6
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=us-ascii

 Patch attached.
 -Ngie

 --Apple-Mail=_E40624A1-516E-4D97-ABED-A3E7D673EBA6
 Content-Disposition: attachment;
 	filename=t_mtree-kyua-0_11-TMPDIR-fix.patch
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="t_mtree-kyua-0_11-TMPDIR-fix.patch"
 Content-Transfer-Encoding: 7bit

 Index: usr.sbin/mtree/t_mtree.sh
 ===================================================================
 RCS file: /cvsroot/src/tests/usr.sbin/mtree/t_mtree.sh,v
 retrieving revision 1.6
 diff -u -r1.6 t_mtree.sh
 --- usr.sbin/mtree/t_mtree.sh	5 Feb 2013 16:49:42 -0000	1.6
 +++ usr.sbin/mtree/t_mtree.sh	14 Jan 2017 13:34:29 -0000
 @@ -284,6 +284,13 @@

  ignore_body()
  {
 +	# Kyua 0.11 and above point TMPDIR to our work directory and atf-check
 +	# generates a temporary file, which confuses mtree.  Put the mtree files
 +	# into a subdirectory.
 +	#
 +	# See https://github.com/jmmv/kyua/issues/133 for details.
 +	mkdir root && cd root
 +
  	mkdir newdir
  	mtree -F ${FLAVOR} -c | mtree -F ${FLAVOR} -Ck uid,gid,mode > mtree.spec
  	ln -s newdir otherdir
 @@ -313,6 +320,13 @@
  }
  netbsd6_ignore_body() 
  {
 +	# Kyua 0.11 and above point TMPDIR to our work directory and atf-check
 +	# generates a temporary file, which confuses mtree.  Put the mtree files
 +	# into a subdirectory.
 +	#
 +	# See https://github.com/jmmv/kyua/issues/133 for details.
 +	mkdir root && cd root
 +
  	FLAVOR=netbsd6 ignore_body
  }


 --Apple-Mail=_E40624A1-516E-4D97-ABED-A3E7D673EBA6--

From: Patrick Welche <prlw1@cam.ac.uk>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/51876: [PATCH] tests/usr.sbin/mtree: kyua 0.11 $TMPDIR fixes
Date: Sat, 14 Jan 2017 20:53:45 +0100

 On Sat, Jan 14, 2017 at 01:35:01PM +0000, yaneurabeya@gmail.com wrote:
 > kyua 0.11 puts files in $TMPDIR, which means that comparisons across runs aren't stable.

 Just wondering: is kyua 0.13 any better?

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/51876 CVS commit: src/tests/usr.sbin/mtree
Date: Sat, 14 Jan 2017 15:45:16 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Sat Jan 14 20:45:16 UTC 2017

 Modified Files:
 	src/tests/usr.sbin/mtree: t_mtree.sh

 Log Message:
 PR/51876: Ngie Cooper: kyua 0.11 $TMPDIR fixes


 To generate a diff of this commit:
 cvs rdiff -u -r1.6 -r1.7 src/tests/usr.sbin/mtree/t_mtree.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: gnats-admin@netbsd.org,
 netbsd-bugs@netbsd.org
Subject: Re: bin/51876: [PATCH] tests/usr.sbin/mtree: kyua 0.11 $TMPDIR fixes
Date: Sat, 14 Jan 2017 12:54:12 -0800

 --Apple-Mail=_CF300EB1-E0A1-4ED8-AE39-DF7A278BDBB5
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=utf-8


 > On Jan 14, 2017, at 11:55, Patrick Welche <prlw1@cam.ac.uk> wrote:
 >=20
 > The following reply was made to PR bin/51876; it has been noted by =
 GNATS.
 >=20
 > From: Patrick Welche <prlw1@cam.ac.uk>
 > To: gnats-bugs@NetBSD.org
 > Cc:
 > Subject: Re: bin/51876: [PATCH] tests/usr.sbin/mtree: kyua 0.11 =
 $TMPDIR fixes
 > Date: Sat, 14 Jan 2017 20:53:45 +0100
 >=20
 > On Sat, Jan 14, 2017 at 01:35:01PM +0000, yaneurabeya@gmail.com wrote:
 >> kyua 0.11 puts files in $TMPDIR, which means that comparisons across =
 runs aren't stable.
 >=20
 > Just wondering: is kyua 0.13 any better?

 	It=E2=80=99s better (as far as FreeBSD=E2=80=99s uses go), but =
 it still suffers from this issue (and is functionally deficient in some =
 areas that make it hard to use for general use) :(=E2=80=A6 It=E2=80=99s =
 kind of unfortunate that NetBSD still uses atf-run for =E2=80=9Cmake =
 test=E2=80=9D. After I=E2=80=99ve upstreamed all of the =
 contrib/netbsd-tests bits that need to be upstreamed, I=E2=80=99ll work =
 on porting over the enhancements to use kyua/make check/etc.
 Thanks!
 -Ngie

 --Apple-Mail=_CF300EB1-E0A1-4ED8-AE39-DF7A278BDBB5
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP using GPGMail

 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - https://gpgtools.org

 iQIcBAEBCgAGBQJYeo/1AAoJEPWDqSZpMIYVS28QAKbWd3Nn+tCQwOZSZIDDj6yr
 E1EDxNCDFGs0ylqXP59ADIkZatTkBV0c+K/6qiOQPYC6RGL/GKw9gIoPnhTElxzr
 gO4iwy+Vj/rvdRvXdTpasIUTgCccNFJZFQLoWyPpbMj3+7WiaDaguyQQT6tMkcjZ
 5Yye6wEg42wcS3wAva8fjZht/AvuI+PssMh2a3j6yY4/Kd8GxG1+zHmQvgJ4Plt+
 DIE1kvmUWS7dIW1Cjq8Dko0Zga9TJfbI5BPIHMyTjteAqVhhVrf3yWiH8VRsRY8I
 xR5IALiAy5USEwwlHRYz5tl4YJ7nUk8eWy4J7RUTLnu5ylW0JqpIhymGsH77VtbN
 m7ooc6JRqUjL8xOtnFjV6baZMfRBE4GxGGSLaN1Y+Y6AFlinFu02qevq03MRU6XF
 FEOfWj1N79/AAGStZou5w+SYmZ5G+8iw/VjYdjvZuK+e3O+vOjZsJ4pJLZB4FZmb
 GZ5M9Kif4V/zPln+vsrDmzmHPnY1ylisz71tEDVWWLU47e59qimcLLaGtYBQwGYC
 mv6X1rj3E2U3MdxQ3UJbelgZv1hZQwW0IkMZ5he+MWyNQFx4oCyZ6ACgJUMa/7Tp
 XHjlxsn2q+M1oMIjHs8hfGvPb60p3nwti90132LkHEwWj5jrltwd+fZBsPvMZtZS
 WF0eyPvZ7n5xGA1xlIMK
 =VRts
 -----END PGP SIGNATURE-----

 --Apple-Mail=_CF300EB1-E0A1-4ED8-AE39-DF7A278BDBB5--

State-Changed-From-To: open->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Sun, 15 Jan 2017 20:33:29 +0000
State-Changed-Why:
christos committed it. thanks!


>Unformatted:

Home	PR Database Search