NetBSD Problem Report #52068

From kardel@gateway.kardel.name  Tue Mar 14 07:30:53 2017
Return-Path: <kardel@gateway.kardel.name>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 20FDC7A16A
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 14 Mar 2017 07:30:53 +0000 (UTC)
Message-Id: <20170314073048.D9632343D6C@gateway.kardel.name>
Date: Tue, 14 Mar 2017 07:30:48 +0000 (UTC)
From: kardel@netbsd.org
Reply-To: kardel@netbsd.org
To: gnats-bugs@NetBSD.org
Subject: i386 wmX (i82574L) xmit checksum offloading broken
X-Send-Pr-Version: 3.95

>Number:         52068
>Category:       kern
>Synopsis:       i386 wmX (i82574L) xmit checksum offloading broken
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 14 07:35:00 +0000 2017
>Closed-Date:    Wed Mar 22 10:45:27 +0000 2017
>Last-Modified:  Wed Mar 22 10:45:27 +0000 2017
>Originator:     kardel@netbsd.org
>Release:        NetBSD 7.99.65
>Organization:

>Environment:


System: NetBSD Gateway 7.99.65 NetBSD 7.99.65 (GATEWAY) #8: Sun Mar 12 10:14:06 CET 2017 kardel@xxx:/fs/raid2a/src/NetBSD/cur/src/obj.i386/sys/arch/i386/compile/GATEWAY i386
Architecture: i386
Machine: i386
>Description:
	With hw checksum offloading in send path enabled (ip4csum, udp4csum, tcp4csum) packets with wrong checksums arrive at other systems causing packet drops.
	Symptoms disappear when disabling at least pat of the offloading (e. g. ip4csum or udp4csum).
	For udp csum error ip4csum and udp4csum is required. Same goes for ip4csum and tcp4csum.
	This is a regression from 7.99.16 or later.

	dmesg information:
	wm0 at pci5 dev 0 function 0: Intel i82574L (rev. 0x00)
	wm0: for TX and RX interrupting at msix0 vec 0 affinity to 0
	wm0: for TX and RX interrupting at msix0 vec 1 affinity to 1
	wm0: for LINK interrupting at msix0 vec 2
	wm0: PCI-Express bus
	wm0: 2048 words (8 address bits) SPI EEPROM, version 2.1.2, Image Unique ID 0000ffff
	wm0: Ethernet address 00:00:24:d1:5e:ec
	makphy0 at wm0 phy 1: Marvell 88E1149 Gigabit PHY, rev. 1

>How-To-Repeat:
	Pick a recent -current like 20170312. a Soekris 6501 (i82574L), i386 arch and start watching csum errors on other system communicating 
	with the Soekris. Issues go away when you turn off hw csum offload (either one of ip4csum or udp4csum for udp or one of ip4csum or tcp4csum).

>Fix:
	workaround: disable any hw checksum offload in the send path

>Release-Note:

>Audit-Trail:
From: "Kengo NAKAHARA" <knakahara@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52068 CVS commit: src/sys/dev/pci
Date: Tue, 21 Mar 2017 10:39:52 +0000

 Module Name:	src
 Committed By:	knakahara
 Date:		Tue Mar 21 10:39:52 UTC 2017

 Modified Files:
 	src/sys/dev/pci: if_wm.c

 Log Message:
 fix PR kern/52068 (82574 Tx csum offload bug in not only i386 but also amd64).

 The packets sent from txq[1] could not be enabled any tx offload.
 This has been enbugged since r1.454.


 To generate a diff of this commit:
 cvs rdiff -u -r1.497 -r1.498 src/sys/dev/pci/if_wm.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Kengo NAKAHARA <k-nakahara@iij.ad.jp>
To: gnats-bugs@NetBSD.org, kern-bug-people@netbsd.org, gnats-admin@netbsd.org,
        netbsd-bugs@netbsd.org, kardel@netbsd.org
Cc: 
Subject: Re: PR/52068 CVS commit: src/sys/dev/pci
Date: Tue, 21 Mar 2017 19:45:16 +0900

 Hi kardel@n.o,

 I fix kern/52068 by if_wm.c:r1.498 and it works well in my 82574 environment.

 Could you try it?


 Thanks,

 On 2017/03/21 19:40, Kengo NAKAHARA wrote:
 > The following reply was made to PR kern/52068; it has been noted by GNATS.
 > 
 > From: "Kengo NAKAHARA" <knakahara@netbsd.org>
 > To: gnats-bugs@gnats.NetBSD.org
 > Cc: 
 > Subject: PR/52068 CVS commit: src/sys/dev/pci
 > Date: Tue, 21 Mar 2017 10:39:52 +0000
 > 
 >  Module Name:	src
 >  Committed By:	knakahara
 >  Date:		Tue Mar 21 10:39:52 UTC 2017
 >  
 >  Modified Files:
 >  	src/sys/dev/pci: if_wm.c
 >  
 >  Log Message:
 >  fix PR kern/52068 (82574 Tx csum offload bug in not only i386 but also amd64).
 >  
 >  The packets sent from txq[1] could not be enabled any tx offload.
 >  This has been enbugged since r1.454.
 >  
 >  
 >  To generate a diff of this commit:
 >  cvs rdiff -u -r1.497 -r1.498 src/sys/dev/pci/if_wm.c
 >  
 >  Please note that diffs are not public domain; they are subject to the
 >  copyright notices on the relevant files.

 -- 
 //////////////////////////////////////////////////////////////////////
 Internet Initiative Japan Inc.

 Device Engineering Section,
 IoT Platform Development Department,
 Network Division,
 Technology Unit

 Kengo NAKAHARA <k-nakahara@iij.ad.jp>

From: kardel <kardel@gateway.kardel.name>
To: Kengo NAKAHARA <k-nakahara@iij.ad.jp>, gnats-bugs@NetBSD.org,
 kern-bug-people@netbsd.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org,
 kardel@netbsd.org
Cc: 
Subject: Re: PR/52068 CVS commit: src/sys/dev/pci
Date: Tue, 21 Mar 2017 14:04:03 +0100

 ----_com.samsung.android.email_1091519194017350
 Content-Type: text/plain; charset=utf-8
 Content-Transfer-Encoding: base64

 VGhhbmtzLiDCoEknbGwgdHJ5IHRvbmlnaHQgKGNldCkKRnJhbmvCoAoKClNlbnQgZnJvbSBteSBz
 bWFydHBob25lLgotLS0tLS0tLSBPcmlnaW5hbCBtZXNzYWdlIC0tLS0tLS0tRnJvbTogS2VuZ28g
 TkFLQUhBUkEgPGstbmFrYWhhcmFAaWlqLmFkLmpwPiBEYXRlOiAzLzIxLzE3ICAxMTo0NSAgKEdN
 VCswMTowMCkgVG86IGduYXRzLWJ1Z3NATmV0QlNELm9yZywga2Vybi1idWctcGVvcGxlQG5ldGJz
 ZC5vcmcsIGduYXRzLWFkbWluQG5ldGJzZC5vcmcsIG5ldGJzZC1idWdzQG5ldGJzZC5vcmcsIGth
 cmRlbEBuZXRic2Qub3JnIFN1YmplY3Q6IFJlOiBQUi81MjA2OCBDVlMgY29tbWl0OiBzcmMvc3lz
 L2Rldi9wY2kgCkhpIGthcmRlbEBuLm8sCgpJIGZpeCBrZXJuLzUyMDY4IGJ5IGlmX3dtLmM6cjEu
 NDk4IGFuZCBpdCB3b3JrcyB3ZWxsIGluIG15IDgyNTc0IGVudmlyb25tZW50LgoKQ291bGQgeW91
 IHRyeSBpdD8KCgpUaGFua3MsCgpPbiAyMDE3LzAzLzIxIDE5OjQwLCBLZW5nbyBOQUtBSEFSQSB3
 cm90ZToKPiBUaGUgZm9sbG93aW5nIHJlcGx5IHdhcyBtYWRlIHRvIFBSIGtlcm4vNTIwNjg7IGl0
 IGhhcyBiZWVuIG5vdGVkIGJ5IEdOQVRTLgo+IAo+IEZyb206ICJLZW5nbyBOQUtBSEFSQSIgPGtu
 YWthaGFyYUBuZXRic2Qub3JnPgo+IFRvOiBnbmF0cy1idWdzQGduYXRzLk5ldEJTRC5vcmcKPiBD
 YzogCj4gU3ViamVjdDogUFIvNTIwNjggQ1ZTIGNvbW1pdDogc3JjL3N5cy9kZXYvcGNpCj4gRGF0
 ZTogVHVlLCAyMSBNYXIgMjAxNyAxMDozOTo1MiArMDAwMAo+IAo+wqAgTW9kdWxlIE5hbWU6CXNy
 Ywo+wqAgQ29tbWl0dGVkIEJ5OglrbmFrYWhhcmEKPsKgIERhdGU6CQlUdWUgTWFyIDIxIDEwOjM5
 OjUyIFVUQyAyMDE3Cj7CoCAKPsKgIE1vZGlmaWVkIEZpbGVzOgo+wqAgCXNyYy9zeXMvZGV2L3Bj
 aTogaWZfd20uYwo+wqAgCj7CoCBMb2cgTWVzc2FnZToKPsKgIGZpeCBQUiBrZXJuLzUyMDY4ICg4
 MjU3NCBUeCBjc3VtIG9mZmxvYWQgYnVnIGluIG5vdCBvbmx5IGkzODYgYnV0IGFsc28gYW1kNjQp
 Lgo+wqAgCj7CoCBUaGUgcGFja2V0cyBzZW50IGZyb20gdHhxWzFdIGNvdWxkIG5vdCBiZSBlbmFi
 bGVkIGFueSB0eCBvZmZsb2FkLgo+wqAgVGhpcyBoYXMgYmVlbiBlbmJ1Z2dlZCBzaW5jZSByMS40
 NTQuCj7CoCAKPsKgIAo+wqAgVG8gZ2VuZXJhdGUgYSBkaWZmIG9mIHRoaXMgY29tbWl0Ogo+wqAg
 Y3ZzIHJkaWZmIC11IC1yMS40OTcgLXIxLjQ5OCBzcmMvc3lzL2Rldi9wY2kvaWZfd20uYwo+wqAg
 Cj7CoCBQbGVhc2Ugbm90ZSB0aGF0IGRpZmZzIGFyZSBub3QgcHVibGljIGRvbWFpbjsgdGhleSBh
 cmUgc3ViamVjdCB0byB0aGUKPsKgIGNvcHlyaWdodCBub3RpY2VzIG9uIHRoZSByZWxldmFudCBm
 aWxlcy4KCi0tIAovLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v
 Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCkludGVybmV0IEluaXRpYXRpdmUgSmFwYW4gSW5jLgoK
 RGV2aWNlIEVuZ2luZWVyaW5nIFNlY3Rpb24sCklvVCBQbGF0Zm9ybSBEZXZlbG9wbWVudCBEZXBh
 cnRtZW50LApOZXR3b3JrIERpdmlzaW9uLApUZWNobm9sb2d5IFVuaXQKCktlbmdvIE5BS0FIQVJB
 IDxrLW5ha2FoYXJhQGlpai5hZC5qcD4K

 ----_com.samsung.android.email_1091519194017350
 Content-Type: text/html; charset=utf-8
 Content-Transfer-Encoding: base64

 PGh0bWw+PGhlYWQ+PG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0
 L2h0bWw7IGNoYXJzZXQ9VVRGLTgiPjwvaGVhZD48Ym9keT48ZGl2PlRoYW5rcy4gJm5ic3A7SSds
 bCB0cnkgdG9uaWdodCAoY2V0KTwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+RnJhbmsmbmJzcDs8
 L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2IGlk
 PSJjb21wb3Nlcl9zaWduYXR1cmUiPjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29u
 dGVudD0idGV4dC9odG1sOyBjaGFyc2V0PVVURi04Ij48ZGl2IHN0eWxlPSJmb250LXNpemU6ODUl
 O2NvbG9yOiM1NzU3NTciPlNlbnQgZnJvbSBteSBzbWFydHBob25lLjwvZGl2PjwvZGl2PjxkaXY+
 PGJyPjwvZGl2PjxkaXYgc3R5bGU9ImZvbnQtc2l6ZToxMDAlO2NvbG9yOiMwMDAwMDAiPjwhLS0g
 b3JpZ2luYWxNZXNzYWdlIC0tPjxkaXY+LS0tLS0tLS0gT3JpZ2luYWwgbWVzc2FnZSAtLS0tLS0t
 LTwvZGl2PjxkaXY+RnJvbTogS2VuZ28gTkFLQUhBUkEgJmx0O2stbmFrYWhhcmFAaWlqLmFkLmpw
 Jmd0OyA8L2Rpdj48ZGl2PkRhdGU6IDMvMjEvMTcgIDExOjQ1ICAoR01UKzAxOjAwKSA8L2Rpdj48
 ZGl2PlRvOiBnbmF0cy1idWdzQE5ldEJTRC5vcmcsIGtlcm4tYnVnLXBlb3BsZUBuZXRic2Qub3Jn
 LCBnbmF0cy1hZG1pbkBuZXRic2Qub3JnLCBuZXRic2QtYnVnc0BuZXRic2Qub3JnLCBrYXJkZWxA
 bmV0YnNkLm9yZyA8L2Rpdj48ZGl2PlN1YmplY3Q6IFJlOiBQUi81MjA2OCBDVlMgY29tbWl0OiBz
 cmMvc3lzL2Rldi9wY2kgPC9kaXY+PGRpdj48YnI+PC9kaXY+PC9kaXY+SGkga2FyZGVsQG4ubyw8
 YnI+PGJyPkkgZml4IGtlcm4vNTIwNjggYnkgaWZfd20uYzpyMS40OTggYW5kIGl0IHdvcmtzIHdl
 bGwgaW4gbXkgODI1NzQgZW52aXJvbm1lbnQuPGJyPjxicj5Db3VsZCB5b3UgdHJ5IGl0Pzxicj48
 YnI+PGJyPlRoYW5rcyw8YnI+PGJyPk9uIDIwMTcvMDMvMjEgMTk6NDAsIEtlbmdvIE5BS0FIQVJB
 IHdyb3RlOjxicj4mZ3Q7IFRoZSBmb2xsb3dpbmcgcmVwbHkgd2FzIG1hZGUgdG8gUFIga2Vybi81
 MjA2ODsgaXQgaGFzIGJlZW4gbm90ZWQgYnkgR05BVFMuPGJyPiZndDsgPGJyPiZndDsgRnJvbTog
 IktlbmdvIE5BS0FIQVJBIiAmbHQ7a25ha2FoYXJhQG5ldGJzZC5vcmcmZ3Q7PGJyPiZndDsgVG86
 IGduYXRzLWJ1Z3NAZ25hdHMuTmV0QlNELm9yZzxicj4mZ3Q7IENjOiA8YnI+Jmd0OyBTdWJqZWN0
 OiBQUi81MjA2OCBDVlMgY29tbWl0OiBzcmMvc3lzL2Rldi9wY2k8YnI+Jmd0OyBEYXRlOiBUdWUs
 IDIxIE1hciAyMDE3IDEwOjM5OjUyICswMDAwPGJyPiZndDsgPGJyPiZndDsmbmJzcDsgTW9kdWxl
 IE5hbWU6CXNyYzxicj4mZ3Q7Jm5ic3A7IENvbW1pdHRlZCBCeToJa25ha2FoYXJhPGJyPiZndDsm
 bmJzcDsgRGF0ZToJCVR1ZSBNYXIgMjEgMTA6Mzk6NTIgVVRDIDIwMTc8YnI+Jmd0OyZuYnNwOyA8
 YnI+Jmd0OyZuYnNwOyBNb2RpZmllZCBGaWxlczo8YnI+Jmd0OyZuYnNwOyAJc3JjL3N5cy9kZXYv
 cGNpOiBpZl93bS5jPGJyPiZndDsmbmJzcDsgPGJyPiZndDsmbmJzcDsgTG9nIE1lc3NhZ2U6PGJy
 PiZndDsmbmJzcDsgZml4IFBSIGtlcm4vNTIwNjggKDgyNTc0IFR4IGNzdW0gb2ZmbG9hZCBidWcg
 aW4gbm90IG9ubHkgaTM4NiBidXQgYWxzbyBhbWQ2NCkuPGJyPiZndDsmbmJzcDsgPGJyPiZndDsm
 bmJzcDsgVGhlIHBhY2tldHMgc2VudCBmcm9tIHR4cVsxXSBjb3VsZCBub3QgYmUgZW5hYmxlZCBh
 bnkgdHggb2ZmbG9hZC48YnI+Jmd0OyZuYnNwOyBUaGlzIGhhcyBiZWVuIGVuYnVnZ2VkIHNpbmNl
 IHIxLjQ1NC48YnI+Jmd0OyZuYnNwOyA8YnI+Jmd0OyZuYnNwOyA8YnI+Jmd0OyZuYnNwOyBUbyBn
 ZW5lcmF0ZSBhIGRpZmYgb2YgdGhpcyBjb21taXQ6PGJyPiZndDsmbmJzcDsgY3ZzIHJkaWZmIC11
 IC1yMS40OTcgLXIxLjQ5OCBzcmMvc3lzL2Rldi9wY2kvaWZfd20uYzxicj4mZ3Q7Jm5ic3A7IDxi
 cj4mZ3Q7Jm5ic3A7IFBsZWFzZSBub3RlIHRoYXQgZGlmZnMgYXJlIG5vdCBwdWJsaWMgZG9tYWlu
 OyB0aGV5IGFyZSBzdWJqZWN0IHRvIHRoZTxicj4mZ3Q7Jm5ic3A7IGNvcHlyaWdodCBub3RpY2Vz
 IG9uIHRoZSByZWxldmFudCBmaWxlcy48YnI+PGJyPi0tIDxicj4vLy8vLy8vLy8vLy8vLy8vLy8v
 Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vPGJyPklu
 dGVybmV0IEluaXRpYXRpdmUgSmFwYW4gSW5jLjxicj48YnI+RGV2aWNlIEVuZ2luZWVyaW5nIFNl
 Y3Rpb24sPGJyPklvVCBQbGF0Zm9ybSBEZXZlbG9wbWVudCBEZXBhcnRtZW50LDxicj5OZXR3b3Jr
 IERpdmlzaW9uLDxicj5UZWNobm9sb2d5IFVuaXQ8YnI+PGJyPktlbmdvIE5BS0FIQVJBICZsdDtr
 LW5ha2FoYXJhQGlpai5hZC5qcCZndDs8YnI+PC9ib2R5PjwvaHRtbD4=

 ----_com.samsung.android.email_1091519194017350--

From: Frank Kardel <kardel@netbsd.org>
To: gnats-bugs@NetBSD.org, kern-bug-people@netbsd.org, 
 gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, kardel@netbsd.org
Cc: 
Subject: Re: PR/52068 CVS commit: src/sys/dev/pci
Date: Tue, 21 Mar 2017 22:21:19 +0100

 Hi knakahara@n.o !

 I checked the new version and no more checksum errors for UDP and TCP.
 Thanks for the fix.

 I do notice errors on ICMP though:

 icmp:
          806 calls to icmp_error
          0 errors not generated because old message was icmp
          Output histogram:
                  echoreply: 72
                  unreach: 643
                  redirect: 124
                  timxceed: 3
          0 messages with bad code fields
          0 messages < minimum length
          15 bad checksums
          0 messages with bad length
 ...
 Gateway# ping www.heise.de
 PING www.heise.de (193.99.144.85): 56 data bytes
 64 bytes from 193.99.144.85: icmp_seq=0 ttl=243 time=19.751926 ms
 64 bytes from 193.99.144.85: icmp_seq=1 ttl=243 time=20.527536 ms
 64 bytes from 193.99.144.85: icmp_seq=2 ttl=243 time=17.968474 ms
 64 bytes from 193.99.144.85: icmp_seq=3 ttl=243 time=19.501118 ms
 64 bytes from 193.99.144.85: icmp_seq=4 ttl=243 time=28.901272 ms
 64 bytes from 193.99.144.85: icmp_seq=5 ttl=243 time=16.245018 ms
 64 bytes from 193.99.144.85: icmp_seq=6 ttl=243 time=29.275564 ms
 64 bytes from 193.99.144.85: icmp_seq=7 ttl=243 time=18.914712 ms
 64 bytes from 193.99.144.85: icmp_seq=8 ttl=243 time=25.853516 ms
 64 bytes from 193.99.144.85: icmp_seq=9 ttl=243 time=17.357554 ms
 ^C
 ----www.heise.de PING Statistics----
 10 packets transmitted, 10 packets received, 0.0% packet loss
 round-trip min/avg/max/stddev = 16.245018/21.429669/29.275564/4.785034 ms

 icmp:
          807 calls to icmp_error
          0 errors not generated because old message was icmp
          Output histogram:
                  echoreply: 72
                  unreach: 644
                  redirect: 124
                  timxceed: 3
          0 messages with bad code fields
          0 messages < minimum length
          24 bad checksums
          0 messages with bad length

 that is 10 ping exchanges (ICMP ECHO/ICMP REPLY) and 9 additional
 icmp bad checksums.

 That seems a bit surprising and may have been there before the fix - I 
 just noticed it now.

 Best regards,
    Frank

 On 03/21/17 11:50, Kengo NAKAHARA wrote:
 > The following reply was made to PR kern/52068; it has been noted by GNATS.
 >
 > From: Kengo NAKAHARA <k-nakahara@iij.ad.jp>
 > To: gnats-bugs@NetBSD.org, kern-bug-people@netbsd.org, gnats-admin@netbsd.org,
 >          netbsd-bugs@netbsd.org, kardel@netbsd.org
 > Cc:
 > Subject: Re: PR/52068 CVS commit: src/sys/dev/pci
 > Date: Tue, 21 Mar 2017 19:45:16 +0900
 >
 >   Hi kardel@n.o,
 >   
 >   I fix kern/52068 by if_wm.c:r1.498 and it works well in my 82574 environment.
 >   
 >   Could you try it?
 >   
 >   
 >   Thanks,
 >   
 >   On 2017/03/21 19:40, Kengo NAKAHARA wrote:
 >   > The following reply was made to PR kern/52068; it has been noted by GNATS.
 >   >
 >   > From: "Kengo NAKAHARA" <knakahara@netbsd.org>
 >   > To: gnats-bugs@gnats.NetBSD.org
 >   > Cc:
 >   > Subject: PR/52068 CVS commit: src/sys/dev/pci
 >   > Date: Tue, 21 Mar 2017 10:39:52 +0000
 >   >
 >   >  Module Name:	src
 >   >  Committed By:	knakahara
 >   >  Date:		Tue Mar 21 10:39:52 UTC 2017
 >   >
 >   >  Modified Files:
 >   >  	src/sys/dev/pci: if_wm.c
 >   >
 >   >  Log Message:
 >   >  fix PR kern/52068 (82574 Tx csum offload bug in not only i386 but also amd64).
 >   >
 >   >  The packets sent from txq[1] could not be enabled any tx offload.
 >   >  This has been enbugged since r1.454.
 >   >
 >   >
 >   >  To generate a diff of this commit:
 >   >  cvs rdiff -u -r1.497 -r1.498 src/sys/dev/pci/if_wm.c
 >   >
 >   >  Please note that diffs are not public domain; they are subject to the
 >   >  copyright notices on the relevant files.
 >   
 >   --
 >   //////////////////////////////////////////////////////////////////////
 >   Internet Initiative Japan Inc.
 >   
 >   Device Engineering Section,
 >   IoT Platform Development Department,
 >   Network Division,
 >   Technology Unit
 >   
 >   Kengo NAKAHARA <k-nakahara@iij.ad.jp>
 >   

From: Kengo NAKAHARA <k-nakahara@iij.ad.jp>
To: kardel@netbsd.org, gnats-bugs@NetBSD.org, kern-bug-people@netbsd.org,
        gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Cc: 
Subject: Re: PR/52068 CVS commit: src/sys/dev/pci
Date: Wed, 22 Mar 2017 11:15:14 +0900

 Hi kardel@n.o,

 On 2017/03/22 6:21, Frank Kardel wrote:
 > I checked the new version and no more checksum errors for UDP and TCP.
 > Thanks for the fix.

 Thank you for your testing. I am glad it is fixed. :)

 > I do notice errors on ICMP though:
 snip 
 > That seems a bit surprising and may have been there before the fix - I 
 > just noticed it now.

 Hmm, I have met this problem last week. After consulting ryo@n.o,
 he fixed this problem by ping.c:r1.116 at May 17.
 Do you use a little old ping? If so, could you update and try again?


 Thanks,

 -- 
 //////////////////////////////////////////////////////////////////////
 Internet Initiative Japan Inc.

 Device Engineering Section,
 IoT Platform Development Department,
 Network Division,
 Technology Unit

 Kengo NAKAHARA <k-nakahara@iij.ad.jp>

From: kardel <kardel@gateway.kardel.name>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/52068 CVS commit: src/sys/dev/pci
Date: Wed, 22 Mar 2017 07:49:02 +0100

 ----_com.samsung.android.email_1232810503494760
 Content-Type: text/plain; charset=utf-8
 Content-Transfer-Encoding: base64

 WWVzLCBteSBwaW5nIGlzIGZyb20gbW9yZSB0aGVuIGEgd2VlayBhZ28uIFdpbGwgcmVjaGVjay5U
 aGFua3MsRnJhbmsKCgpTZW50IGZyb20gbXkgc21hcnRwaG9uZS4KLS0tLS0tLS0gT3JpZ2luYWwg
 bWVzc2FnZSAtLS0tLS0tLUZyb206IEtlbmdvIE5BS0FIQVJBIDxrLW5ha2FoYXJhQGlpai5hZC5q
 cD4gRGF0ZTogMy8yMi8xNyAgMDM6MjAgIChHTVQrMDE6MDApIFRvOiBrZXJuLWJ1Zy1wZW9wbGVA
 bmV0YnNkLm9yZywgZ25hdHMtYWRtaW5AbmV0YnNkLm9yZywgbmV0YnNkLWJ1Z3NAbmV0YnNkLm9y
 Zywga2FyZGVsQG5ldGJzZC5vcmcgU3ViamVjdDogUmU6IFBSLzUyMDY4IENWUyBjb21taXQ6IHNy
 Yy9zeXMvZGV2L3BjaSAKVGhlIGZvbGxvd2luZyByZXBseSB3YXMgbWFkZSB0byBQUiBrZXJuLzUy
 MDY4OyBpdCBoYXMgYmVlbiBub3RlZCBieSBHTkFUUy4KCkZyb206IEtlbmdvIE5BS0FIQVJBIDxr
 LW5ha2FoYXJhQGlpai5hZC5qcD4KVG86IGthcmRlbEBuZXRic2Qub3JnLCBnbmF0cy1idWdzQE5l
 dEJTRC5vcmcsIGtlcm4tYnVnLXBlb3BsZUBuZXRic2Qub3JnLArCoMKgwqDCoMKgwqDCoCBnbmF0
 cy1hZG1pbkBuZXRic2Qub3JnLCBuZXRic2QtYnVnc0BuZXRic2Qub3JnCkNjOiAKU3ViamVjdDog
 UmU6IFBSLzUyMDY4IENWUyBjb21taXQ6IHNyYy9zeXMvZGV2L3BjaQpEYXRlOiBXZWQsIDIyIE1h
 ciAyMDE3IDExOjE1OjE0ICswOTAwCgogSGkga2FyZGVsQG4ubywKIAogT24gMjAxNy8wMy8yMiA2
 OjIxLCBGcmFuayBLYXJkZWwgd3JvdGU6CiA+IEkgY2hlY2tlZCB0aGUgbmV3IHZlcnNpb24gYW5k
 IG5vIG1vcmUgY2hlY2tzdW0gZXJyb3JzIGZvciBVRFAgYW5kIFRDUC4KID4gVGhhbmtzIGZvciB0
 aGUgZml4LgogCiBUaGFuayB5b3UgZm9yIHlvdXIgdGVzdGluZy4gSSBhbSBnbGFkIGl0IGlzIGZp
 eGVkLiA6KQogCiA+IEkgZG8gbm90aWNlIGVycm9ycyBvbiBJQ01QIHRob3VnaDoKIHNuaXAgCiA+
 IFRoYXQgc2VlbXMgYSBiaXQgc3VycHJpc2luZyBhbmQgbWF5IGhhdmUgYmVlbiB0aGVyZSBiZWZv
 cmUgdGhlIGZpeCAtIEkgCiA+IGp1c3Qgbm90aWNlZCBpdCBub3cuCiAKIEhtbSwgSSBoYXZlIG1l
 dCB0aGlzIHByb2JsZW0gbGFzdCB3ZWVrLiBBZnRlciBjb25zdWx0aW5nIHJ5b0BuLm8sCiBoZSBm
 aXhlZCB0aGlzIHByb2JsZW0gYnkgcGluZy5jOnIxLjExNiBhdCBNYXkgMTcuCiBEbyB5b3UgdXNl
 IGEgbGl0dGxlIG9sZCBwaW5nPyBJZiBzbywgY291bGQgeW91IHVwZGF0ZSBhbmQgdHJ5IGFnYWlu
 PwogCiAKIFRoYW5rcywKIAogLS0gCiAvLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v
 Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vCiBJbnRlcm5ldCBJbml0aWF0aXZl
 IEphcGFuIEluYy4KIAogRGV2aWNlIEVuZ2luZWVyaW5nIFNlY3Rpb24sCiBJb1QgUGxhdGZvcm0g
 RGV2ZWxvcG1lbnQgRGVwYXJ0bWVudCwKIE5ldHdvcmsgRGl2aXNpb24sCiBUZWNobm9sb2d5IFVu
 aXQKIAogS2VuZ28gTkFLQUhBUkEgPGstbmFrYWhhcmFAaWlqLmFkLmpwPgogCg==

 ----_com.samsung.android.email_1232810503494760
 Content-Type: text/html; charset=utf-8
 Content-Transfer-Encoding: base64

 PGh0bWw+PGhlYWQ+PG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0
 L2h0bWw7IGNoYXJzZXQ9VVRGLTgiPjwvaGVhZD48Ym9keT48ZGl2PlllcywgbXkgcGluZyBpcyBm
 cm9tIG1vcmUgdGhlbiBhIHdlZWsgYWdvLiBXaWxsIHJlY2hlY2suPC9kaXY+PGRpdj5UaGFua3Ms
 PC9kaXY+PGRpdj5GcmFuazwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXY+
 PGJyPjwvZGl2PjxkaXYgaWQ9ImNvbXBvc2VyX3NpZ25hdHVyZSI+PG1ldGEgaHR0cC1lcXVpdj0i
 Q29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9VVRGLTgiPjxkaXYgc3R5
 bGU9ImZvbnQtc2l6ZTo4NSU7Y29sb3I6IzU3NTc1NyI+U2VudCBmcm9tIG15IHNtYXJ0cGhvbmUu
 PC9kaXY+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdiBzdHlsZT0iZm9udC1zaXplOjEwMCU7Y29s
 b3I6IzAwMDAwMCI+PCEtLSBvcmlnaW5hbE1lc3NhZ2UgLS0+PGRpdj4tLS0tLS0tLSBPcmlnaW5h
 bCBtZXNzYWdlIC0tLS0tLS0tPC9kaXY+PGRpdj5Gcm9tOiBLZW5nbyBOQUtBSEFSQSAmbHQ7ay1u
 YWthaGFyYUBpaWouYWQuanAmZ3Q7IDwvZGl2PjxkaXY+RGF0ZTogMy8yMi8xNyAgMDM6MjAgIChH
 TVQrMDE6MDApIDwvZGl2PjxkaXY+VG86IGtlcm4tYnVnLXBlb3BsZUBuZXRic2Qub3JnLCBnbmF0
 cy1hZG1pbkBuZXRic2Qub3JnLCBuZXRic2QtYnVnc0BuZXRic2Qub3JnLCBrYXJkZWxAbmV0YnNk
 Lm9yZyA8L2Rpdj48ZGl2PlN1YmplY3Q6IFJlOiBQUi81MjA2OCBDVlMgY29tbWl0OiBzcmMvc3lz
 L2Rldi9wY2kgPC9kaXY+PGRpdj48YnI+PC9kaXY+PC9kaXY+VGhlIGZvbGxvd2luZyByZXBseSB3
 YXMgbWFkZSB0byBQUiBrZXJuLzUyMDY4OyBpdCBoYXMgYmVlbiBub3RlZCBieSBHTkFUUy48YnI+
 PGJyPkZyb206IEtlbmdvIE5BS0FIQVJBICZsdDtrLW5ha2FoYXJhQGlpai5hZC5qcCZndDs8YnI+
 VG86IGthcmRlbEBuZXRic2Qub3JnLCBnbmF0cy1idWdzQE5ldEJTRC5vcmcsIGtlcm4tYnVnLXBl
 b3BsZUBuZXRic2Qub3JnLDxicj4mbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsm
 bmJzcDsgZ25hdHMtYWRtaW5AbmV0YnNkLm9yZywgbmV0YnNkLWJ1Z3NAbmV0YnNkLm9yZzxicj5D
 YzogPGJyPlN1YmplY3Q6IFJlOiBQUi81MjA2OCBDVlMgY29tbWl0OiBzcmMvc3lzL2Rldi9wY2k8
 YnI+RGF0ZTogV2VkLCAyMiBNYXIgMjAxNyAxMToxNToxNCArMDkwMDxicj48YnI+IEhpIGthcmRl
 bEBuLm8sPGJyPiA8YnI+IE9uIDIwMTcvMDMvMjIgNjoyMSwgRnJhbmsgS2FyZGVsIHdyb3RlOjxi
 cj4gJmd0OyBJIGNoZWNrZWQgdGhlIG5ldyB2ZXJzaW9uIGFuZCBubyBtb3JlIGNoZWNrc3VtIGVy
 cm9ycyBmb3IgVURQIGFuZCBUQ1AuPGJyPiAmZ3Q7IFRoYW5rcyBmb3IgdGhlIGZpeC48YnI+IDxi
 cj4gVGhhbmsgeW91IGZvciB5b3VyIHRlc3RpbmcuIEkgYW0gZ2xhZCBpdCBpcyBmaXhlZC4gOik8
 YnI+IDxicj4gJmd0OyBJIGRvIG5vdGljZSBlcnJvcnMgb24gSUNNUCB0aG91Z2g6PGJyPiBzbmlw
 IDxicj4gJmd0OyBUaGF0IHNlZW1zIGEgYml0IHN1cnByaXNpbmcgYW5kIG1heSBoYXZlIGJlZW4g
 dGhlcmUgYmVmb3JlIHRoZSBmaXggLSBJIDxicj4gJmd0OyBqdXN0IG5vdGljZWQgaXQgbm93Ljxi
 cj4gPGJyPiBIbW0sIEkgaGF2ZSBtZXQgdGhpcyBwcm9ibGVtIGxhc3Qgd2Vlay4gQWZ0ZXIgY29u
 c3VsdGluZyByeW9Abi5vLDxicj4gaGUgZml4ZWQgdGhpcyBwcm9ibGVtIGJ5IHBpbmcuYzpyMS4x
 MTYgYXQgTWF5IDE3Ljxicj4gRG8geW91IHVzZSBhIGxpdHRsZSBvbGQgcGluZz8gSWYgc28sIGNv
 dWxkIHlvdSB1cGRhdGUgYW5kIHRyeSBhZ2Fpbj88YnI+IDxicj4gPGJyPiBUaGFua3MsPGJyPiA8
 YnI+IC0tIDxicj4gLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v
 Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLzxicj4gSW50ZXJuZXQgSW5pdGlhdGl2ZSBKYXBhbiBJ
 bmMuPGJyPiA8YnI+IERldmljZSBFbmdpbmVlcmluZyBTZWN0aW9uLDxicj4gSW9UIFBsYXRmb3Jt
 IERldmVsb3BtZW50IERlcGFydG1lbnQsPGJyPiBOZXR3b3JrIERpdmlzaW9uLDxicj4gVGVjaG5v
 bG9neSBVbml0PGJyPiA8YnI+IEtlbmdvIE5BS0FIQVJBICZsdDtrLW5ha2FoYXJhQGlpai5hZC5q
 cCZndDs8YnI+IDxicj48L2JvZHk+PC9odG1sPg==

 ----_com.samsung.android.email_1232810503494760--

From: Frank Kardel <kardel@netbsd.org>
To: Kengo NAKAHARA <k-nakahara@iij.ad.jp>
Cc: gnats-bugs@NetBSD.org
Subject: Re: PR/52068 CVS commit: src/sys/dev/pci
Date: Wed, 22 Mar 2017 11:31:02 +0100

 New ping is also fine. Leaves the ICMP check error counters alone.

 So we can consider this PR closed.

 Thanks
    Frank

 On 03/22/17 03:20, Kengo NAKAHARA wrote:
 > The following reply was made to PR kern/52068; it has been noted by GNATS.
 >
 > From: Kengo NAKAHARA <k-nakahara@iij.ad.jp>
 > To: kardel@netbsd.org, gnats-bugs@NetBSD.org, kern-bug-people@netbsd.org,
 >          gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
 > Cc:
 > Subject: Re: PR/52068 CVS commit: src/sys/dev/pci
 > Date: Wed, 22 Mar 2017 11:15:14 +0900
 >
 >   Hi kardel@n.o,
 >   
 >   On 2017/03/22 6:21, Frank Kardel wrote:
 >   > I checked the new version and no more checksum errors for UDP and TCP.
 >   > Thanks for the fix.
 >   
 >   Thank you for your testing. I am glad it is fixed. :)
 >   
 >   > I do notice errors on ICMP though:
 >   snip
 >   > That seems a bit surprising and may have been there before the fix - I
 >   > just noticed it now.
 >   
 >   Hmm, I have met this problem last week. After consulting ryo@n.o,
 >   he fixed this problem by ping.c:r1.116 at May 17.
 >   Do you use a little old ping? If so, could you update and try again?
 >   
 >   
 >   Thanks,
 >   
 >   --
 >   //////////////////////////////////////////////////////////////////////
 >   Internet Initiative Japan Inc.
 >   
 >   Device Engineering Section,
 >   IoT Platform Development Department,
 >   Network Division,
 >   Technology Unit
 >   
 >   Kengo NAKAHARA <k-nakahara@iij.ad.jp>
 >   

State-Changed-From-To: open->closed
State-Changed-By: knakahara@NetBSD.org
State-Changed-When: Wed, 22 Mar 2017 10:45:27 +0000
State-Changed-Why:
fixed by if_wm.c:r1.498 and tested by reporter(kardel@n.o)


>Unformatted:

Home	PR Database Search