NetBSD Problem Report #52149

From kim@tac.gw.com  Sun Apr  9 23:02:02 2017
Return-Path: <kim@tac.gw.com>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 070B67A217
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  9 Apr 2017 23:02:02 +0000 (UTC)
Message-Id: <20170409230159.63F70B13B@equinoxe.gw.com>
Date: Sun,  9 Apr 2017 23:01:59 +0000 (UTC)
From: Kimmo Suominen <kim@netbsd.org>
Reply-To: Kimmo Suominen <kim@netbsd.org>
To: gnats-bugs@NetBSD.org
Subject: make tiff optional for libwebp
X-Send-Pr-Version: 3.95

>Number:         52149
>Category:       pkg
>Synopsis:       make tiff optional for libwebp
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kim
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 09 23:05:00 +0000 2017
>Closed-Date:    Sat Apr 15 15:59:54 +0000 2017
>Last-Modified:  Sat Apr 15 15:59:54 +0000 2017
>Originator:     Kimmo Suominen
>Release:        NetBSD 7.0.2
>Organization:

>Environment:


System: NetBSD equinoxe.gw.com 7.0.2 NetBSD 7.0.2 (XEN3_DOMU.201610210724Z) amd64
Architecture: x86_64
Machine: amd64
>Description:
        Make tiff option when building libwebp, as tiff has many long-standing
        vulnerabilities.
>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/libwebp/Makefile,v
retrieving revision 1.21
diff -u -r1.21 Makefile
--- Makefile	28 Feb 2017 14:40:47 -0000	1.21
+++ Makefile	9 Apr 2017 23:01:06 -0000
@@ -1,6 +1,7 @@
 # $NetBSD: Makefile,v 1.21 2017/02/28 14:40:47 ryoon Exp $

 DISTNAME=	libwebp-0.6.0
+PKGREVISION=	1
 CATEGORIES=	graphics
 MASTER_SITES=	http://downloads.webmproject.org/releases/webp/

@@ -9,6 +10,8 @@
 COMMENT=	WebP image format library and tools
 LICENSE=	modified-bsd

+.include "options.mk"
+
 USE_LIBTOOL=	yes
 GNU_CONFIGURE=	yes

@@ -29,6 +32,5 @@

 .include "../../graphics/giflib/buildlink3.mk"
 .include "../../graphics/png/buildlink3.mk"
-.include "../../graphics/tiff/buildlink3.mk"
 .include "../../mk/jpeg.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: options.mk
===================================================================
RCS file: options.mk
diff -N options.mk
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ options.mk	9 Apr 2017 23:01:06 -0000
@@ -0,0 +1,12 @@
+# $NetBSD$
+
+PKG_OPTIONS_VAR=	PKG_OPTIONS.libwebp
+PKG_SUPPORTED_OPTIONS=	tiff
+
+.include "../../mk/bsd.options.mk"
+
+.if !empty(PKG_OPTIONS:Mtiff)
+.include "../../graphics/tiff/buildlink3.mk"
+.else
+CONFIGURE_ARGS+=	--disable-tiff
+.endif

>Release-Note:

>Audit-Trail:
From: "Kimmo Suominen" <kim@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52149 CVS commit: pkgsrc/graphics/libwebp
Date: Sat, 15 Apr 2017 15:48:13 +0000

 Module Name:	pkgsrc
 Committed By:	kim
 Date:		Sat Apr 15 15:48:13 UTC 2017

 Modified Files:
 	pkgsrc/graphics/libwebp: Makefile
 Added Files:
 	pkgsrc/graphics/libwebp: options.mk

 Log Message:
 Make tiff option when building libwebp, as tiff has many long-standing
 vulnerabilities. Still enabled by default, as before. Ok by wiz@.

 Fixes PR pkg/52149 and adds tiff to PKG_SUGGESTED_OPTIONS.


 To generate a diff of this commit:
 cvs rdiff -u -r1.21 -r1.22 pkgsrc/graphics/libwebp/Makefile
 cvs rdiff -u -r0 -r1.1 pkgsrc/graphics/libwebp/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: pkg-manager->kim
Responsible-Changed-By: kim@NetBSD.org
Responsible-Changed-When: Sat, 15 Apr 2017 15:59:54 +0000
Responsible-Changed-Why:
Committed myself.
.


State-Changed-From-To: open->closed
State-Changed-By: kim@NetBSD.org
State-Changed-When: Sat, 15 Apr 2017 15:59:54 +0000
State-Changed-Why:
Fixed by making it not change the default case


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.