NetBSD Problem Report #52207

From paul@whooppee.com  Mon May  1 22:34:27 2017
Return-Path: <paul@whooppee.com>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 085DC7A1FB
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  1 May 2017 22:34:27 +0000 (UTC)
Message-Id: <20170501223423.DC1BC16E68@speedy.whooppee.com>
Date: Tue,  2 May 2017 06:34:23 +0800 (+08)
From: paul@whooppee.com
Reply-To: paul@whooppee.com
To: gnats-bugs@NetBSD.org
Subject: rump/rumpkern/t_kern fails
X-Send-Pr-Version: 3.95

>Number:         52207
>Category:       bin
>Synopsis:       Test rump/rumpkern/t_kern fails
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pgoyette
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 01 22:35:00 +0000 2017
>Closed-Date:    Wed May 03 12:11:06 +0000 2017
>Last-Modified:  Wed May 03 12:15:00 +0000 2017
>Originator:     Paul Goyette
>Release:        NetBSD 7.99.66
>Organization:
+------------------+--------------------------+----------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+------------------+--------------------------+----------------------------+
>Environment:


System: NetBSD speedy.whooppee.com 7.99.66 NetBSD 7.99.66 (SPEEDY 2017-03-24 21:50:36 UTC) #0: Fri Mar 24 22:50:09 UTC 2017 paul@speedy.whooppee.com:/build/netbsd-local/obj/amd64/sys/arch/amd64/compile/SPEEDY amd64
Architecture: x86_64
Machine: amd64
>Description:
The string comparisons that check for exptected output are incorrect.  For
example, the first testcase expects the string

	"mutex error: lockdebug_free: is locked or in use"

Yet the actual string returned is

	"mutex error: mutex_destroy,139: lockdebug_free: is locked or in use"

The inclusion of the function name and line number cause the comparison
to fail, and thus a successful test completion is reported as a failure.

Note that this test program is normally atf_skip()ed, unless the rump
kernel was built with LOCKDEBUG.  Thus this error is not seen on the
rel-eng automated test-beds.

>How-To-Repeat:
Perhaps do a regex match on the returned text, rather than a simple
string compare?

Or, check for the common prefix "mutex error:", skip the function and line
number, and then compare the rest of the returned text to the argument?


>Fix:


>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: bin-bug-people->pgoyette
Responsible-Changed-By: pgoyette@NetBSD.org
Responsible-Changed-When: Wed, 03 May 2017 09:54:58 +0000
Responsible-Changed-Why:
I'll take this.  Problem understood, and a fix is under test.


From: "Paul Goyette" <pgoyette@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52207 CVS commit: src/tests/rump/rumpkern
Date: Wed, 3 May 2017 12:09:41 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Wed May  3 12:09:41 UTC 2017

 Modified Files:
 	src/tests/rump/rumpkern: t_kern.c

 Log Message:
 Fix detection of expected results.  The rump kernel code apparently
 includes source-code line numbers in the messages, so rather than
 hard-coding them in the test, just use a reg-ex to match the text.

 Fixes PR bin/52207


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 src/tests/rump/rumpkern/t_kern.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Wed, 03 May 2017 12:11:06 +0000
State-Changed-Why:
I fixed it.


From: "Paul Goyette" <pgoyette@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52207 CVS commit: [prg-localcount2] src/tests/rump/rumpkern
Date: Wed, 3 May 2017 12:10:22 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Wed May  3 12:10:22 UTC 2017

 Modified Files:
 	src/tests/rump/rumpkern [prg-localcount2]: t_kern.c

 Log Message:
 Include fix for PR bin/52207 on the localcount2 branch.


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.4.4.1 src/tests/rump/rumpkern/t_kern.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search