NetBSD Problem Report #52293

From www@NetBSD.org  Sun Jun 11 22:23:28 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (verified OK))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 244ED7A175
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 11 Jun 2017 22:23:28 +0000 (UTC)
Message-Id: <20170611222327.10D797A288@mollari.NetBSD.org>
Date: Sun, 11 Jun 2017 22:23:27 +0000 (UTC)
From: waddell@caravaninfotech.com
Reply-To: waddell@caravaninfotech.com
To: gnats-bugs@NetBSD.org
Subject: gitolite needs update due to move to perl 5.26
X-Send-Pr-Version: www-1.0

>Number:         52293
>Category:       pkg
>Synopsis:       gitolite needs update due to move to perl 5.26
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Jun 11 22:25:01 +0000 2017
>Closed-Date:    Mon Jun 12 08:24:53 +0000 2017
>Last-Modified:  Sun Jun 21 15:10:01 +0000 2020
>Originator:     Harry Waddell
>Release:        HEAD on 06/11/2017
>Organization:
>Environment:
NetBSD nqapod 7.1_STABLE NetBSD 7.1_STABLE (XEN3_DOMU.201706012030Z) amd64
You have new mail in /var/mail/root
>Description:
gitolite 3.6.5 which is currently in the pkgsrc HEAD will not work with the recently upgraded perl 5.26.x. Gitolite 3.6.6 has the fix. This is from their CHANGELOG: 

[root@nqapod:gitolite]> more gitolite-3.6.6/CHANGELOG
2016-09-08  v3.6.6  simple but important fix for a future perl deprecation
                    (perl will be removing "." from @INC in 5.24)


>How-To-Repeat:
install gitolite from current pkgsrc. That works, but you can't push to the repo: 

taliesin-3: waddell$ git push origin master
WARNING: do "conf/gitolite.conf-compiled.pm" failed, '.' is no longer in @INC; did you mean do "./conf/gitolite.conf-compiled.pm"? at /usr/pkg/lib/perl5/vendor_perl/5.26.0/x86_64-netbsd-thread-multi/Gitolite/Conf/Load.pm line 281, <DATA> line 1.

FATAL: parse 'conf/gitolite.conf-compiled.pm' failed: Inappropriate ioctl for device
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.


>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/gitolite/Makefile,v
retrieving revision 1.24
diff -u -r1.24 Makefile
--- Makefile    9 Jul 2016 06:38:07 -0000       1.24
+++ Makefile    11 Jun 2017 22:11:25 -0000
@@ -1,8 +1,8 @@
 # $NetBSD: Makefile,v 1.24 2016/07/09 06:38:07 wiz Exp $

-GLVER=         3.6.5
+GLVER=         3.6.6
 DISTNAME=      gitolite-${GLVER}
-PKGREVISION=   1
+PKGREVISION=
 CATEGORIES=    devel net
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=sitaramc/}
 GITHUB_PROJECT=        gitolite
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/devel/gitolite/distinfo,v
retrieving revision 1.13
diff -u -r1.13 distinfo
--- distinfo    5 Jul 2016 18:49:23 -0000       1.13
+++ distinfo    11 Jun 2017 22:11:25 -0000
@@ -1,6 +1,6 @@
 $NetBSD: distinfo,v 1.13 2016/07/05 18:49:23 ryoon Exp $

-SHA1 (gitolite-3.6.5.tar.gz) = 90273d462d85ebbe8c4522777df1c4b5d527bce2
-RMD160 (gitolite-3.6.5.tar.gz) = 8f73fca9ddc936211f964b9deee7922a9a6dfce2
-SHA512 (gitolite-3.6.5.tar.gz) = 60796663a87c2b169c08e4e26edfb76408428887d3e932677f4ca95a8c7f82e9e300a7400d3d900c371628b23972be063444b7c036218f6ff0ab13626a886f90
-Size (gitolite-3.6.5.tar.gz) = 182496 bytes
+SHA1 (gitolite-3.6.6.tar.gz) = f3f0604b40a792495a93f8d04623fd2c3fbca77d
+RMD160 (gitolite-3.6.6.tar.gz) = 5506d6d4f9a0d754cd149ce53bdfd2a7194e8024
+SHA512 (gitolite-3.6.6.tar.gz) = 1529330ed2afa315fcb650c55d515e5d4b61921f46b4d763a759537434492959f100d2219ab7673e568d46f397a25a45d4388fe3827ea988333fc8719820f8bc
+Size (gitolite-3.6.6.tar.gz) = 183469 bytes

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 12 Jun 2017 08:24:53 +0000
State-Changed-Why:
Committed, thanks!


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52293 CVS commit: pkgsrc/devel/gitolite
Date: Mon, 12 Jun 2017 08:24:37 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Mon Jun 12 08:24:37 UTC 2017

 Modified Files:
 	pkgsrc/devel/gitolite: Makefile distinfo

 Log Message:
 Updated gitolite to 3.6.6.

 2016-09-08  v3.6.6  simple but important fix for a future perl deprecation
                     (perl will be removing "." from @INC in 5.24)

                     'perms' now requires a '-c' to activate batch mode
                     (should not affect interactive use but check your scripts
                     perhaps?)

                     gitolite setup now accepts a '-m' option to supply a
                     custom message (useful when it is used by a script)

 From Harry Waddell in PR 52293.


 To generate a diff of this commit:
 cvs rdiff -u -r1.24 -r1.25 pkgsrc/devel/gitolite/Makefile
 cvs rdiff -u -r1.13 -r1.14 pkgsrc/devel/gitolite/distinfo

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Roy Marples <roy@marples.name>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: lib/52293 Assertion failure in libterminfo _ti_encode_buf_16
Date: Sat, 20 Jun 2020 10:43:14 +0100

 I think this is the wrong fix.

 All callers of _ti_encode_buf_N pass int as the second arg, so surely the 
 correct fix it to accept int?
 The uintN_t casting is already done inside it.

 Does this fix it for you?

 Roy

 Index: term_private.h
 ===================================================================
 RCS file: /cvsroot/src/lib/libterminfo/term_private.h,v
 retrieving revision 1.18
 diff -u -p -r1.18 term_private.h
 --- term_private.h      29 Mar 2020 21:46:22 -0000      1.18
 +++ term_private.h      20 Jun 2020 09:42:48 -0000
 @@ -252,7 +252,7 @@ _ti_encode_count_str(char **cap, const c
   }

   static __inline void
 -_ti_encode_buf_16(TBUF *tbuf, size_t num)
 +_ti_encode_buf_16(TBUF *tbuf, int num)
   {
          _DIAGASSERT(num <= UINT16_MAX);
          le16enc(tbuf->buf + tbuf->bufpos, (uint16_t)num);
 @@ -260,7 +260,7 @@ _ti_encode_buf_16(TBUF *tbuf, size_t num
   }

   static __inline void
 -_ti_encode_buf_32(TBUF *tbuf, size_t num)
 +_ti_encode_buf_32(TBUF *tbuf, int num)
   {
          _DIAGASSERT(num <= UINT32_MAX);
          le32enc(tbuf->buf + tbuf->bufpos, (uint32_t)num);
 @@ -276,7 +276,7 @@ _ti_encode_buf_count_str(TBUF *tbuf, con
   }

   static __inline void
 -_ti_encode_buf_num(TBUF *tbuf, size_t num, int rtype)
 +_ti_encode_buf_num(TBUF *tbuf, int num, int rtype)
   {
          if (rtype == TERMINFO_RTYPE_O1) {
                  if (num > INT16_MAX)

From: "Roy Marples" <roy@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52293 CVS commit: src/lib/libterminfo
Date: Sun, 21 Jun 2020 15:05:23 +0000

 Module Name:	src
 Committed By:	roy
 Date:		Sun Jun 21 15:05:23 UTC 2020

 Modified Files:
 	src/lib/libterminfo: compile.c term_private.h

 Log Message:
 libterminfo: cast to uint16/32_t before conversion to preserve negativity

 Otherwise the ABSENT_NUMERIC(-1) or CANCELLED_NUMERIC(-2) will be converted
 incorrectly to size_t and then down to uint16/32_t.
 Picked up by DIAGNOSTIC builds.

 Thanks to Michael Forney for the fix for PR lib/52293.


 To generate a diff of this commit:
 cvs rdiff -u -r1.25 -r1.26 src/lib/libterminfo/compile.c
 cvs rdiff -u -r1.18 -r1.19 src/lib/libterminfo/term_private.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search