NetBSD Problem Report #52370

From www@NetBSD.org  Thu Jul  6 01:19:06 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.netbsd.org", Issuer "Postmaster NetBSD.org" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D17217A2AB
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  6 Jul 2017 01:19:05 +0000 (UTC)
Message-Id: <20170706011904.D207F7A2B3@mollari.NetBSD.org>
Date: Thu,  6 Jul 2017 01:19:04 +0000 (UTC)
From: edgar@pettijohn-web.com
Reply-To: edgar@pettijohn-web.com
To: gnats-bugs@NetBSD.org
Subject: typo in /etc/rc.d/network
X-Send-Pr-Version: www-1.0

>Number:         52370
>Category:       misc
>Synopsis:       typo in /etc/rc.d/network
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    misc-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 06 01:20:00 +0000 2017
>Closed-Date:    Wed Jul 12 08:16:14 +0000 2017
>Last-Modified:  Wed Jul 12 08:16:14 +0000 2017
>Originator:     Edgar Pettijohn
>Release:        7.1 Wed Jul  5 20:14:53 CDT 2017
>Organization:
>Environment:
7.1 NetBSD 7.1 (GENERIC.201703111743Z) amd64
>Description:
network_start_ipv6_autoconf() calls a nonexistent function checkyesnox(). This prints an error during startup.
>How-To-Repeat:
Reboot.
>Fix:
NetBSD$ cat /usr/src/etc/rc.d/network.patch                                    
Index: network
===================================================================
RCS file: /cvsroot/src/etc/rc.d/network,v
retrieving revision 1.71
diff -u -u -r1.71 network
--- network     6 Mar 2016 18:50:06 -0000       1.71
+++ network     6 Jul 2017 01:10:30 -0000
@@ -435,7 +435,7 @@
        # IPv6 interface autoconfiguration.

        # dhcpcd will ensure DAD completes before forking
-       if checkyesnox rtsol && ! checkyesno dhcpcd; then
+       if checkyesno rtsol && ! checkyesno dhcpcd; then
                if [ "$ip6mode" = "autohost" ]; then
                        echo
                        warn "rtsol has been removed, " \

>Release-Note:

>Audit-Trail:
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: releng@NetBSD.org
Subject: Re: misc/52370: typo in /etc/rc.d/network
Date: Thu, 6 Jul 2017 10:55:19 +0200

 This is fallout from a bogus pullup - the functions exists in -8 and
 -current rc.subr.

 Martin

From: "Robert Elz" <kre@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52370 CVS commit: src/etc/rc.d
Date: Thu, 6 Jul 2017 09:24:47 +0000

 Module Name:	src
 Committed By:	kre
 Date:		Thu Jul  6 09:24:47 UTC 2017

 Modified Files:
 	src/etc/rc.d: network

 Log Message:
 PR misc/52370

 Correct typo.

 XXX pullup 8, pullup 7


 To generate a diff of this commit:
 cvs rdiff -u -r1.71 -r1.72 src/etc/rc.d/network

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: kre@NetBSD.org
Subject: Re: PR/52370 CVS commit: src/etc/rc.d
Date: Thu, 6 Jul 2017 11:52:32 +0200

 On Thu, Jul 06, 2017 at 09:25:02AM +0000, Robert Elz wrote:
 >  Modified Files:
 >  	src/etc/rc.d: network
 >  
 >  Log Message:
 >  PR misc/52370
 >  
 >  Correct typo.
 >  
 >  XXX pullup 8, pullup 7

 I don't think this is correct, rc.subr provides that function in -current
 and -8.

 The error is the result of a broken pullup.

 Martin

From: Robert Elz <kre@munnari.OZ.AU>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: misc/52370: typo in /etc/rc.d/network
Date: Thu, 06 Jul 2017 17:03:36 +0700

     Date:        Thu,  6 Jul 2017 01:20:00 +0000 (UTC)
     From:        edgar@pettijohn-web.com
     Message-ID:  <20170706012000.9862C7A2AB@mollari.NetBSD.org>

   | network_start_ipv6_autoconf() calls a nonexistent function checkyesnox().

 It is not a non-existant finction (and the change I made which will be
 listed earlier in this PR has been reverted).

 checkyesnox is in rc.subr

 But only in netbsd 8, not in netbsd 7 - and the use of it in rc.d/network
 is also only in netbsd 8, not netbsd 7.

 Please check that you are not somehow mixing up parts of different
 distributions,   That does not work.


State-Changed-From-To: open->analyzed
State-Changed-By: kre@NetBSD.org
State-Changed-When: Thu, 06 Jul 2017 10:10:12 +0000
State-Changed-Why:
Not a bug, looks to be incorrect CVS usage.


From: Robert Elz <kre@munnari.OZ.AU>
To: Martin Husemann <martin@duskware.de>
Cc: gnats-bugs@NetBSD.org
Subject: Re: PR/52370 CVS commit: src/etc/rc.d
Date: Thu, 06 Jul 2017 17:46:09 +0700

     Date:        Thu, 6 Jul 2017 11:52:32 +0200
     From:        Martin Husemann <martin@duskware.de>
     Message-ID:  <20170706095232.GE178@mail.duskware.de>

   | I don't think this is correct, rc.subr provides that function in -current
   | and -8.

 Agreed, it is reverted.

   | The error is the result of a broken pullup.

 Not even that...

 kre

State-Changed-From-To: analyzed->closed
State-Changed-By: kre@NetBSD.org
State-Changed-When: Wed, 12 Jul 2017 08:16:14 +0000
State-Changed-Why:
Erroneous PR - not a bug


>Unformatted:

Home	PR Database Search