NetBSD Problem Report #52649
From www@NetBSD.org Tue Oct 24 10:39:34 2017
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 5CA4C7A1C4
for <gnats-bugs@gnats.NetBSD.org>; Tue, 24 Oct 2017 10:39:34 +0000 (UTC)
Message-Id: <20171024103933.3198F7A1E8@mollari.NetBSD.org>
Date: Tue, 24 Oct 2017 10:39:33 +0000 (UTC)
From: coypu@sdf.org
Reply-To: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Subject: fish shell doesn't work well with netbsd libraries and needs ncurses
X-Send-Pr-Version: www-1.0
>Number: 52649
>Category: pkg
>Synopsis: fish shell doesn't work well with netbsd libraries and needs ncurses
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Oct 24 10:40:00 +0000 2017
>Closed-Date: Wed Oct 25 12:47:18 +0000 2017
>Last-Modified: Wed Oct 25 12:47:18 +0000 2017
>Originator: coypu
>Release: NetBSD 8.99.4
>Organization:
>Environment:
NetBSD localhost 8.99.4 NetBSD 8.99.4 (GENERIC) #3: Sun Oct 22 03:14:21 IDT 2017 fly@localhost:/home/fly/obj/sys/arch/amd64/compile/GENERIC amd64
>Description:
Auto completion with fish and netbsd curses/terminfo doesn't work correctly, it's displayed broken.
Since fish always tries to display auto-completion, it always appears broken.
It looks like it's failing to set the cursor to the beginning of the prompt (?)
There are some patches which may affect it in pkgsrc/shells/fish/patches/, I didn't write them.
>How-To-Repeat:
to build fish with netbsd curses (I forced it to use ncurses so the package works), apply the following patch:
===================================================================
RCS file: /cvsroot/pkgsrc/shells/fish/Makefile,v
retrieving revision 1.12
diff -u -r1.12 Makefile
--- Makefile 24 Oct 2017 03:51:41 -0000 1.12
+++ Makefile 24 Oct 2017 10:32:58 -0000
@@ -14,7 +14,6 @@
USE_LANGUAGES+= c c++
GNU_CONFIGURE= yes
-USE_NCURSES= yes
CONFIGURE_ARGS+= --sysconfdir=${PKG_SYSCONFDIR}
CONFIGURE_ARGS+= --without-xsel
USE_TOOLS+= gmake autoreconf autoconf automake
@@ -51,5 +50,5 @@
.include "../../devel/gettext-tools/buildlink3.mk"
.include "../../lang/python/application.mk"
# Broken auto completion with netbsd curses
-.include "../../devel/ncurses/buildlink3.mk"
+.include "../../mk/curses.buildlink3.mk"
.include "../../mk/bsd.pkg.mk"
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: lib-bug-people->pkg-manager
Responsible-Changed-By: uwe@NetBSD.org
Responsible-Changed-When: Wed, 25 Oct 2017 03:45:36 +0000
Responsible-Changed-Why:
Category change
From: Valery Ushakov <uwe@stderr.spb.ru>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/52649: fish shell doesn't work well with netbsd libraries
and needs ncurses
Date: Wed, 25 Oct 2017 06:47:01 +0300
It's a package bug. Their fallback code for variadic tparm() is
broken.
-uwe
From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/52649 CVS commit: pkgsrc/shells/fish
Date: Wed, 25 Oct 2017 09:32:38 +0000
Module Name: pkgsrc
Committed By: maya
Date: Wed Oct 25 09:32:38 UTC 2017
Modified Files:
pkgsrc/shells/fish: Makefile distinfo
pkgsrc/shells/fish/patches: patch-configure.ac patch-src_fallback.h
Log Message:
fish: use variadic tparm on netbsd curses.
don't mess with the declaration of tparm_solaris_kludge unnecessarily.
uwe thinks the non-variadic tparm is wrong (so might be broken for
solaris curses), but I'm not sure how to correct it.
PR pkg/52649
bump PKGREVISION
To generate a diff of this commit:
cvs rdiff -u -r1.12 -r1.13 pkgsrc/shells/fish/Makefile
cvs rdiff -u -r1.9 -r1.10 pkgsrc/shells/fish/distinfo
cvs rdiff -u -r1.1 -r1.2 pkgsrc/shells/fish/patches/patch-configure.ac \
pkgsrc/shells/fish/patches/patch-src_fallback.h
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Wed, 25 Oct 2017 12:47:18 +0000
State-Changed-Why:
Fixed by uwe, thanks!
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.