NetBSD Problem Report #52884

From www@NetBSD.org  Mon Jan  1 03:06:59 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D1FC27A18F
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  1 Jan 2018 03:06:59 +0000 (UTC)
Message-Id: <20180101030658.E3D3C7A218@mollari.NetBSD.org>
Date: Mon,  1 Jan 2018 03:06:58 +0000 (UTC)
From: yamajun@ofug.net
Reply-To: yamajun@ofug.net
To: gnats-bugs@NetBSD.org
Subject: pkgsrc/net/mikutter-3.6.0: Required lang/ruby23-base(Cannot work with ruby22-base)
X-Send-Pr-Version: www-1.0

>Number:         52884
>Category:       pkg
>Synopsis:       pkgsrc/net/mikutter-3.6.0: Required lang/ruby23-base(Cannot work with ruby22-base)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    tsutsui
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 01 03:10:00 +0000 2018
>Closed-Date:    Tue Jan 02 02:48:03 +0000 2018
>Last-Modified:  Tue Jan 02 02:48:03 +0000 2018
>Originator:     YAMASHIRO, Jun
>Release:        NetBSD-current
>Organization:
Okinawa FreeBSD Users Group
>Environment:
NetBSD yamajun 8.99.9 NetBSD 8.99.9 (GENERIC) #16: Mon Dec 11 20:19:06 JST 2017  yamajun@yamajun:/usr/obj/sys/arch/amd64/compile/GENERIC amd64
>Description:
mikutter-3.6.0 depend on ruby>=2.3 (it using Module#deprecate_constant).
But net/mikutter allowed run with lang/ruby22-base.  Mikutter will fail
at run.

mikutter/README (translated from Japanese)
** Required application:
- ruby (2.1 - 2.3)

ruby-2.3.6/NEWS
== Changes since the 2.2.0 release
(snip)
=== Core classes updates (outstanding ones only)
(snip)
* Module
  * Module#deprecate_constant [Feature #11398]
>How-To-Repeat:
(install with ruby22-base)
# echo 'RUBY_VERSION_DEFAULT=22' >> /etc/mk.conf
# cd /usr/pkgsrc/net/mikutter
# make install clean-depends clean

(after)
$ mikutter
/usr/pkg/share/mikutter/core/lib/diva_hacks/model.rb:146:in `<module:Diva>': undefined method `deprecate_constant' for Diva:Module (NoMethodError)
        from /usr/pkg/share/mikutter/core/lib/diva_hacks/model.rb:138:in `<top (required)>'
        from /usr/pkg/share/mikutter/core/lib/diva_hacks.rb:59:in `require_relative'
        from /usr/pkg/share/mikutter/core/lib/diva_hacks.rb:59:in `<top (required)>'
        from /usr/pkg/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
        from /usr/pkg/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
        from /usr/pkg/share/mikutter/core/miquire.rb:98:in `miquire_original_require'
        from /usr/pkg/share/mikutter/core/miquire.rb:71:in `block (2 levels) in miquire'
        from /usr/pkg/share/mikutter/core/miquire.rb:70:in `chdir'
        from /usr/pkg/share/mikutter/core/miquire.rb:70:in `block in miquire'
        from /usr/pkg/share/mikutter/core/miquire.rb:66:in `each'
        from /usr/pkg/share/mikutter/core/miquire.rb:66:in `miquire'
        from /usr/pkg/share/mikutter/core/miquire.rb:18:in `miquire'
        from /usr/pkg/share/mikutter/mikutter.rb:39:in `<main>'


>Fix:
Apply this patch and rebuild.
(Note: mikutter supported 2.3.  I checked good working with ruby24-base)

# patch -p0 < /path/to/this.patch
# make install


Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/net/mikutter/Makefile,v
retrieving revision 1.150
diff -u -r1.150 Makefile
--- Makefile	30 Dec 2017 05:05:14 -0000	1.150
+++ Makefile	1 Jan 2018 02:55:21 -0000
@@ -2,6 +2,7 @@
 #

 DISTNAME=	mikutter.3.6.0
+PKGREVISION=	1
 PKGNAME=	${RUBY_PKGPREFIX}-${DISTNAME:S/./-/}
 CATEGORIES=	net
 MASTER_SITES=	http://mikutter.hachune.net/bin/
@@ -11,6 +12,8 @@
 COMMENT=	Simple, powerful, and moeful twitter client
 LICENSE=	mit AND cc-by-sa-v3.0

+RUBY_VERSIONS_ACCEPTED=	23 24
+
 .include "../../lang/ruby/rubyversion.mk"

 DEPENDS+=	${RUBY_PKGPREFIX}-pluggaloid>=1.1.1:../../net/ruby-pluggaloid


>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->tsutsui
Responsible-Changed-By: tsutsui@NetBSD.org
Responsible-Changed-When: Tue, 02 Jan 2018 02:23:14 +0000
Responsible-Changed-Why:
It's noted in upstream 3.6.0 changelog, but I forgot to put it Makefile.


From: "Izumi Tsutsui" <tsutsui@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52884 CVS commit: pkgsrc/net/mikutter
Date: Tue, 2 Jan 2018 02:43:59 +0000

 Module Name:	pkgsrc
 Committed By:	tsutsui
 Date:		Tue Jan  2 02:43:59 UTC 2018

 Modified Files:
 	pkgsrc/net/mikutter: Makefile

 Log Message:
 mikutter: 3.6.0 no longer supports Ruby 2.2. PR pkg/52884

 Bump PKGREVISION.


 To generate a diff of this commit:
 cvs rdiff -u -r1.150 -r1.151 pkgsrc/net/mikutter/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Tue, 02 Jan 2018 02:48:03 +0000
State-Changed-Why:
Patch applied. Thanks.


>Unformatted:

Home	PR Database Search