NetBSD Problem Report #52925

From www@NetBSD.org  Sat Jan 13 20:47:14 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 2BB057A172
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 13 Jan 2018 20:47:14 +0000 (UTC)
Message-Id: <20180113204713.316D87A1F8@mollari.NetBSD.org>
Date: Sat, 13 Jan 2018 20:47:13 +0000 (UTC)
From: lists@eitanadler.com
Reply-To: lists@eitanadler.com
To: gnats-bugs@NetBSD.org
Subject: [timed] mark slave function as noreturn
X-Send-Pr-Version: www-1.0

>Number:         52925
>Category:       bin
>Synopsis:       [timed] mark slave function as noreturn
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 13 20:50:00 +0000 2018
>Closed-Date:    Tue Jan 16 07:58:27 +0000 2018
>Last-Modified:  Tue Jan 16 08:00:00 +0000 2018
>Originator:     Eitan Adler
>Release:        HEAD
>Organization:
>Environment:
>Description:

>How-To-Repeat:

>Fix:
Index: slave.c
===================================================================
RCS file: /cvsroot/src/usr.sbin/timed/timed/slave.c,v
retrieving revision 1.18
diff -u -r1.18 slave.c
--- slave.c	26 Jan 2007 16:12:41 -0000	1.18
+++ slave.c	13 Jan 2018 20:46:07 -0000
@@ -56,7 +56,7 @@
 static void setmaster(struct tsp *);
 static void answerdelay(void);

-int
+void
 slave(void)
 {
 	int tries;
Index: timed-extern.h
===================================================================
RCS file: /cvsroot/src/usr.sbin/timed/timed/timed-extern.h,v
retrieving revision 1.10
diff -u -r1.10 timed-extern.h
--- timed-extern.h	31 Aug 2011 13:32:41 -0000	1.10
+++ timed-extern.h	13 Jan 2018 20:46:07 -0000
@@ -74,7 +74,7 @@
 void	 prthp(clock_t);
 void	 rmnetmachs(struct netinfo *);
 void	 setstatus(void);
-int	 slave(void);
+void	 slave(void) __attribute__((__noreturn__));
 void	 slaveack(void);
 void	 spreadtime(void);
 void	 suppress(struct sockaddr_in *, char *, struct netinfo *);

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Tue, 16 Jan 2018 07:58:27 +0000
State-Changed-Why:
Applied, thanks!


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/52925 CVS commit: src/usr.sbin/timed/timed
Date: Tue, 16 Jan 2018 07:57:58 +0000

 Module Name:	src
 Committed By:	maya
 Date:		Tue Jan 16 07:57:58 UTC 2018

 Modified Files:
 	src/usr.sbin/timed/timed: slave.c timed-extern.h

 Log Message:
 Returns void, mark noreturn.

 From Eitan Adler in PR bin/52925


 To generate a diff of this commit:
 cvs rdiff -u -r1.18 -r1.19 src/usr.sbin/timed/timed/slave.c
 cvs rdiff -u -r1.10 -r1.11 src/usr.sbin/timed/timed/timed-extern.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search