NetBSD Problem Report #53111

From martin@duskware.de  Tue Mar 20 07:24:15 2018
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 1DA077A1B0
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 20 Mar 2018 07:24:15 +0000 (UTC)
Message-Id: <20180320072404.815C35CC770@emmas.aprisoft.de>
Date: Tue, 20 Mar 2018 08:24:04 +0100 (CET)
From: martin@NetBSD.org
Reply-To: martin@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: multimedia/ffmpeg1 does not compile with x264-devel-20180224
X-Send-Pr-Version: 3.95

>Number:         53111
>Category:       pkg
>Synopsis:       multimedia/ffmpeg1 does not compile with x264-devel-20180224
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 20 07:25:00 +0000 2018
>Last-Modified:  Tue Mar 20 07:40:00 +0000 2018
>Originator:     Martin Husemann
>Release:        NetBSD 8.99.14
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD night-owl.duskware.de 8.99.14 NetBSD 8.99.14 (NIGHT-OWL) #588: Sat Mar 17 11:13:41 CET 2018 martin@night-owl.duskware.de:/usr/src/sys/arch/amd64/compile/NIGHT-OWL amd64
Architecture: x86_64
Machine: amd64
>Description:

Trying to build multimedia/ffmpeg1 fails with:

libavcodec/libx264.c: In function 'X264_init_static':
libavcodec/libx264.c:612:9: error: 'x264_bit_depth' undeclared (first use in this function)
     if (x264_bit_depth == 8)
         ^~~~~~~~~~~~~~

>How-To-Repeat:
s/a

>Fix:
n/a

>Audit-Trail:
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/53111: multimedia/ffmpeg1 does not compile with
 x264-devel-20180224
Date: Tue, 20 Mar 2018 08:38:57 +0100

 Here is a simple patch that makes it compile for me, but I did not check
 version dependencies/history, and this looks wrong (going back to config
 time instead of runtime decision).

 Martin


 --- libavcodec/libx264.c.orig	2015-02-12 15:38:18.000000000 +0100
 +++ libavcodec/libx264.c	2018-03-20 08:26:56.207459765 +0100
 @@ -159,7 +159,7 @@ static int X264_frame(AVCodecContext *ct

      x264_picture_init( &x4->pic );
      x4->pic.img.i_csp   = x4->params.i_csp;
 -    if (x264_bit_depth > 8)
 +    if (X264_BIT_DEPTH > 8)
          x4->pic.img.i_csp |= X264_CSP_HIGH_DEPTH;
      x4->pic.img.i_plane = avfmt2_num_planes(ctx->pix_fmt);

 @@ -609,11 +609,11 @@ static const enum AVPixelFormat pix_fmts

  static av_cold void X264_init_static(AVCodec *codec)
  {
 -    if (x264_bit_depth == 8)
 +    if (X264_BIT_DEPTH == 8)
          codec->pix_fmts = pix_fmts_8bit;
 -    else if (x264_bit_depth == 9)
 +    else if (X264_BIT_DEPTH == 9)
          codec->pix_fmts = pix_fmts_9bit;
 -    else if (x264_bit_depth == 10)
 +    else if (X264_BIT_DEPTH == 10)
          codec->pix_fmts = pix_fmts_10bit;
  }

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.