NetBSD Problem Report #53153

From www@NetBSD.org  Tue Apr  3 23:32:18 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id E0FA17A169
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  3 Apr 2018 23:32:17 +0000 (UTC)
Message-Id: <20180403233216.C12257A1CC@mollari.NetBSD.org>
Date: Tue,  3 Apr 2018 23:32:16 +0000 (UTC)
From: tuxillo@quantumachine.net
Reply-To: tuxillo@quantumachine.net
To: gnats-bugs@NetBSD.org
Subject: Fix rump build in DragonFlyBSD
X-Send-Pr-Version: www-1.0

>Number:         53153
>Category:       misc
>Synopsis:       Fix rump build in DragonFlyBSD
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    martin
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 03 23:35:00 +0000 2018
>Closed-Date:    Thu Apr 05 11:07:03 +0000 2018
>Last-Modified:  Thu Apr 05 11:07:03 +0000 2018
>Originator:     Antonio Huete Jimenez
>Release:        latest source
>Organization:
DragonFlyBSD
>Environment:
>Description:
DragonFly defaults to -Werror so a missing include causes rump to fail to build (via buildrump)

The patch below allows the build to finish. It should be no problem to include unistd.h unconditionally but if needed I can change it to be included only in the dragonfly case.
>How-To-Repeat:

>Fix:
diff --git a/sys/rump/net/lib/libshmif/shmif_user.c b/sys/rump/net/lib/libshmif/shmif_user.c
index 70c64ab6..05c8e5f1 100644
--- a/sys/rump/net/lib/libshmif/shmif_user.c
+++ b/sys/rump/net/lib/libshmif/shmif_user.c
@@ -47,6 +47,7 @@
 #include <sys/event.h>

 #include <stdlib.h>
+#include <unistd.h>

 int
 rumpcomp_shmif_watchsetup(int *kqp, int fd)

>Release-Note:

>Audit-Trail:
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: misc-bug-people@netbsd.org, gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org
Subject: Re: misc/53153: Fix rump build in DragonFlyBSD
Date: Wed, 4 Apr 2018 09:28:37 +0200

 On Tue, Apr 03, 2018 at 11:35:00PM +0000, tuxillo@quantumachine.net wrote:
 > DragonFly defaults to -Werror so a missing include causes rump to
 > fail to build (via buildrump)

 Can you please provide the full error message?

 Thanks,

 Martin

From: Antonio Huete =?utf-8?b?Smltw6luZXo=?= <tuxillo@quantumachine.net>
To: gnats-bugs@netbsd.org
Cc: misc-bug-people@netbsd.org, gnats-admin@netbsd.org,
 netbsd-bugs@netbsd.org
Subject: Re: misc/53153: Fix rump build in DragonFlyBSD
Date: Wed, 04 Apr 2018 08:39:33 +0000

 #   compile  libshmif/shmif_user.pico
 /build/tuxillo/s/buildrump.sh/obj/tooldir/bin/x86_64--netbsd-gcc -o  
 shmif_user.pico -fPIC -DPIC -O2 -g -Wno-format-zero-length  
 -Wno-pointer-sign   -Werror -Wall -Wextra -Wno-unused-parameter  
 -Wstrict-prototypes -Wmissing-prototypes  
 -I/build/tuxillo/s/buildrump.sh/obj/dest.stage/usr/include     -c  
 /build/tuxillo/s/buildrump.sh/src/sys/rump/net/lib/libshmif/shmif_user.c
 --- dependall-/build/tuxillo/s/buildrump.sh/src/sys/rump/dev ---
 --- dependall ---
 --- dependall-/build/tuxillo/s/buildrump.sh/src/sys/rump/net ---
 /build/tuxillo/s/buildrump.sh/src/sys/rump/net/lib/libshmif/shmif_user.c: In  
 function 'rumpcomp_shmif_mmap':
 /build/tuxillo/s/buildrump.sh/src/sys/rump/net/lib/libshmif/shmif_user.c:210:6: error: implicit declaration of function 'ftruncate'  
 [-Werror=implicit-function-declaration]
    if (ftruncate(fd, len) == -1) {
        ^
 cc1: all warnings being treated as errors
 --- dependall-libnpf ---
 --- npf_worker.o ---
 --- dependall-libshmif ---
 *** [shmif_user.pico] Error code 1

 nbmake[4]: stopped in  
 /build/tuxillo/s/buildrump.sh/src/sys/rump/net/lib/libshmif
 1 error

 nbmake[4]: stopped in  
 /build/tuxillo/s/buildrump.sh/src/sys/rump/net/lib/libshmif
 *** [dependall] Error code 2

 nbmake[3]: stopped in  
 /build/tuxillo/s/buildrump.sh/src/sys/rump/net/lib/libshmif
 1 error

 nbmake[3]: stopped in  
 /build/tuxillo/s/buildrump.sh/src/sys/rump/net/lib/libshmif
 *** [dependall-libshmif] Error code 2

 nbmake[2]: stopped in /build/tuxillo/s/buildrump.sh/src/sys/rump/net/lib


 Martin Husemann <martin@duskware.de> escribió:

 > The following reply was made to PR misc/53153; it has been noted by GNATS.
 >
 > From: Martin Husemann <martin@duskware.de>
 > To: gnats-bugs@NetBSD.org
 > Cc: misc-bug-people@netbsd.org, gnats-admin@netbsd.org,
 > 	netbsd-bugs@netbsd.org
 > Subject: Re: misc/53153: Fix rump build in DragonFlyBSD
 > Date: Wed, 4 Apr 2018 09:28:37 +0200
 >
 >  On Tue, Apr 03, 2018 at 11:35:00PM +0000, tuxillo@quantumachine.net wrote:
 >  > DragonFly defaults to -Werror so a missing include causes rump to
 >  > fail to build (via buildrump)
 >
 >  Can you please provide the full error message?
 >
 >  Thanks,
 >
 >  Martin



From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53153 CVS commit: src/sys/rump/net/lib/libshmif
Date: Wed, 4 Apr 2018 09:19:33 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Wed Apr  4 09:19:33 UTC 2018

 Modified Files:
 	src/sys/rump/net/lib/libshmif: shmif_user.c

 Log Message:
 Unconditionally include <unistd.h>, as we use ftruncate() unconditionally
 too.
 Reported (with patch) by Antonio Huete Jimenez in PR 53153, slightly
 modified by me.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/sys/rump/net/lib/libshmif/shmif_user.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: misc-bug-people->martin
Responsible-Changed-By: martin@NetBSD.org
Responsible-Changed-When: Wed, 04 Apr 2018 09:21:02 +0000
Responsible-Changed-Why:
I think I fixed it


State-Changed-From-To: open->feedback
State-Changed-By: martin@NetBSD.org
State-Changed-When: Wed, 04 Apr 2018 09:21:02 +0000
State-Changed-Why:
Does this work for you?


From: Martin Husemann <martin@duskware.de>
To: Antonio Huete =?iso-8859-1?Q?Jim=E9nez?= <tuxillo@quantumachine.net>
Cc: gnats-bugs@netbsd.org
Subject: Re: misc/53153: Fix rump build in DragonFlyBSD
Date: Wed, 4 Apr 2018 11:20:06 +0200

 Thanks, I commited a similar fix - hope this works for you.

 Martin

From: Antonio Huete =?utf-8?b?Smltw6luZXo=?= <tuxillo@quantumachine.net>
To: gnats-bugs@netbsd.org
Cc: martin@netbsd.org, misc-bug-people@netbsd.org, netbsd-bugs@netbsd.org,
 gnats-admin@netbsd.org
Subject: Re: misc/53153 (Fix rump build in DragonFlyBSD)
Date: Thu, 05 Apr 2018 11:04:41 +0000

 I checked out the latest netbsd-src from github (which includes your  
 change)...

 $ git log --oneline | grep ftruncate | head -1
 862940885b9b Unconditionally include <unistd.h>, as we use ftruncate()  
 unconditionally too. Reported (with patch) by Antonio Huete Jimenez in  
 PR 53153, slightly modified by me.

 ... and used buildrump.sh (https://github.com/rumpkernel/buildrump.sh):

 $ ./buildrump.sh -s /build/tuxillo/s/buildrump.sh/src fullbuild

 [...]

 --- dependall ---
 --- dependall-/build/tuxillo/s/buildrump.sh/src/usr.bin/rump_allserver ---
 --- dependall ---
 --- dependall-/build/tuxillo/s/buildrump.sh/src/usr.bin/rump_server ---
 --- dependall ---
 --- dependall ---
 --- install-/build/tuxillo/s/buildrump.sh/src/usr.bin/rump_server ---
 --- install-/build/tuxillo/s/buildrump.sh/src/usr.bin/rump_allserver ---
 --- install-/build/tuxillo/s/buildrump.sh/src/usr.bin/rump_wmd ---
 --- install-/build/tuxillo/s/buildrump.sh/src/usr.bin/rump_server ---
 install ===> /build/tuxillo/s/buildrump.sh/src/usr.bin/rump_server
 --- install-/build/tuxillo/s/buildrump.sh/src/usr.bin/rump_allserver ---
 install ===> /build/tuxillo/s/buildrump.sh/src/usr.bin/rump_allserver
 --- install-/build/tuxillo/s/buildrump.sh/src/usr.bin/rump_wmd ---
 install ===> /build/tuxillo/s/buildrump.sh/src/usr.bin/rump_wmd
 >> buildrump.sh ran successfully

 It seems to build just fine, thanks!

 martin@netbsd.org escribió:

 > Synopsis: Fix rump build in DragonFlyBSD
 >
 > Responsible-Changed-From-To: misc-bug-people->martin
 > Responsible-Changed-By: martin@NetBSD.org
 > Responsible-Changed-When: Wed, 04 Apr 2018 09:21:02 +0000
 > Responsible-Changed-Why:
 > I think I fixed it
 >
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: martin@NetBSD.org
 > State-Changed-When: Wed, 04 Apr 2018 09:21:02 +0000
 > State-Changed-Why:
 > Does this work for you?



State-Changed-From-To: feedback->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Thu, 05 Apr 2018 11:07:03 +0000
State-Changed-Why:
Confirmed fixed, thanks for the report!


>Unformatted:

Home	PR Database Search