NetBSD Problem Report #53271

From www@NetBSD.org  Tue May  8 10:33:44 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D9E997A14F
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  8 May 2018 10:33:43 +0000 (UTC)
Message-Id: <20180508103343.2411D7A26F@mollari.NetBSD.org>
Date: Tue,  8 May 2018 10:33:43 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Misplaced parenthese in hme.c
X-Send-Pr-Version: www-1.0

>Number:         53271
>Category:       kern
>Synopsis:       Misplaced parenthese in hme.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pgoyette
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue May 08 10:35:00 +0000 2018
>Closed-Date:    Mon May 14 22:39:05 +0000 2018
>Last-Modified:  Mon May 14 22:39:05 +0000 2018
>Originator:     Henning Petersen
>Release:        netbsd-current
>Organization:
>Environment:
>Description:
Misplaced paranthes in hme.c found by cppcheck.
>How-To-Repeat:

>Fix:
diff -u -u -p -r1.96 hme.c
--- sys/dev/ic/hme.c	23 May 2017 02:19:14 -0000	1.96
+++ sys/dev/ic/hme.c	8 May 2018 10:22:16 -0000
@@ -753,7 +753,7 @@ hme_get(struct hme_softc *sc, int ri, ui
 			pktlen = m0->m_pkthdr.len - ETHER_HDR_LEN;
 		} else if (ntohs(eh->ether_type) == ETHERTYPE_VLAN) {
 			evh = (struct ether_vlan_header *)eh;
-			if (ntohs(evh->evl_proto != ETHERTYPE_IP))
+			if (ntohs(evh->evl_proto) != ETHERTYPE_IP)
 				goto swcsum;
 			ip = (struct ip *)((char *)eh + ETHER_HDR_LEN +
 			    ETHER_VLAN_ENCAP_LEN);

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->pgoyette
Responsible-Changed-By: pgoyette@NetBSD.org
Responsible-Changed-When: Tue, 08 May 2018 10:43:00 +0000
Responsible-Changed-Why:
I'll handle


State-Changed-From-To: open->closed
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Tue, 08 May 2018 10:43:00 +0000
State-Changed-Why:
Fix committed - thanks!


State-Changed-From-To: closed->needs-pullups
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Tue, 08 May 2018 10:44:18 +0000
State-Changed-Why:
Need pullup for netbsd-8


State-Changed-From-To: needs-pullups->pending-pullups
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Tue, 08 May 2018 10:46:09 +0000
State-Changed-Why:
p[ull-up request #8-815


State-Changed-From-To: pending-pullups->closed
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Wed, 09 May 2018 21:40:47 +0000
State-Changed-Why:
Pullups completed.


From: henning petersen <henning.petersen@t-online.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: kern/53271 (Misplaced parenthese in hme.c)
Date: Fri, 11 May 2018 06:23:40 +0200

 Pullups to netbsd-6 and netbsd-7 is also needed.


 Am 09.05.2018 um 23:40 schrieb pgoyette@NetBSD.org:
 > Synopsis: Misplaced parenthese in hme.c
 >
 > State-Changed-From-To: pending-pullups->closed
 > State-Changed-By: pgoyette@NetBSD.org
 > State-Changed-When: Wed, 09 May 2018 21:40:47 +0000
 > State-Changed-Why:
 > Pullups completed.
 >
 >
 >
 >

State-Changed-From-To: closed->pending-pullups
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Fri, 11 May 2018 11:55:16 +0000
State-Changed-Why:
Pullups 6-1548 and 7-1604 queued, as requested by submitter


From: Paul Goyette <paul@whooppee.com>
To: gnats-bugs@NetBSD.org
Cc: henning.petersen@t-online.de
Subject: Re: kern/53271 (Misplaced parenthese in hme.c)
Date: Fri, 11 May 2018 19:56:10 +0800 (+08)

 > From: henning petersen <henning.petersen@t-online.de>
 > To: gnats-bugs@NetBSD.org
 > Cc:
 > Subject: Re: kern/53271 (Misplaced parenthese in hme.c)
 > Date: Fri, 11 May 2018 06:23:40 +0200
 >
 > Pullups to netbsd-6 and netbsd-7 is also needed.

 Tickets 6-1548 and 7-1604 requested



 +------------------+--------------------------+----------------------------+
 | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
 | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
 | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
 +------------------+--------------------------+----------------------------+

State-Changed-From-To: pending-pullups->closed
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Mon, 14 May 2018 22:39:05 +0000
State-Changed-Why:
Pullups to netbsd-6 and netbsd-7 completed.  (pullup to netbsd-8 was
previously done.


>Unformatted:

Home	PR Database Search