NetBSD Problem Report #53323

From www@NetBSD.org  Mon May 28 03:34:17 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 72A077A110
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 28 May 2018 03:34:17 +0000 (UTC)
Message-Id: <20180528033416.77E767A1DA@mollari.NetBSD.org>
Date: Mon, 28 May 2018 03:34:16 +0000 (UTC)
From: coypu@sdf.org
Reply-To: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Subject: vi aborts when editing attached file containing emoji
X-Send-Pr-Version: www-1.0

>Number:         53323
>Category:       bin
>Synopsis:       vi aborts when editing attached file containing emoji
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    rin
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 28 03:35:00 +0000 2018
>Closed-Date:    Sun Jun 03 08:14:36 +0000 2018
>Last-Modified:  Sun Jun 03 08:14:36 +0000 2018
>Originator:     coypu
>Release:        NetBSD 8.99.17
>Organization:
>Environment:
NetBSD planets 8.99.17 NetBSD 8.99.17 (GENERIC) #4: Sat May 19 12:16:35 IDT 2018  fly@planets:/home/fly/obj/sys/arch/amd64/compile/GENERIC amd64

>Description:

>How-To-Repeat:
fly@planets ~> locale
LANG=""
LC_CTYPE="en_US.UTF-8"
LC_COLLATE="C"
LC_TIME="en_US.UTF-8"
LC_NUMERIC="en_US.UTF-8"
LC_MONETARY="en_US.UTF-8"
LC_MESSAGES="en_US.UTF-8"
LC_ALL="en_US.UTF-8"

Fetch this file: http://coypu.sdf.org/nvi-crasher
vi nvi-crasher
Press right arrow.
>Fix:

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Mon, 28 May 2018 04:26:39 +0000
State-Changed-Why:
duplicate bin/53164


Responsible-Changed-From-To: bin-bug-people->rin
Responsible-Changed-By: rin@NetBSD.org
Responsible-Changed-When: Sun, 03 Jun 2018 07:48:51 +0000
Responsible-Changed-Why:
Take


State-Changed-From-To: closed->open
State-Changed-By: rin@NetBSD.org
State-Changed-When: Sun, 03 Jun 2018 07:48:51 +0000
State-Changed-Why:
This is partially due to bin/53164, but fundamentally because emoji chars
do not have their entries in LC_CTYPE locale file for UTF-8.


From: "Rin Okuyama" <rin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53323 CVS commit: src/share/locale/ctype
Date: Sun, 3 Jun 2018 07:54:51 +0000

 Module Name:	src
 Committed By:	rin
 Date:		Sun Jun  3 07:54:51 UTC 2018

 Modified Files:
 	src/share/locale/ctype: en_US.UTF-8.src

 Log Message:
 Add characters in "Emoji & Pictographs" from Unicode 10.0.0:
   http://www.unicode.org/charts/

 They are classified as PUNCT, which is historically used for characters other
 than blank, alphabetic, or digit ones.

 Glyph widths are taken from "East Asian Width":
   https://www.unicode.org/Public/10.0.0/ucd/EastAsianWidth.txt
 Characters of "F" or "W" are classified to SWIDTH2, and others are classified
 to SWIDTH1, as implicitly done in the previous revisions.

 Should address problems like PR bin/53323.

 Discussed with soda@. We thank Takuya SHIOZAKI (tshiozak@) for useful comments.


 To generate a diff of this commit:
 cvs rdiff -u -r1.5 -r1.6 src/share/locale/ctype/en_US.UTF-8.src

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Rin Okuyama" <rin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53323 CVS commit: src/external/bsd/nvi/dist
Date: Sun, 3 Jun 2018 08:08:37 +0000

 Module Name:	src
 Committed By:	rin
 Date:		Sun Jun  3 08:08:37 UTC 2018

 Modified Files:
 	src/external/bsd/nvi/dist/common: conv.h
 	src/external/bsd/nvi/dist/vi: vs_line.c vs_relative.c

 Log Message:
 Make sure that every wide char occupies at least one display width:
   - Replace non-printable multibyte char with ?-symbol.
   - Put space before non-spacing char.

 Fix problems reported in PR bin/53164 and
 PR bin/53323, that are because we did not take into account non-printable
 multibyte char of wctob(wc) == EOF && wcwidth(wc) == -1.


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 src/external/bsd/nvi/dist/common/conv.h
 cvs rdiff -u -r1.4 -r1.5 src/external/bsd/nvi/dist/vi/vs_line.c \
     src/external/bsd/nvi/dist/vi/vs_relative.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: rin@NetBSD.org
State-Changed-When: Sun, 03 Jun 2018 08:14:36 +0000
State-Changed-Why:
Now nvi can handle emoji chars.


>Unformatted:

Home	PR Database Search