NetBSD Problem Report #53405

From www@NetBSD.org  Wed Jun 27 11:42:21 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id CB47D7A103
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 27 Jun 2018 11:42:21 +0000 (UTC)
Message-Id: <20180627114220.7B98C7A1F5@mollari.NetBSD.org>
Date: Wed, 27 Jun 2018 11:42:20 +0000 (UTC)
From: coypu@sdf.org
Reply-To: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Subject: base iasl can't build xen (no problem with unmodified iasl)
X-Send-Pr-Version: www-1.0

>Number:         53405
>Category:       bin
>Synopsis:       base iasl can't build xen (no problem with unmodified iasl)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jun 27 11:45:00 +0000 2018
>Closed-Date:    Thu Jun 28 08:03:37 +0000 2018
>Last-Modified:  Thu Jun 28 08:03:37 +0000 2018
>Originator:     coypu
>Release:        8.99.19
>Organization:
>Environment:
NetBSD planets 8.99.19 NetBSD 8.99.19 (GENERIC) #0: Sat Jun 23 06:52:51 IDT 2018  fly@planets:/tmp/build/sys/arch/amd64/compile/GENERIC amd64

> iasl -v

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20180427
Copyright (c) 2000 - 2018 Intel Corporation

>Description:
curl -o ssdt_pm.asl "https://xenbits.xen.org/gitweb/?p=xen.git;a=blob_plain;f=tools/libacpi/ssdt_pm.asl;h=d81b1f2a36359f2de7ee1ad8f5548b3312e7461c;hb=HEAD"

> /usr/bin/iasl -vs -p out -tc ssdt_pm.asl
Compiler aborting due to parser-detected syntax error(s)
ssdt_pm.asl    339:             Name (_HID, EisaId ("PNP0C0A"))
Error    6126 -                    syntax error ^ 

ssdt_pm.asl    384:             Name (_HID, EisaId ("PNP0C0A"))
Error    6126 -                    syntax error ^ 

ASL Input:     ssdt_pm.asl - 419 lines, 12575 bytes, 192 keywords
Hex Dump:      out.hex - 233 bytes

Compilation complete. 2 Errors, 0 Warnings, 0 Remarks, 0 Optimizations




if I update pkgsrc acpica-utils to the latest and try it instead,

> /usr/pkg/bin/iasl -vs -p out -tc ssdt_pm.asl
ssdt_pm.asl    397:                 Store (\_SB.PB2, Local0)
Warning  3144 -       Method Local is set but never used ^  (Local0)

ASL Input:     ssdt_pm.asl - 420 lines, 12575 bytes, 192 keywords
AML Output:    out.aml - 1447 bytes, 61 named objects, 131 executable opcodes
Hex Dump:      out.hex - 13963 bytes

Compilation complete. 0 Errors, 1 Warnings, 0 Remarks, 31 Optimizations

> /usr/pkg/bin/iasl -v

Intel ACPI Component Architecture
ASL+ Optimizing Compiler/Disassembler version 20180531
Copyright (c) 2000 - 2018 Intel Corporation


>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/53405: base iasl can't build xen (no problem with unmodified
 iasl)
Date: Wed, 27 Jun 2018 11:54:39 +0000

 It's a local change that has been present for a while
 pkgsrc acpica-utils of the same version also works.

 p.s. acpica has a testsuite

From: coypu@sdf.org
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/53405: base iasl can't build xen (no problem with unmodified
 iasl)
Date: Wed, 27 Jun 2018 14:45:22 +0000

 I tried to find the diff between pkgsrc and base acpica (this was
 non-trivial, the file paths differ):
 https://netbsd.org/~maya/acpica-diff-20180427

 with this, *and* forcing yacc (I deleted bison to be sure), pkgsrc iasl
 still works fine. It might be something about how we build things.

From: coypu@sdf.org
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/53405: base iasl can't build xen (no problem with unmodified
 iasl)
Date: Thu, 28 Jun 2018 07:03:02 +0000

 I have a suspicion it's not using all the acpica .y files. The makefile
 logic for this is confusing, though. Can anyone look at it?

From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53405 CVS commit: src/external/bsd/acpica/bin/iasl
Date: Thu, 28 Jun 2018 07:56:22 +0000

 Module Name:	src
 Committed By:	maya
 Date:		Thu Jun 28 07:56:22 UTC 2018

 Modified Files:
 	src/external/bsd/acpica/bin/iasl: Makefile

 Log Message:
 Correctly specify that iasl needs to be case insensitive.

 Fixes PR bin/53405. thanks to martin.


 To generate a diff of this commit:
 cvs rdiff -u -r1.20 -r1.21 src/external/bsd/acpica/bin/iasl/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Thu, 28 Jun 2018 08:03:37 +0000
State-Changed-Why:
Fixed. Not broken in -8 because that uses ${LEX} -i.


>Unformatted:

Home	PR Database Search