NetBSD Problem Report #53596

From www@NetBSD.org  Wed Sep 12 08:07:18 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id CB89D7A166
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 12 Sep 2018 08:07:17 +0000 (UTC)
Message-Id: <20180912080716.CA0DC7A1FE@mollari.NetBSD.org>
Date: Wed, 12 Sep 2018 08:07:16 +0000 (UTC)
From: toddpw@gmail.com
Reply-To: toddpw@gmail.com
To: gnats-bugs@NetBSD.org
Subject: x11/tigervnc needs to build_depends x11/xtrans
X-Send-Pr-Version: www-1.0

>Number:         53596
>Category:       pkg
>Synopsis:       x11/tigervnc needs to build_depends x11/xtrans
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          feedback
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 12 08:10:00 +0000 2018
>Closed-Date:    
>Last-Modified:  Mon Sep 24 18:30:01 +0000 2018
>Originator:     Todd Whitesel
>Release:        pkgsrc-2018Q2
>Organization:
self
>Environment:
NetBSD uni.toddpw.net 7.1 NetBSD 7.1 (GENERIC.201703111743Z) i386
>Description:
x11/tigervnc has a build dependency on x11/xtrans that is not declared, thus it is vulnerable to build failures.
>How-To-Repeat:
Try to build x11/tigervnc without x11/xtrans having been installed first. It will fail during configure with an error about a missing macro that starts with XTRANS_*.
>Fix:
Workaround: manually install x11/xtrans, then clean x11/tigervnc and make install again.

Fix: add the following to x11/tigervnc/Makefile:

BUILD_DEPENDS+= xtrans-[0-9]*:../../x11/xtrans

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->feedback
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sat, 22 Sep 2018 07:14:20 +0000
State-Changed-Why:
I'm confused about this bug. there are two cases:
- base xorg, then base xorg has xtrans 1.3.5 even in netbsd-7 as far as I can tell, and I tested that building does work.
- modular xorg, and it has .include "../../x11/xtrans/buildlink3.mk" since revisiosn 1.1 of the file. so that should work.
are you in a third case
- Didn't adjust X11_TYPE to set "modular", but didn't install all X sets?


From: Todd Whitesel <toddpw@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, 
	maya@netbsd.org
Subject: Re: pkg/53596 (x11/tigervnc needs to build_depends x11/xtrans)
Date: Sat, 22 Sep 2018 01:27:33 -0700

 --000000000000db90700576718703
 Content-Type: text/plain; charset="UTF-8"

 I am not in the 3rd case, because I did install all the X sets.

 I still have the install media that this machine was installed from, and
 the img file it was created from. I just re-downloaded
 ftp://ftp.netbsd.org/pub/NetBSD/images/7.1/NetBSD-7.1-i386-install.img.gz
 and it is still the same file.

 Running 'tar -tzvf' on all the installation sets piped through 'grep
 xtrans' yields only one hit: ./usr/X11R7/lib/pkgconfig/xtrans.pc in xcomp.

 So either the i386 install media image has an issue, or the xorg base in
 7.1 does not have xtrans in it.

 --Todd


 On Sat, Sep 22, 2018 at 12:14 AM <maya@netbsd.org> wrote:

 > Synopsis: x11/tigervnc needs to build_depends x11/xtrans
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: maya@NetBSD.org
 > State-Changed-When: Sat, 22 Sep 2018 07:14:20 +0000
 > State-Changed-Why:
 > I'm confused about this bug. there are two cases:
 > - base xorg, then base xorg has xtrans 1.3.5 even in netbsd-7 as far as I
 > can tell, and I tested that building does work.
 > - modular xorg, and it has .include "../../x11/xtrans/buildlink3.mk"
 > since revisiosn 1.1 of the file. so that should work.
 > are you in a third case
 > - Didn't adjust X11_TYPE to set "modular", but didn't install all X sets?
 >
 >
 >
 >

 -- 
 Todd Whitesel
 toddpw@gmail.com

 --000000000000db90700576718703
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 <div dir=3D"ltr"><div>I am not in the 3rd case, because I did install all t=
 he X sets.</div><div><br></div><div>I still have the install media that thi=
 s machine was installed from, and the img file it was created from. I just =
 re-downloaded <a href=3D"ftp://ftp.netbsd.org/pub/NetBSD/images/7.1/NetBSD-=
 7.1-i386-install.img.gz">ftp://ftp.netbsd.org/pub/NetBSD/images/7.1/NetBSD-=
 7.1-i386-install.img.gz</a> and it is still the same file.<br><div></div>

 </div><div><br></div><div>Running &#39;tar -tzvf&#39; on all the installati=
 on sets piped through &#39;grep xtrans&#39; yields only one hit: ./usr/X11R=
 7/lib/pkgconfig/xtrans.pc in xcomp.</div><div><br></div><div>So either the =
 i386 install media image has an issue, or the xorg base in 7.1 does not hav=
 e xtrans in it.<br></div><div><br></div><div></div><div>--Todd</div><div><b=
 r></div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr">On Sat, Sep 2=
 2, 2018 at 12:14 AM &lt;<a href=3D"mailto:maya@netbsd.org" target=3D"_blank=
 ">maya@netbsd.org</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote"=
  style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sy=
 nopsis: x11/tigervnc needs to build_depends x11/xtrans<br>
 <br>
 State-Changed-From-To: open-&gt;feedback<br>
 State-Changed-By: maya@NetBSD.org<br>
 State-Changed-When: Sat, 22 Sep 2018 07:14:20 +0000<br>
 State-Changed-Why:<br>
 I&#39;m confused about this bug. there are two cases:<br>
 - base xorg, then base xorg has xtrans 1.3.5 even in netbsd-7 as far as I c=
 an tell, and I tested that building does work.<br>
 - modular xorg, and it has .include &quot;../../x11/xtrans/<a href=3D"http:=
 //buildlink3.mk" rel=3D"noreferrer" target=3D"_blank">buildlink3.mk</a>&quo=
 t; since revisiosn 1.1 of the file. so that should work.<br>
 are you in a third case<br>
 - Didn&#39;t adjust X11_TYPE to set &quot;modular&quot;, but didn&#39;t ins=
 tall all X sets?<br>
 <br>
 <br>
 <br>
 </blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"m=
 _1271812197348692859gmail_signature" data-smartmail=3D"gmail_signature">Tod=
 d Whitesel<br><a href=3D"mailto:toddpw@gmail.com" target=3D"_blank">toddpw@=
 gmail.com</a></div>

 --000000000000db90700576718703--

From: maya@netbsd.org
To: Todd Whitesel <toddpw@gmail.com>
Cc: gnats-bugs@netbsd.org
Subject: Re: pkg/53596 (x11/tigervnc needs to build_depends x11/xtrans)
Date: Sat, 22 Sep 2018 08:45:56 +0000

 On Sat, Sep 22, 2018 at 01:27:33AM -0700, Todd Whitesel wrote:
 > I am not in the 3rd case, because I did install all the X sets.
 > 
 > I still have the install media that this machine was installed from, and
 > the img file it was created from. I just re-downloaded
 > ftp://ftp.netbsd.org/pub/NetBSD/images/7.1/NetBSD-7.1-i386-install.img.gz
 > and it is still the same file.
 > 
 > Running 'tar -tzvf' on all the installation sets piped through 'grep
 > xtrans' yields only one hit: ./usr/X11R7/lib/pkgconfig/xtrans.pc in xcomp.
 > 
 > So either the i386 install media image has an issue, or the xorg base in
 > 7.1 does not have xtrans in it.
 > 

 Try a case insensitive comparison, it's usually Xtrans

From: Todd Whitesel <toddpw@gmail.com>
To: maya@netbsd.org
Cc: gnats-bugs@netbsd.org
Subject: Re: pkg/53596 (x11/tigervnc needs to build_depends x11/xtrans)
Date: Sat, 22 Sep 2018 01:51:28 -0700

 --0000000000005fc403057671dd93
 Content-Type: text/plain; charset="UTF-8"

 Ok that yields more hits, mainly /usr/X11R7/include/X11/Xtrans/* which
 contains two headers and five source files. Looking at the live system,
 this is indeed installed.

 So now I guess the question is, why did the package build not find the base
 xtrans, whereas it did find the pkgsrc version once that was installed?

 --Todd


 On Sat, Sep 22, 2018 at 1:45 AM <maya@netbsd.org> wrote:

 > On Sat, Sep 22, 2018 at 01:27:33AM -0700, Todd Whitesel wrote:
 > > I am not in the 3rd case, because I did install all the X sets.
 > >
 > > I still have the install media that this machine was installed from, and
 > > the img file it was created from. I just re-downloaded
 > >
 > ftp://ftp.netbsd.org/pub/NetBSD/images/7.1/NetBSD-7.1-i386-install.img.gz
 > > and it is still the same file.
 > >
 > > Running 'tar -tzvf' on all the installation sets piped through 'grep
 > > xtrans' yields only one hit: ./usr/X11R7/lib/pkgconfig/xtrans.pc in
 > xcomp.
 > >
 > > So either the i386 install media image has an issue, or the xorg base in
 > > 7.1 does not have xtrans in it.
 > >
 >
 > Try a case insensitive comparison, it's usually Xtrans
 >


 -- 
 Todd Whitesel
 toddpw@gmail.com

 --0000000000005fc403057671dd93
 Content-Type: text/html; charset="UTF-8"
 Content-Transfer-Encoding: quoted-printable

 <div dir=3D"ltr"><div>Ok that yields more hits, mainly /usr/X11R7/include/X=
 11/Xtrans/* which contains two headers and five source files. Looking at th=
 e live system, this is indeed installed.<br></div><div><br></div><div>So no=
 w I guess the question is, why did the package build not find the base xtra=
 ns, whereas it did find the pkgsrc version once that was installed?<br></di=
 v><div><br></div><div>--Todd</div><div><br></div></div><br><div class=3D"gm=
 ail_quote"><div dir=3D"ltr">On Sat, Sep 22, 2018 at 1:45 AM &lt;<a href=3D"=
 mailto:maya@netbsd.org">maya@netbsd.org</a>&gt; wrote:<br></div><blockquote=
  class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc soli=
 d;padding-left:1ex">On Sat, Sep 22, 2018 at 01:27:33AM -0700, Todd Whitesel=
  wrote:<br>
 &gt; I am not in the 3rd case, because I did install all the X sets.<br>
 &gt; <br>
 &gt; I still have the install media that this machine was installed from, a=
 nd<br>
 &gt; the img file it was created from. I just re-downloaded<br>
 &gt; <a href=3D"ftp://ftp.netbsd.org/pub/NetBSD/images/7.1/NetBSD-7.1-i386-=
 install.img.gz" rel=3D"noreferrer" target=3D"_blank">ftp://ftp.netbsd.org/p=
 ub/NetBSD/images/7.1/NetBSD-7.1-i386-install.img.gz</a><br>
 &gt; and it is still the same file.<br>
 &gt; <br>
 &gt; Running &#39;tar -tzvf&#39; on all the installation sets piped through=
  &#39;grep<br>
 &gt; xtrans&#39; yields only one hit: ./usr/X11R7/lib/pkgconfig/xtrans.pc i=
 n xcomp.<br>
 &gt; <br>
 &gt; So either the i386 install media image has an issue, or the xorg base =
 in<br>
 &gt; 7.1 does not have xtrans in it.<br>
 &gt; <br>
 <br>
 Try a case insensitive comparison, it&#39;s usually Xtrans<br>
 </blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g=
 mail_signature" data-smartmail=3D"gmail_signature">Todd Whitesel<br><a href=
 =3D"mailto:toddpw@gmail.com" target=3D"_blank">toddpw@gmail.com</a></div>

 --0000000000005fc403057671dd93--

From: maya@netbsd.org
To: Todd Whitesel <toddpw@gmail.com>
Cc: gnats-bugs@netbsd.org
Subject: Re: pkg/53596 (x11/tigervnc needs to build_depends x11/xtrans)
Date: Sun, 23 Sep 2018 13:42:34 +0000

 it might be interesting to share the output of
 cd x11/tigervnc && find work/
 and work/.work.log

 It's also good to retry with an empty /etc/mk.conf and a clean build.

 also, you might want to try to delete x11-links (it'd install it again.
 it's a dummy package meant to make base xorg work).

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/53596: x11/tigervnc needs to build_depends x11/xtrans
Date: Mon, 24 Sep 2018 18:25:06 +0000

 On Wed, Sep 12, 2018 at 08:10:00AM +0000, toddpw@gmail.com wrote:
  > Try to build x11/tigervnc without x11/xtrans having been installed
  > first. It will fail during configure with an error about a missing
  > macro that starts with XTRANS_*.

 This sounds like the problem is not that it's not there but that the
 builtin version you have is too old for tigervnc. Otherwise it would
 be complaining that the include files aren't found. Except that
 apparently the one in 7.1 isn't too old.

 What's the macro? Does it exist in the builtin copy of xtrans in
 /usr/X11R7? Also, is the header file in question linked under
 /usr/pkg/share/x11-links?

 And, does the problem go away if you rebuild x11-links?

 -- 
 David A. Holland
 dholland@netbsd.org

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.