NetBSD Problem Report #53606

From izaac@janek.setec.org  Fri Sep 14 16:14:38 2018
Return-Path: <izaac@janek.setec.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 5B2317A17C
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 14 Sep 2018 16:14:38 +0000 (UTC)
Message-Id: <20180914161436.0825EC24A@janek.setec.org>
Date: Fri, 14 Sep 2018 12:14:36 -0400 (EDT)
From: izaac@setec.org
Reply-To: izaac@setec.org
To: gnats-bugs@NetBSD.org
Subject: pkgtools/pkgclean broken
X-Send-Pr-Version: 3.95

>Number:         53606
>Category:       pkg
>Synopsis:       pkgtools/pkgclean does not expand @SH@ before installation
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    leot
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 14 16:15:00 +0000 2018
>Closed-Date:    Fri Sep 14 17:41:17 +0000 2018
>Last-Modified:  Tue Sep 18 16:15:00 +0000 2018
>Originator:     Izaac
>Release:        n/a
>Organization:
>Environment:
n/a
>Description:
	- SUBST_STAGE.path from "post-patch" to "pre-configure"
	- the result is that @SH@ is never expanded after the shebang, which of course breaks the script
	- it would have taken perhaps five minutes to check, which is highly frustrating
>How-To-Repeat:
	( cd /usr/pkgsrc/pkgtools/pkgclean && bmake install ) ; /usr/pkg/bin/pkgclean
	pkgclean: Command not found.
>Fix:
	- revert pkgtools/pkgclean/Makefile 1.20 to 1.19
	- remove jperkin hands from a keyboard until he can perform the MOST BASIC TESTING of his changes before commit

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->leot
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Fri, 14 Sep 2018 16:26:12 +0000
Responsible-Changed-Why:
Take


State-Changed-From-To: open->feedback
State-Changed-By: leot@NetBSD.org
State-Changed-When: Fri, 14 Sep 2018 16:36:55 +0000
State-Changed-Why:
This should be fixed by:

 cvs rdiff -u -r1.20 -r1.21 pkgsrc/pkgtools/pkgclean/Makefile

Can you please try and let us known if it fixes the problem?



From: "Leonardo Taccari" <leot@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53606 CVS commit: pkgsrc/pkgtools/pkgclean
Date: Fri, 14 Sep 2018 16:31:28 +0000

 Module Name:	pkgsrc
 Committed By:	leot
 Date:		Fri Sep 14 16:31:28 UTC 2018

 Modified Files:
 	pkgsrc/pkgtools/pkgclean: Makefile

 Log Message:
 pkgclean: Properly replace @SH@ in pkgclean

 Most of the times setting NO_CONFIGURE is not needed and can badly
 interact with SUBST framework like in this case as pointed out by
 PR pkg/53606.

 Fixes PR pkg/53606.


 To generate a diff of this commit:
 cvs rdiff -u -r1.20 -r1.21 pkgsrc/pkgtools/pkgclean/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Izaac <izaac@setec.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/53606 (pkgtools/pkgclean does not expand @SH@ before
 installation)
Date: Fri, 14 Sep 2018 13:35:44 -0400

 On Fri, Sep 14, 2018 at 04:36:55PM +0000, leot@NetBSD.org wrote:
 > Synopsis: pkgtools/pkgclean does not expand @SH@ before installation
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: leot@NetBSD.org
 > State-Changed-When: Fri, 14 Sep 2018 16:36:55 +0000
 > State-Changed-Why:
 > This should be fixed by:
 > 
 >  cvs rdiff -u -r1.20 -r1.21 pkgsrc/pkgtools/pkgclean/Makefile
 > 
 > Can you please try and let us known if it fixes the problem?

 It does fix the problem.

 - Izaac

State-Changed-From-To: feedback->closed
State-Changed-By: leot@NetBSD.org
State-Changed-When: Fri, 14 Sep 2018 17:41:17 +0000
State-Changed-Why:
Confirmed fixed.


From: Benny Siegert <bsiegert@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/53606: pkgtools/pkgclean broken
Date: Sat, 15 Sep 2018 21:45:53 +0200

 Izaac,

 Independently of any technical merits of this bug, I want to make one
 thing absolutely clear:

 the way you are talking about project members in your bug reports is
 NOT OKAY. Stop it.

 -- 
 Benny

From: Izaac <izaac@setec.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/53606: pkgtools/pkgclean broken
Date: Tue, 18 Sep 2018 12:13:02 -0400

 On Sat, Sep 15, 2018 at 07:50:01PM +0000, Benny Siegert wrote:
 >  the way you are talking about project members in your bug reports is
 >  NOT OKAY. Stop it.

 Your opinion on this closed pr was neither required nor requested.
 Please feel free to address further opinions to me at:
 izaac+devnull@setec.org.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.