NetBSD Problem Report #53661

From gson@gson.org  Mon Oct  8 10:27:32 2018
Return-Path: <gson@gson.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 6AF8F7A1CF
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  8 Oct 2018 10:27:32 +0000 (UTC)
Message-Id: <20181008102726.CC62F989388@guava.gson.org>
Date: Mon,  8 Oct 2018 13:27:26 +0300 (EEST)
From: gson@gson.org (Andreas Gustafsson)
Reply-To: gson@gson.org (Andreas Gustafsson)
To: gnats-bugs@NetBSD.org
Subject: Shell syntax error during boot
X-Send-Pr-Version: 3.95

>Number:         53661
>Category:       port-evbarm
>Synopsis:       Shell syntax error during boot
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    port-evbarm-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 08 10:30:00 +0000 2018
>Closed-Date:    Tue Oct 09 17:18:09 +0000 2018
>Last-Modified:  Tue Oct 09 17:18:09 +0000 2018
>Originator:     Andreas Gustafsson
>Release:        NetBSD-current, source date >= 2018.09.25.17.57.33
>Organization:
>Environment:
System: NetBSD
Architecture: arm
Machine: evbarm
>Description:

When booting an evbarm-earmv7hf release image, during the reboot
following the disk resize step, immediately after the message
"Starting dhcpd", a shell syntax error message is printed on the
console:

  Starting dhcpcd.
  eval: 237: Syntax error: end of file unexpected (expecting "then")

This started some time around September 25:

  lyta.netbsd.org /bracket/evbarm-earmv7hf/results/2018 $ zgrep 'yntax error' */test.log.gz
  2018.09.24.22.22.16/test.log.gz:/sbin/resolvconf: 935: Syntax error: Unterminated quoted string
  2018.09.24.22.22.16/test.log.gz:/sbin/resolvconf: 935: Syntax error: Unterminated quoted string
  2018.09.25.17.57.33/test.log.gz:eval: 237: Syntax error: end of file unexpected (expecting "then")
  2018.09.26.09.06.48/test.log.gz:eval: 237: Syntax error: end of file unexpected (expecting "then")
  2018.09.26.20.03.36/test.log.gz:eval: 237: Syntax error: end of file unexpected (expecting "then")
  2018.09.27.01.35.41/test.log.gz:eval: 237: Syntax error: end of file unexpected (expecting "then")
  2018.09.27.05.40.27/test.log.gz:eval: 237: Syntax error: end of file unexpected (expecting "then")

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:
From: "Robert Elz" <kre@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53661 CVS commit: src/external/bsd/openresolv/dist
Date: Mon, 8 Oct 2018 14:09:39 +0000

 Module Name:	src
 Committed By:	kre
 Date:		Mon Oct  8 14:09:38 UTC 2018

 Modified Files:
 	src/external/bsd/openresolv/dist: resolvconf.in

 Log Message:
 PR port-evbarm/53661 (which has nothing particular to do with port-evbarm)

 When eval'ing RESTARTCMD don't field split it, only to join the words
 again (by eval) - that converts newlines and tabs to spaces, and the
 first of those causes sh syntax errors with the way that the various
 RESTARTCMDs are now written (but it was always dangerous, as filename
 expansions could also have happened, which is not wanted, I believe.)

 Also correct a translation error.


 To generate a diff of this commit:
 cvs rdiff -u -r1.3 -r1.4 src/external/bsd/openresolv/dist/resolvconf.in

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: kre@NetBSD.org
State-Changed-When: Mon, 08 Oct 2018 14:10:22 +0000
State-Changed-Why:
Is it OK now?


From: Andreas Gustafsson <gson@gson.org>
To: kre@NetBSD.org
Cc: gnats-bugs@NetBSD.org
Subject: Re: port-evbarm/53661 (Shell syntax error during boot)
Date: Mon, 8 Oct 2018 20:58:00 +0300

 kre@NetBSD.org wrote:
 > Is it OK now?

 No, I'm still getting the same error with resolvconf.in 1.4 (source
 date 2018.10.08.14.09.38), on my own testbed:

   Starting dhcpcd.
   eval: 237: Syntax error: end of file unexpected (expecting "then")
   Starting mdnsd.

 -- 
 Andreas Gustafsson, gson@gson.org

From: "Robert Elz" <kre@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53661 CVS commit: src/external/bsd/openresolv/dist
Date: Tue, 9 Oct 2018 01:28:35 +0000

 Module Name:	src
 Committed By:	kre
 Date:		Tue Oct  9 01:28:35 UTC 2018

 Modified Files:
 	src/external/bsd/openresolv/dist: dnsmasq.in libc.in named.in
 	    unbound.in

 Log Message:
 PR port-evbarm/53661

 Always quote RESTARTCMD when eval'ing it.   Whatever script does it...


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 src/external/bsd/openresolv/dist/dnsmasq.in \
     src/external/bsd/openresolv/dist/libc.in \
     src/external/bsd/openresolv/dist/named.in
 cvs rdiff -u -r1.1.1.8 -r1.2 src/external/bsd/openresolv/dist/unbound.in

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Robert Elz <kre@munnari.OZ.AU>
To: Andreas Gustafsson <gson@gson.org>
Cc: gnats-bugs@NetBSD.org
Subject: Re: port-evbarm/53661 (Shell syntax error during boot)
Date: Tue, 09 Oct 2018 08:30:29 +0700

     Date:        Mon, 8 Oct 2018 20:58:00 +0300
     From:        Andreas Gustafsson <gson@gson.org>
     Message-ID:  <23483.39592.740865.118014@guava.gson.org>

   | No, I'm still getting the same error with resolvconf.in 1.4 (source
   | date 2018.10.08.14.09.38), on my own testbed:

 Can you try again, using sources after: Tue Oct  9 01:28:35 UTC 2018

 This time it might really be fixed.

 kre

State-Changed-From-To: feedback->closed
State-Changed-By: gson@NetBSD.org
State-Changed-When: Tue, 09 Oct 2018 17:18:09 +0000
State-Changed-Why:
Fixed as of source date 2018.10.09.02.53.11.  Thanks kre!


>Unformatted:

Home	PR Database Search