NetBSD Problem Report #53720

From www@NetBSD.org  Sun Nov 11 02:05:20 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 329E37A14F
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 11 Nov 2018 02:05:20 +0000 (UTC)
Message-Id: <20181111020518.E92B27A1B0@mollari.NetBSD.org>
Date: Sun, 11 Nov 2018 02:05:18 +0000 (UTC)
From: daniel+netbsd@loffgren.org
Reply-To: daniel+netbsd@loffgren.org
To: gnats-bugs@NetBSD.org
Subject: TOOL_DTC does not have a fallback if USE_TOOLS isn't set
X-Send-Pr-Version: www-1.0

>Number:         53720
>Category:       kern
>Synopsis:       TOOL_DTC does not have a fallback if USE_TOOLS isn't set
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Nov 11 02:10:00 +0000 2018
>Closed-Date:    Sun Nov 11 08:29:12 +0000 2018
>Last-Modified:  Sun Nov 11 08:30:00 +0000 2018
>Originator:     Daniel Loffgren
>Release:        NetBSD 8.99.25, Current as of ~Nov 8 2018
>Organization:
>Environment:
System: NetBSD pinebook 8.99.25 NetBSD 8.99.25 (PINEBOOK) #0: Fri Nov 9 18:10:13 PST 2018 kojiro@pinebook:/usr/src/sys/arch/evbarm/compile/PINEBOOK evbarm
Architecture: aarch64
Machine: evbarm
>Description:
Building an evbarm kernel using simply "make" fails due to TOOL_DTC not being defined.
TOOL_DTC is defined in src/share/mk/bsd.own.mk, when USE_TOOLS is set, but not in the body of the else with the rest of the default ones.
This can be worked around by doing "make TOOL_DTC=dtc", but that shouldn't be required.
>How-To-Repeat:
From a fresh source checkout, attempt to build an evbarm kernel using something along the lines of:
	cd /usr/src/sys/arch/evbarm/conf/
	config GENERIC64
	cd ../compile/GENERIC64
	make depend
	make

>Fix:
Index: bsd.own.mk
===================================================================
RCS file: /cvsroot/src/share/mk/bsd.own.mk,v
retrieving revision 1.1078
diff -u -r1.1078 bsd.own.mk
--- bsd.own.mk	6 Oct 2018 18:52:59 -0000	1.1078
+++ bsd.own.mk	11 Nov 2018 01:12:32 -0000
@@ -485,6 +485,7 @@
 TOOL_CTFMERGE=		ctfmerge
 TOOL_CVSLATEST=		cvslatest
 TOOL_DB=		db
+TOOL_DTC=		dtc
 TOOL_DISKLABEL=		disklabel
 TOOL_EQN=		eqn
 TOOL_FDISK=		fdisk

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Sun, 11 Nov 2018 08:29:12 +0000
State-Changed-Why:
Applied, thanks!


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53720 CVS commit: src/share/mk
Date: Sun, 11 Nov 2018 08:28:35 +0000

 Module Name:	src
 Committed By:	maya
 Date:		Sun Nov 11 08:28:35 UTC 2018

 Modified Files:
 	src/share/mk: bsd.own.mk

 Log Message:
 Provide a fallback dtc if USE_TOOLS isn't in use.

 From Daniel Loffgren in PR kern/53720.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1080 -r1.1081 src/share/mk/bsd.own.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search