NetBSD Problem Report #53821

From www@NetBSD.org  Mon Dec 31 16:09:15 2018
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id BBB4E7A0F8
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 31 Dec 2018 16:09:15 +0000 (UTC)
Message-Id: <20181231160915.08FB07A276@mollari.NetBSD.org>
Date: Mon, 31 Dec 2018 16:09:15 +0000 (UTC)
From: dcb314@hotmail.com
Reply-To: dcb314@hotmail.com
To: gnats-bugs@NetBSD.org
Subject: src/sys/dev/pci/if_wm.c: some possibly pointless tests ?
X-Send-Pr-Version: www-1.0

>Number:         53821
>Category:       kern
>Synopsis:       src/sys/dev/pci/if_wm.c: some possibly pointless tests ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Dec 31 16:10:00 +0000 2018
>Closed-Date:    Thu Jan 03 08:47:15 +0000 2019
>Last-Modified:  Thu Jan 03 08:47:15 +0000 2019
>Originator:     David Binderman
>Release:        20181231
>Organization:
>Environment:
>Description:
[src/sys/dev/pci/if_wm.c:14616] -> [src/sys/dev/pci/if_wm.c:14640]: (warning) Identical condition 'rv!=0', second condition is always false


Source code is

                        sc->phy.readreg_locked(dev, 1, I217_MEMPWR, &phy_reg);
                        if (rv != 0)
                                goto release;

Maybe better code

                        rv = sc->phy.readreg_locked(dev, 1, I217_MEMPWR, &phy_reg);
                        if (rv != 0)
                                goto release;

[src/sys/dev/pci/if_wm.c:14616] -> [src/sys/dev/pci/if_wm.c:14650]: (warning) Identical condition 'rv!=0', second condition is always false

Duplicate.

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: msaitoh@NetBSD.org
State-Changed-When: Thu, 03 Jan 2019 08:47:15 +0000
State-Changed-Why:
Fixed. Thanks.


>Unformatted:

Home	PR Database Search