NetBSD Problem Report #53849

From www@NetBSD.org  Thu Jan 10 00:41:30 2019
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id CAF7C7A1EE
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 10 Jan 2019 00:41:29 +0000 (UTC)
Message-Id: <20190110004129.058D07A27B@mollari.NetBSD.org>
Date: Thu, 10 Jan 2019 00:41:29 +0000 (UTC)
From: joseyluis@gmail.com
Reply-To: joseyluis@gmail.com
To: gnats-bugs@NetBSD.org
Subject: Fix comment lfs.h Offset of di_spare is wrong
X-Send-Pr-Version: www-1.0

>Number:         53849
>Category:       kern
>Synopsis:       Fix comment lfs.h Offset of di_spare is wrong
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 10 00:45:00 +0000 2019
>Closed-Date:    Thu Jan 10 06:32:29 +0000 2019
>Last-Modified:  Thu Jan 10 06:55:01 +0000 2019
>Originator:     José Luis Rodríguez García
>Release:        current
>Organization:
>Environment:
>Description:
The di_spare[1] member of the structure lfs64_dinode begins at offset 248 instead of 244.

The di_inumber was changed from 32 to 64 bits in the 1.179 version of lfs.h, but the comment wasn't updated.
>How-To-Repeat:

>Fix:
$ cvs diff -u -N
cvs diff: Diffing .
Index: lfs.h
===================================================================
RCS file: /cvsroot/src/sys/ufs/lfs/lfs.h,v
retrieving revision 1.203
diff -u -r1.203 lfs.h
--- lfs.h	26 Jul 2017 16:42:37 -0000	1.203
+++ lfs.h	10 Jan 2019 00:10:58 -0000
@@ -467,7 +467,7 @@
 	int64_t		di_ib[ULFS_NIADDR]; /* 208: Indirect disk blocks. */
 	uint64_t	di_modrev;	/* 232: i_modrev for NFSv4 */
 	uint64_t	di_inumber;	/* 240: Inode number */
-	uint64_t	di_spare[1];	/* 244: Reserved; currently unused */
+	uint64_t	di_spare[1];	/* 248: Reserved; currently unused */
 };

 union lfs_dinode {

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Thu, 10 Jan 2019 06:32:29 +0000
State-Changed-Why:
Patch applied, thanks!


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53849 CVS commit: src/sys/ufs/lfs
Date: Thu, 10 Jan 2019 06:31:05 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Thu Jan 10 06:31:04 UTC 2019

 Modified Files:
 	src/sys/ufs/lfs: lfs.h

 Log Message:
 Update comment (overlooked in r1.179).
 From José Luis Rodríguez García in PR kern/53849.


 To generate a diff of this commit:
 cvs rdiff -u -r1.203 -r1.204 src/sys/ufs/lfs/lfs.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: kern/53849: Fix comment lfs.h Offset of di_spare is wrong
Date: Thu, 10 Jan 2019 06:54:55 +0000

 On Thu, Jan 10, 2019 at 12:45:00AM +0000, joseyluis@gmail.com wrote:
  > The di_spare[1] member of the structure lfs64_dinode begins at
  > offset 248 instead of 244.

 Oops, thanks!

 -- 
 David A. Holland
 dholland@netbsd.org

>Unformatted:

Home	PR Database Search