NetBSD Problem Report #53943

From martin@duskware.de  Mon Feb  4 11:30:38 2019
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id B0AFF7A1E1
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  4 Feb 2019 11:30:38 +0000 (UTC)
From: martin@NetBSD.org
Reply-To: martin@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: kernel loader errors during ATF runs
X-Send-Pr-Version: 3.95

>Number:         53943
>Category:       kern
>Synopsis:       kernel loader errors during ATF runs
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pgoyette
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 04 11:35:00 +0000 2019
>Closed-Date:    Wed Feb 06 10:59:18 +0000 2019
>Last-Modified:  Wed Feb 06 10:59:18 +0000 2019
>Originator:     Martin Husemann
>Release:        NetBSD 8.99.34
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD thirdstage.duskware.de 8.99.34 NetBSD 8.99.34 (MODULAR) #151: Mon Feb 4 09:03:05 CET 2019 martin@thirdstage.duskware.de:/usr/src/sys/arch/sparc64/compile/MODULAR sparc64
Architecture: sparc64
Machine: sparc64
>Description:

During ATF runs in -current I get this log messages:

[ 5650.6832710] kobj_checksyms, 1020: [%M/puffs/puffs.kmod]: linker error: globa
l symbol `puffs_50_fini' redefined
[ 5650.8032710] kobj_checksyms, 1020: [%M/puffs/puffs.kmod]: linker error: globa
l symbol `puffs_compat_incoming' redefined
[ 5650.9332734] kobj_checksyms, 1020: [%M/puffs/puffs.kmod]: linker error: globa
l symbol `puffs_50_init' redefined
[ 5651.0532735] kobj_checksyms, 1020: [%M/puffs/puffs.kmod]: linker error: globa
l symbol `puffs_compat_outgoing' redefined
[ 5651.6532891] kobj_checksyms, 1020: [%M/puffs/puffs.kmod]: linker error: globa
l symbol `puffs_50_fini' redefined
[ 5651.7768804] kobj_checksyms, 1020: [%M/puffs/puffs.kmod]: linker error: globa
l symbol `puffs_compat_incoming' redefined
[ 5651.9058140] kobj_checksyms, 1020: [%M/puffs/puffs.kmod]: linker error: globa
l symbol `puffs_50_init' redefined
[ 5652.0264287] kobj_checksyms, 1020: [%M/puffs/puffs.kmod]: linker error: globa
l symbol `puffs_compat_outgoing' redefined
[ 5652.6232931] kobj_checksyms, 1020: [%M/puffs/puffs.kmod]: linker error: globa
l symbol `puffs_50_fini' redefined
[ 5652.7407567] kobj_checksyms, 1020: [%M/puffs/puffs.kmod]: linker error: globa
l symbol `puffs_compat_incoming' redefined
[ 5652.8696873] kobj_checksyms, 1020: [%M/puffs/puffs.kmod]: linker error: globa
l symbol `puffs_50_init' redefined

I don't know if redefined symbols are supposed to happen (guess not), and
also note the obviously broken log message (%M not being expanded).

>How-To-Repeat:
run atf tests

>Fix:
n/a

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->pgoyette
Responsible-Changed-By: pgoyette@NetBSD.org
Responsible-Changed-When: Mon, 04 Feb 2019 11:47:35 +0000
Responsible-Changed-Why:
Probably mine - take it


From: "Paul Goyette" <pgoyette@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53943 CVS commit: src/sys
Date: Mon, 4 Feb 2019 12:08:03 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Mon Feb  4 12:08:03 UTC 2019

 Modified Files:
 	src/sys/fs/puffs: files.puffs
 	src/sys/modules/puffs: Makefile

 Log Message:
 Don't include puffs_compat in a kernel unless the filesystem is
 selected along with COMPAT_50.  Also, don't include puffs_compat
 in the main puffs filesystem module;  it is part of the compat_50
 module.

 Should address PR kern/53943


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 src/sys/fs/puffs/files.puffs
 cvs rdiff -u -r1.2 -r1.3 src/sys/modules/puffs/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Tue, 05 Feb 2019 00:23:40 +0000
State-Changed-Why:
Fix committed, please verify


From: "Paul Goyette" <pgoyette@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/53943 CVS commit: src/sys/fs/puffs
Date: Tue, 5 Feb 2019 00:22:36 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Tue Feb  5 00:22:36 UTC 2019

 Modified Files:
 	src/sys/fs/puffs: files.puffs

 Log Message:
 It turns out we do want the puffs compat code in any kernel which
 has built-in compat_50 regardless of whether the kernel also has
 puffs.

 Should finally fix PR kern/53943


 To generate a diff of this commit:
 cvs rdiff -u -r1.9 -r1.10 src/sys/fs/puffs/files.puffs

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: feedback->open
State-Changed-By: martin@NetBSD.org
State-Changed-When: Tue, 05 Feb 2019 16:32:11 +0000
State-Changed-Why:
Still get the messages


From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: pgoyette@NetBSD.org
Subject: Re: kern/53943 (kernel loader errors during ATF runs)
Date: Tue, 5 Feb 2019 17:33:30 +0100

 I still get the errors for the following symbols:

 `puffs_50_fini'
 `puffs_50_init'
 `puffs_compat_incoming'
 `puffs_compat_outgoing'

 Do I need to force a rebuild of some unchanged modules?

 Martin

From: Paul Goyette <paul@whooppee.com>
To: Martin Husemann <martin@duskware.de>
Cc: gnats-bugs@NetBSD.org, pgoyette@NetBSD.org
Subject: Re: kern/53943 (kernel loader errors during ATF runs)
Date: Wed, 6 Feb 2019 07:14:50 +0800 (PST)

 On Tue, 5 Feb 2019, Martin Husemann wrote:

 > I still get the errors for the following symbols:
 >
 > `puffs_50_fini'
 > `puffs_50_init'
 > `puffs_compat_incoming'
 > `puffs_compat_outgoing'
 >
 > Do I need to force a rebuild of some unchanged modules?

 The problem was (originally) caused because the kernel config had 
 "COMPAT_50" defined (which included the puffs compat_50 code), but did 
 not have puffs.  The tests attempted to use puffs, which caused us to 
 attempt to autoload the puffs module.  But the puffs module still had 
 its own copy of the puffs compat code.

 The puffs module should have been re-created when you updated, so I 
 don't quite understand why it is still failing.  I'm building a new 
 sparc64 release now.


 +------------------+--------------------------+----------------------------+
 | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
 | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
 | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
 +------------------+--------------------------+----------------------------+

State-Changed-From-To: open->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Wed, 06 Feb 2019 10:59:18 +0000
State-Changed-Why:
Works after rebuild modules


>Unformatted:

Home	PR Database Search