NetBSD Problem Report #54064

From gson@gson.org  Sat Mar 16 15:34:46 2019
Return-Path: <gson@gson.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 7484C7A1B5
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 16 Mar 2019 15:34:46 +0000 (UTC)
Message-Id: <20190316153443.0C6C79894DA@guava.gson.org>
Date: Sat, 16 Mar 2019 17:34:43 +0200 (EET)
From: gson@gson.org (Andreas Gustafsson)
Reply-To: gson@gson.org (Andreas Gustafsson)
To: gnats-bugs@NetBSD.org
Subject: modules/t_kcov tests fail randomly
X-Send-Pr-Version: 3.95

>Number:         54064
>Category:       kern
>Synopsis:       modules/t_kcov tests fail randomly
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kamil
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Mar 16 15:35:00 +0000 2019
>Closed-Date:    Tue Apr 16 07:56:26 +0000 2019
>Last-Modified:  Tue Apr 16 07:56:26 +0000 2019
>Originator:     Andreas Gustafsson
>Release:        NetBSD-current
>Organization:

>Environment:
System: NetBSD
Architecture: x86_64
Machine: amd64
>Description:

Running the ATF tests on real amd64 hardware, I'm seeing random
failures in modules/t_kcov.  For example, in this test report:

  http://www.gson.org/netbsd/bugs/build/amd64-baremetal/2019/2019.03.16.10.45.06/test.html#modules_t_kcov_kcov_multiple_threads8

most of the tests were skipped, but kcov_multiple_threads8 reported

  FAILED: Test case exited normally but failed to create the results file: Results file is empty

>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->kamil
Responsible-Changed-By: gson@NetBSD.org
Responsible-Changed-When: Sat, 16 Mar 2019 15:37:32 +0000
Responsible-Changed-Why:
kamil created the test.


From: "Kamil Rytarowski" <kamil@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54064 CVS commit: src/tests/modules
Date: Thu, 4 Apr 2019 10:53:20 +0000

 Module Name:	src
 Committed By:	kamil
 Date:		Thu Apr  4 10:53:20 UTC 2019

 Modified Files:
 	src/tests/modules: t_kcov.c

 Log Message:
 Fix flaky check for the /dev/kcov device in t_kcov

 Add a top-level check for the KCOV device, instead of deferring it ot each
 thread. The thread-based solution was flaky.

 PR kern/54064 by Andreas Gustafsson


 To generate a diff of this commit:
 cvs rdiff -u -r1.8 -r1.9 src/tests/modules/t_kcov.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: kamil@NetBSD.org
State-Changed-When: Thu, 04 Apr 2019 12:59:21 +0200
State-Changed-Why:
Fix applied, please check.


State-Changed-From-To: feedback->closed
State-Changed-By: gson@NetBSD.org
State-Changed-When: Tue, 16 Apr 2019 07:56:26 +0000
State-Changed-Why:
There have now been 12 runs with no failures, so I'm calling it fixed.


>Unformatted:

Home	PR Database Search