NetBSD Problem Report #54149

From mouse@Stone.Rodents-Montreal.ORG  Wed May  1 22:28:13 2019
Return-Path: <mouse@Stone.Rodents-Montreal.ORG>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 9F5897A170
	for <gnats-bugs@www.NetBSD.org>; Wed,  1 May 2019 22:28:13 +0000 (UTC)
Message-Id: <201905012228.SAA02778@Stone.Rodents-Montreal.ORG>
Date: Wed, 1 May 2019 18:28:11 -0400 (EDT)
From: Mouse <mouse@Rodents-Montreal.ORG>
Reply-To: mouse@Rodents-Montreal.ORG
To: gnats-bugs@www.NetBSD.org
Subject: NetMOS NM9912 pucdata.c entries
X-Send-Pr-Version: 3.95

>Number:         54149
>Category:       kern
>Synopsis:       8.0 doesn't recognize the NetMOS NM9912
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    jdolecek
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed May 01 22:30:00 +0000 2019
>Closed-Date:    Mon May 06 12:16:44 +0000 2019
>Last-Modified:  Mon May 06 12:16:44 +0000 2019
>Originator:     Mouse
>Release:        NetBSD 8.0
>Organization:
	Dis-
>Environment:
System: NetBSD Aaeon.Rodents-Montreal.ORG 8.0 NetBSD 8.0 (MAQ) #1: Wed May  1 17:05:41 EDT 2019
Architecture: amd64
Machine: amd64
>Description:
	I have a work machine with 8.0.  It has no built-in parallel
	port; we gave it one with a NetMOS NM9912 board.  8.0 failed to
	recognize this until I added it to pucdata.c.  Looking at
	http://cvsweb.NetBSD.org/bsdweb.cgi/src/sys/dev/pci/pucdata.c?rev=1.103&content-type=text/x-cvsweb-markup&only_with_tag=MAIN
	makes me think -current is similarly afflicted.

	I'm marking this non-critical/medium, but for our use it's
	actually critical/high; the machine is not usable for our
	purposes without the parallel port.  But we have this in our
	own source tree, where it works, so our immediate need is
	satisfied.
>How-To-Repeat:
	Plug such a NetMOS board in.  Boot 8.0.  Notice that it reports
	its usual "not configured" lines for it, even though inspection
	reveals that the vendor and product values are present in
	pcidevs.
>Fix:
	(Note: the serial ports attach for me with this patch, but I
	have not tested them; the hardware we have does not bring them
	out to connectors.)

	diff --git a/sys/dev/pci/pucdata.c b/sys/dev/pci/pucdata.c
	index 89f8f57..2271052 100644
	--- a/sys/dev/pci/pucdata.c
	+++ b/sys/dev/pci/pucdata.c
	@@ -3079,5 +3079,23 @@ const struct puc_device_description puc_devices[] = {
	 	    },
	 	},

	+	/*
	+	 * NetMOS boards
	+	 */
	+	{ "NetMos NM9912 Dual PCI-E UART and 1284 Printer Port",
	+	    {   PCI_VENDOR_NETMOS, PCI_PRODUCT_NETMOS_NM9912, 0, 0x1000 },
	+	    {   0xffff, 0xffff, 0, 0xffff },
	+	    {
	+		{ PUC_PORT_TYPE_COM, 0x10, 0x0000, 0 },
	+	    },
	+	},
	+	{ "NetMos NM9912 Dual PCI-E UART and 1284 Printer Port",
	+	    {   PCI_VENDOR_NETMOS, PCI_PRODUCT_NETMOS_NM9912, 0, 0x2000 },
	+	    {   0xffff, 0xffff, 0, 0xffff },
	+	    {
	+		{ PUC_PORT_TYPE_LPT, 0x10, 0x0000, 0 },
	+	    },
	+	},
	+
	 	{ .name = NULL },
	 };

	With this patch, I see

	puc0 at pci3 dev 0 function 0: NetMos NM9912 Dual PCI-E UART and 1284 Printer Port (com)
	com2 at puc0 port 0 (16550-compatible): ioaddr 0xd030, interrupting at ioapic0 pin 16
	com2: ns16550a, working fifo
	puc1 at pci3 dev 0 function 1: NetMos NM9912 Dual PCI-E UART and 1284 Printer Port (com)
	com3 at puc1 port 0 (16550-compatible): ioaddr 0xd020, interrupting at ioapic0 pin 17
	com3: ns16550a, working fifo
	puc2 at pci3 dev 0 function 2: NetMos NM9912 Dual PCI-E UART and 1284 Printer Port (lpt)
	lpt2 at puc2 port 0: ioaddr 0xd010, interrupting at ioapic0 pin 18

/~\ The ASCII				  Mouse
\ / Ribbon Campaign
 X  Against HTML		mouse@rodents-montreal.org
/ \ Email!	     7D C8 61 52 5D E7 2D 39  4E F1 31 3E E8 B3 27 4B

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->jdolecek
Responsible-Changed-By: jdolecek@NetBSD.org
Responsible-Changed-When: Thu, 02 May 2019 21:35:45 +0000
Responsible-Changed-Why:
I've committed the change.


State-Changed-From-To: open->pending-pullups
State-Changed-By: jdolecek@NetBSD.org
State-Changed-When: Thu, 02 May 2019 21:35:45 +0000
State-Changed-Why:
Waiting for pullup to netbsd-8 - #1255


From: "Jaromir Dolecek" <jdolecek@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54149 CVS commit: src/sys/dev/pci
Date: Thu, 2 May 2019 21:33:12 +0000

 Module Name:	src
 Committed By:	jdolecek
 Date:		Thu May  2 21:33:12 UTC 2019

 Modified Files:
 	src/sys/dev/pci: pucdata.c

 Log Message:
 add NetMos NM9912 entries

 PR kern/54149 by Mouse


 To generate a diff of this commit:
 cvs rdiff -u -r1.103 -r1.104 src/sys/dev/pci/pucdata.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54149 CVS commit: [netbsd-8] src/sys/dev/pci
Date: Sun, 5 May 2019 08:20:08 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sun May  5 08:20:08 UTC 2019

 Modified Files:
 	src/sys/dev/pci [netbsd-8]: pucdata.c

 Log Message:
 Pull up following revision(s) (requested by jdolecek in ticket #1255):

 	sys/dev/pci/pucdata.c: revision 1.104

 add NetMos NM9912 entries

 PR kern/54149 by Mouse


 To generate a diff of this commit:
 cvs rdiff -u -r1.99.8.3 -r1.99.8.4 src/sys/dev/pci/pucdata.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: jdolecek@NetBSD.org
State-Changed-When: Mon, 06 May 2019 12:16:44 +0000
State-Changed-Why:
Pullups to netbsd-8 done.


>Unformatted:

Home	PR Database Search