NetBSD Problem Report #54187
From gson@gson.org Fri May 10 07:04:21 2019
Return-Path: <gson@gson.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 04BDF7A1AB
for <gnats-bugs@gnats.NetBSD.org>; Fri, 10 May 2019 07:04:20 +0000 (UTC)
Message-Id: <20190510070416.415BD989F84@guava.gson.org>
Date: Fri, 10 May 2019 10:04:16 +0300 (EEST)
From: gson@gson.org (Andreas Gustafsson)
Reply-To: gson@gson.org (Andreas Gustafsson)
To: gnats-bugs@NetBSD.org
Subject: dev/audio/t_pad:pad_output test now fails
X-Send-Pr-Version: 3.95
>Number: 54187
>Category: kern
>Synopsis: dev/audio/t_pad:pad_output test now fails
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: isaki
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Fri May 10 07:05:00 +0000 2019
>Closed-Date: Thu Jun 20 12:27:47 +0000 2019
>Last-Modified: Thu Jun 20 12:27:47 +0000 2019
>Originator: Andreas Gustafsson
>Release: NetBSD-current
>Organization:
>Environment:
System: NetBSD
Architecture: i386
Machine: i386
>Description:
The pad_output test case of the dev/audio/t_pad test program is now
failing on the i386 testbed, and also on real amd64 hardware:
http://releng.netbsd.org/b5reports/i386/2019/2019.05.09.07.38.44/test.html#dev_audio_t_pad_pad_output
http://www.gson.org/netbsd/bugs/build/amd64-baremetal/2019/2019.05.09.13.07.35/test.html#dev_audio_t_pad_pad_output
This did not result in an automated report by the i386 testbed because
the test case had not been consistently passing before it started
consistently failing:
2019.05.07.22.00.10/test.log.gz: pad_output: [9.498967s] Passed.
2019.05.08.01.08.18/test.log.gz: pad_output: [6.051286s] Passed.
2019.05.08.04.34.33/test.log.gz: pad_output: [5.887895s] Passed.
2019.05.08.06.57.18/test.log.gz: pad_output: [3.892165s] Failed: atf-check failed; see the output of the test for details
2019.05.08.07.44.28/test.log.gz: pad_output: [5.342946s] Passed.
2019.05.08.09.53.43/test.log.gz: pad_output: [5.826627s] Passed.
2019.05.08.14.25.39/test.log.gz: pad_output: [4.001009s] Failed: atf-check failed; see the output of the test for details
2019.05.08.18.00.16/test.log.gz: pad_output: [4.115639s] Failed: atf-check failed; see the output of the test for details
2019.05.08.19.34.09/test.log.gz: pad_output: [4.522798s] Failed: atf-check failed; see the output of the test for details
2019.05.08.22.01.47/test.log.gz: pad_output: [6.781709s] Failed: atf-check failed; see the output of the test for details
2019.05.09.02.43.35/test.log.gz: pad_output: [4.429132s] Failed: atf-check failed; see the output of the test for details
>How-To-Repeat:
Run the ATF tests.
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: kern-bug-people->isaki
Responsible-Changed-By: gson@NetBSD.org
Responsible-Changed-When: Fri, 10 May 2019 07:15:27 +0000
Responsible-Changed-Why:
Over to committer.
From: "Tetsuya Isaki" <isaki@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/54187 CVS commit: src
Date: Thu, 20 Jun 2019 12:14:47 +0000
Module Name: src
Committed By: isaki
Date: Thu Jun 20 12:14:46 UTC 2019
Modified Files:
src/distrib/sets/lists/tests: mi
src/tests/dev/audio: Makefile h_pad.c t_pad.sh
Removed Files:
src/tests/dev/audio: t_pad_output.bz2.uue
Log Message:
Rewrite t_pad test.
Previous version compared the pad's output binary passed mulaw-slinear
conversion and frequency conversion with the prepared "good result".
In such case, a test may fail when the implemantation changes. In fact,
the frequency conversion algorithm was changed in isaki-audio2, so
output waveforms is not completely the same (but that's no problem with
the audio waveforms).
New version uses slinear_le/2ch/44100Hz input data and compares the
output binary with the input data. pad with no conversions should
output the same binary.
Fix PR kern/54187.
To generate a diff of this commit:
cvs rdiff -u -r1.816 -r1.817 src/distrib/sets/lists/tests/mi
cvs rdiff -u -r1.5 -r1.6 src/tests/dev/audio/Makefile
cvs rdiff -u -r1.2 -r1.3 src/tests/dev/audio/h_pad.c
cvs rdiff -u -r1.3 -r1.4 src/tests/dev/audio/t_pad.sh
cvs rdiff -u -r1.4 -r0 src/tests/dev/audio/t_pad_output.bz2.uue
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: isaki@NetBSD.org
State-Changed-When: Thu, 20 Jun 2019 12:27:47 +0000
State-Changed-Why:
commited.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.43 2018/01/16 07:36:43 maya Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2017
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.