NetBSD Problem Report #54249

From www@netbsd.org  Wed May 29 12:21:14 2019
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id DE6D77A184
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 29 May 2019 12:21:14 +0000 (UTC)
Message-Id: <20190529122043.A27877A1E4@mollari.NetBSD.org>
Date: Wed, 29 May 2019 12:20:43 +0000 (UTC)
From: oshima-ya@yagoto-urayama.jp
Reply-To: oshima-ya@yagoto-urayama.jp
To: gnats-bugs@NetBSD.org
Subject: pkg-conf ig --modversion xcb-xinput returns wrong version string.
X-Send-Pr-Version: www-1.0

>Number:         54249
>Category:       xsrc
>Synopsis:       pkg-conf ig --modversion xcb-xinput returns wrong version string.
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    xsrc-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 29 12:25:00 +0000 2019
>Closed-Date:    Fri May 31 14:13:04 +0000 2019
>Last-Modified:  Fri May 31 14:13:04 +0000 2019
>Originator:     Yasushi Oshima
>Release:        NetBSD/amd64 8.1_RC1
>Organization:
>Environment:
NetBSD yuzu 8.1_RC1 NetBSD 8.1_RC1 (GENERIC) #0: Sat May 25 12:22:52 JST 2019  oshima@sudachi:/export/netbsd-8/20190523/obj/amd64/sys/arch/amd64/compile/GENERIC amd64
>Description:
Even though xsrc's libxcb (in-tree) is 1.12 (netbsd-8) or 1.13 (-current), the xcb submodule's pkgconfig --modversion returns 1.10.

On netbsd-8:
pkg-config --modversion xcb
1.12
pkg-config --modversion xcb-xinput
1.10

On current:
% pkg-config --modversion xcb
1.13
% pkg-config --modversion xcb-xinput
1.10

Thus, x11/qt5-qtbase of pkgsrc requires xcb-xinput 1.12 or higher, but pkg-config (devel/pkgconf in pkgsrc) returns as 1.10, so xcb-xinput becomes 'no'.

[[configure log]]
:
Checking for XLib... yes
Checking for XCB Xlib... yes
Checking for XCB GLX... yes
Checking for XRender for native painting... no
Checking for X11 session management... yes
Checking for XCB XInput... no                       <<==HERE!
Checking for XCB XKB >= 1.10... yes


As a result, graphics/krita which uses this does not recognize mouse pointer (by xcb-xinput) and can not operate any more.

All the following xcb submodules return 1.10. I don't know if they should return 1.12 or 1.13, but there will be something wrong.

xcb-composite, xcb-damage, xcb-dpms, xcb-dri2, xcb-dri3, xcb-glx, 
xcb-present, xcb-randr, xcb-record, xcb-render, xcb-res, xcb-screensaver, xcb-shape, xcb-shm, xcb-sync, xcb-xf86dri, xcb-xfixes, 
xcb-xinerama, xcb-xinput, xcb-xkb, xcb-xtest, xcb-xv, xcb-xvmc

>How-To-Repeat:
1. Install devel/pkgconf from pkgsrc.
2. Run pkg-config --modversion xcb-xinput.

And more:
3. make install x11/qt5-qtbase from pkgsrc.
4. make install graphics/krita and run krita, create a new canvas, and trty to draw any with mouse in canvas.
>Fix:

This is because PKGCONFIG_VERSION.${PKGCONFIG} in src/external/mit/xorg/lib/libxcb/xcb.mk was not changed when import libxcb v1.12 or v1.13.
This should be changed when import new version libxcb.

This value shoud be set automatically from PACKAGE_VERSION in files/config.h rather than manually, but 'm sorry I do not know how to this.

netbsd-8:

diff --git a/external/mit/xorg/lib/libxcb/xcb.mk b/external/mit/xorg/lib/libxcb/xcb.mk
index 982f91279280..0899da6902b9 100644
--- a/external/mit/xorg/lib/libxcb/xcb.mk
+++ b/external/mit/xorg/lib/libxcb/xcb.mk
@@ -18,7 +18,7 @@ SHLIB_MAJOR?= 0
 SHLIB_MINOR?=  1

 PKGCONFIG=     xcb-${XCBEXT}
-PKGCONFIG_VERSION.${PKGCONFIG}=     1.10
+PKGCONFIG_VERSION.${PKGCONFIG}=     1.12

 .include <bsd.x11.mk>
 .include <bsd.lib.mk>


current:

diff --git a/external/mit/xorg/lib/libxcb/xcb.mk b/external/mit/xorg/lib/libxcb/xcb.mk
index 982f91279280..7e4ed2389255 100644
--- a/external/mit/xorg/lib/libxcb/xcb.mk
+++ b/external/mit/xorg/lib/libxcb/xcb.mk
@@ -18,7 +18,7 @@ SHLIB_MAJOR?= 0
 SHLIB_MINOR?=  1

 PKGCONFIG=     xcb-${XCBEXT}
-PKGCONFIG_VERSION.${PKGCONFIG}=     1.10
+PKGCONFIG_VERSION.${PKGCONFIG}=     1.13

 .include <bsd.x11.mk>
 .include <bsd.lib.mk>

>Release-Note:

>Audit-Trail:
From: coypu@sdf.org
To: gnats-bugs@netbsd.org
Cc: mrg@netbsd.org
Subject: Re: xsrc/54249: pkg-conf ig --modversion xcb-xinput returns wrong
 version string.
Date: Wed, 29 May 2019 13:13:33 +0000

 Proposing this diff to pick it up automagically:

 Index: xcb.mk
 ===================================================================
 RCS file: /cvsroot/src/external/mit/xorg/lib/libxcb/xcb.mk,v
 retrieving revision 1.4
 diff -u -r1.4 xcb.mk
 --- xcb.mk	3 Feb 2015 21:31:31 -0000	1.4
 +++ xcb.mk	29 May 2019 13:13:22 -0000
 @@ -17,8 +17,8 @@
  SHLIB_MAJOR?=	0
  SHLIB_MINOR?=	1

 -PKGCONFIG=	xcb-${XCBEXT}
 -PKGCONFIG_VERSION.${PKGCONFIG}=     1.10
 +PKGCONFIG=		xcb-${XCBEXT}
 +PKGDIST.xcb-${XCBEXT}=	${X11SRCDIR.xcb}

  .include <bsd.x11.mk>
  .include <bsd.lib.mk>

State-Changed-From-To: open->needs-pullups
State-Changed-By: maya@NetBSD.org
State-Changed-When: Wed, 29 May 2019 13:18:34 +0000
State-Changed-Why:
Will pullup to netbsd-8 (will take a while to test, though!)


From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54249 CVS commit: src/external/mit/xorg/lib/libxcb
Date: Wed, 29 May 2019 13:15:53 +0000

 Module Name:	src
 Committed By:	maya
 Date:		Wed May 29 13:15:53 UTC 2019

 Modified Files:
 	src/external/mit/xorg/lib/libxcb: xcb.mk

 Log Message:
 Pick up xcb pkgconfig version automagically from the configure script
 PACKAGE_VERSION.

 We have failed to update it for netbsd-8 and netbsd-current, resulting
 in fallout in pkgsrc, reported by Yasushi Oshima in PR xsrc/54249.


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 src/external/mit/xorg/lib/libxcb/xcb.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: matthew green <mrg@eterna.com.au>
To: coypu@sdf.org
Cc: gnats-bugs@netbsd.org
Subject: re: xsrc/54249: pkg-conf ig --modversion xcb-xinput returns wrong version string.
Date: Thu, 30 May 2019 04:14:33 +1000

 coypu@sdf.org writes:
 > Proposing this diff to pick it up automagically:
 > 
 > Index: xcb.mk
 > ===================================================================
 > RCS file: /cvsroot/src/external/mit/xorg/lib/libxcb/xcb.mk,v
 > retrieving revision 1.4
 > diff -u -r1.4 xcb.mk
 > --- xcb.mk	3 Feb 2015 21:31:31 -0000	1.4
 > +++ xcb.mk	29 May 2019 13:13:22 -0000
 > @@ -17,8 +17,8 @@
 >  SHLIB_MAJOR?=	0
 >  SHLIB_MINOR?=	1
 >  
 > -PKGCONFIG=	xcb-${XCBEXT}
 > -PKGCONFIG_VERSION.${PKGCONFIG}=     1.10
 > +PKGCONFIG=		xcb-${XCBEXT}
 > +PKGDIST.xcb-${XCBEXT}=	${X11SRCDIR.xcb}

 LGTM. thanks!

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54249 CVS commit: [netbsd-8] src/external/mit/xorg/lib/libxcb
Date: Fri, 31 May 2019 08:08:25 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Fri May 31 08:08:25 UTC 2019

 Modified Files:
 	src/external/mit/xorg/lib/libxcb [netbsd-8]: xcb.mk

 Log Message:
 Pull up following revision(s) (requested by maya in ticket #1277):

 	external/mit/xorg/lib/libxcb/xcb.mk: revision 1.5

 Pick up xcb pkgconfig version automagically from the configure script
 PACKAGE_VERSION.

 We have failed to update it for netbsd-8 and netbsd-current, resulting
 in fallout in pkgsrc, reported by Yasushi Oshima in PR xsrc/54249.


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.4.8.1 src/external/mit/xorg/lib/libxcb/xcb.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: needs-pullups->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Fri, 31 May 2019 14:13:04 +0000
State-Changed-Why:
Pulled up. thanks for the report!


>Unformatted:

Home	PR Database Search