NetBSD Problem Report #54280

From www@netbsd.org  Thu Jun  6 20:37:55 2019
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 463DB7A177
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  6 Jun 2019 20:37:55 +0000 (UTC)
Message-Id: <20190606203754.296CE7A1C2@mollari.NetBSD.org>
Date: Thu,  6 Jun 2019 20:37:54 +0000 (UTC)
From: jperkins+netbsd@google.com
Reply-To: jperkins+netbsd@google.com
To: gnats-bugs@NetBSD.org
Subject: libedit: rl_completer_quote_characters should be const for readline compatibility
X-Send-Pr-Version: www-1.0

>Number:         54280
>Category:       lib
>Synopsis:       libedit: rl_completer_quote_characters should be const for readline compatibility
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jun 06 20:40:00 +0000 2019
>Last-Modified:  Fri Jun 07 15:20:02 +0000 2019
>Originator:     Jonathan Perkins
>Release:        Sources as of 2019/06/06
>Organization:
Google
>Environment:
>Description:
For compatibility with readline:
extern char		*rl_completer_quote_characters;
should be
extern const char	*rl_completer_quote_characters;
>How-To-Repeat:

>Fix:
--- old/libedit/readline/readline.h
+++ new/libedit/readline/readline.h
@@ -108,7 +108,7 @@ extern int		 history_base, history_lengt
 extern int		 max_input_history;
 extern const char	*rl_basic_word_break_characters;
 extern char		*rl_completer_word_break_characters;
-extern char		*rl_completer_quote_characters;
+extern const char	*rl_completer_quote_characters;
 extern rl_compentry_func_t *rl_completion_entry_function;
 extern char		*(*rl_completion_word_break_hook)(void);
 extern rl_completion_func_t *rl_attempted_completion_function;
--- old/libedit/readline.c
+++ new/libedit/readline.c
@@ -107,7 +107,7 @@ int rl_inhibit_completion = 0;
 int rl_attempted_completion_over = 0;
 const char *rl_basic_word_break_characters = break_chars;
 char *rl_completer_word_break_characters = NULL;
-char *rl_completer_quote_characters = NULL;
+const char *rl_completer_quote_characters = NULL;
 rl_compentry_func_t *rl_completion_entry_function = NULL;
 char *(*rl_completion_word_break_hook)(void) = NULL;
 rl_completion_func_t *rl_attempted_completion_function = NULL;

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54280 CVS commit: src/lib/libedit
Date: Fri, 7 Jun 2019 11:19:29 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Fri Jun  7 15:19:29 UTC 2019

 Modified Files:
 	src/lib/libedit: readline.c
 	src/lib/libedit/readline: readline.h

 Log Message:
 PR/54280: rl_completer_quote_characters should be const for readline compat


 To generate a diff of this commit:
 cvs rdiff -u -r1.153 -r1.154 src/lib/libedit/readline.c
 cvs rdiff -u -r1.45 -r1.46 src/lib/libedit/readline/readline.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Home	PR Database Search