NetBSD Problem Report #54572

From www@netbsd.org  Wed Sep 25 14:04:13 2019
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 92D1F7A21F
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 25 Sep 2019 14:04:13 +0000 (UTC)
Message-Id: <20190925140412.D3BF67A23A@mollari.NetBSD.org>
Date: Wed, 25 Sep 2019 14:04:13 +0000 (UTC)
From: ef@math.uni-bonn.de
Reply-To: ef@math.uni-bonn.de
To: gnats-bugs@NetBSD.org
Subject: RFC number typo in tcp_input() comment
X-Send-Pr-Version: www-1.0

>Number:         54572
>Category:       kern
>Synopsis:       RFC number typo in tcp_input() comment
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jnemeth
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 25 14:05:00 +0000 2019
>Closed-Date:    Wed Sep 25 19:07:43 +0000 2019
>Last-Modified:  Wed Sep 25 19:10:01 +0000 2019
>Originator:     Edgar Fuß
>Release:        8.1
>Organization:
Mathematisches Istitut der Universität Bonn
>Environment:
>Description:
A comment in tcp_input() (in sys/netinet/tcp_input.c) reads:

/*
 * Since we've covered the SYN-SENT and SYN-RECEIVED states above
 * we must be in a synchronized state.  RFC791 states (under RST
 * generation) that any unacceptable segment (an out-of-order SYN
 * qualifies) received in a synchronized state must elicit only an
 * empty acknowledgment segment ... and the connection remains in
 * the same state.
 */

Of course, that's 793, not 791 (and "Reset" is spelled out in the RFC section header).
>How-To-Repeat:
 cat sys/netinet/tcp_input.c
>Fix:
s/791/793/
s/RST generation/Reset Generation/

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->jnemeth
Responsible-Changed-By: jnemeth@NetBSD.org
Responsible-Changed-When: Wed, 25 Sep 2019 19:07:43 +0000
Responsible-Changed-Why:
I fixed it.


State-Changed-From-To: open->closed
State-Changed-By: jnemeth@NetBSD.org
State-Changed-When: Wed, 25 Sep 2019 19:07:43 +0000
State-Changed-Why:
Fixed.  Thanks for the PR.


From: "John Nemeth" <jnemeth@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54572 CVS commit: src/sys/netinet
Date: Wed, 25 Sep 2019 19:06:31 +0000

 Module Name:	src
 Committed By:	jnemeth
 Date:		Wed Sep 25 19:06:30 UTC 2019

 Modified Files:
 	src/sys/netinet: tcp_input.c

 Log Message:
 PR/54572 - Edgar Fuß -- error in comment


 To generate a diff of this commit:
 cvs rdiff -u -r1.415 -r1.416 src/sys/netinet/tcp_input.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search