NetBSD Problem Report #54695
From www@netbsd.org Tue Nov 12 19:59:05 2019
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 2F2087A187
for <gnats-bugs@gnats.NetBSD.org>; Tue, 12 Nov 2019 19:59:05 +0000 (UTC)
Message-Id: <20191112195904.46C0E7A26E@mollari.NetBSD.org>
Date: Tue, 12 Nov 2019 19:59:04 +0000 (UTC)
From: germain@lanvaux.fr
Reply-To: germain@lanvaux.fr
To: gnats-bugs@NetBSD.org
Subject: MLDonkey Does Not Build
X-Send-Pr-Version: www-1.0
>Number: 54695
>Category: pkg
>Synopsis: MLDonkey Does Not Build
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: jaapb
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Nov 12 20:00:00 +0000 2019
>Last-Modified: Sat May 09 06:40:01 +0000 2020
>Originator: Germain
>Release: HEAD
>Organization:
Lanvaux
>Environment:
NetBSD germ 8.99.51 NetBSD 8.99.51 (GENERIC) #2: Thu Jul 18 16:25:29 PDT 2019 german@germ:/home/german/work/netbsd/src/sys/arch/amd64/compile/obj/GENERIC amd64
g
>Description:
net/mldonkey doesn't build any longer.
It is since OCaml got updated. It compiles only with a specific revision range of the ,well, compiler (http://mldonkey.sourceforge.net/phpBB2/viewtopic.php?p=32707)
>How-To-Repeat:
Sync to the latest pkgsrc and build mldonkey
>Fix:
The only way I can think of now is to keep a specific revision of ocaml in pkgsrc and use that for mldonkey ?
I don't know if there is such a thing as temporary installing a particular revision of the toolchain if it is missing or the one present is known to not be compatible.
(I was looking in the nifty pkgsrc guide but was a little thrown off by how the bookmark table lists two entries for each chapters :])
Alternatively, as per the link enclosed in the problem full description, an updated build presumably containing fixes is about to be cut upstream.
>Release-Note:
>Audit-Trail:
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/54695: MLDonkey Does Not Build
Date: Thu, 14 Nov 2019 19:01:28 +0000
On Tue, Nov 12, 2019 at 08:00:00PM +0000, germain@lanvaux.fr wrote:
> >Description:
> net/mldonkey doesn't build any longer.
I'm aware of that. If you check the change history, a year and a half
ago I committed thus:
: Partial build fixes for ocaml 4.06.
:
: not at all clear this thing is worth the trouble...
Do you use mldonkey? Is it worth patching harder? When I did the above
it seemed pretty dead upstream, it had been broken for some time, and
it wasn't clear that anyone was using it.
One of the various downsides of using ocaml is that one has to keep up
with changes to the language. In this case the problem is that the
behavior of strings has changed, and after some years of just issuing
warnings the compiler changes started causing errors.
Telling the compiler to revert to the old behavior will not work
forever -- the code needs to be updated, and if done properly and in
full will then work on old ocaml versions as well
> (I was looking in the nifty pkgsrc guide but was a little thrown
> off by how the bookmark table lists two entries for each chapters
> :])
This sounds like something you should file a separate PR on ;-)
> Alternatively, as per the link enclosed in the problem full
> description, an updated build presumably containing fixes is about
> to be cut upstream.
Let me know when it's out. If you would like to prepare an update,
that'd be great.
--
David A. Holland
dholland@netbsd.org
From: Germain Le Chapelain <germain@lanvaux.fr>
To: gnats-bugs@netbsd.org
Cc: David Holland <dholland-pbugs@netbsd.org>, pkg-manager@netbsd.org,
gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org, Jaap Boender
<jaapb@kerguelen.org>
Subject: Re: pkg/54695: MLDonkey Does Not Build
Date: Thu, 14 Nov 2019 12:08:10 -0800
Thank you so much for attending my problem David!
On Thu, 14 Nov 2019 19:05:02 +0000 (UTC)
David Holland <dholland-pbugs@netbsd.org> wrote:
> Do you use mldonkey? Is it worth patching harder? When I did the above
> it seemed pretty dead upstream, it had been broken for some time, and
> it wasn't clear that anyone was using it.
No, MLDonkey is not dead. I was wondering the same:
I had been using it for nearly a decade straight.
I barely update (neither the OS nor the packages.)
I think I did it once and that very same problem already happened (and triggered your change. Thank you for that again btw!)
I think the software is just done (I.e. completed.) It does everything it needs to do.
What's not is OCaml, and that I have a vibe it never will be.
> One of the various downsides of using ocaml
Yes, I don't know what to say.
Interesting problem indeed :) :) Bc the language definitely serves a purpose for which it is unique:
It is like the C of functional languages (or more so C++.)
> > ...
>
> This sounds like something you should file a separate PR on ;-)
I will. I am staggering my PRs. ;)
> Let me know when it's out. If you would like to prepare an update,
> that'd be great.
I will ! As well as keeping on taking a look at what I can do (since I am obviously the one guy using MLDonkey from pkgsrc):
MLDonkey guy also said Debian uses his own Github as their source (as opposed to the release from the MLDonkey project's Github.)
I *think* we can make pkgsrc tap into that.
Kind regards,
Germain
(I included Jaap who had replied on the thread in NetBSD-users)
--
Germain Le Chapelain <germain.lechapelain@lanvaux.fr>
Software Engineer
Lanvaux
From: Germain Le Chapelain <germain.lechapelain@lanvaux.fr>
To: gnats-bugs@netbsd.org
Cc: Germain Le Chapelain <germain@lanvaux.fr>, pkg-manager@netbsd.org,
gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/54695: MLDonkey Does Not Build
Date: Tue, 28 Jan 2020 10:44:02 -0800
This is a multi-part message in MIME format.
--Multipart=_Tue__28_Jan_2020_10_44_02_-0800_eFx0TcF/gaQ7sunK
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
On Thu, 14 Nov 2019 20:20:01 +0000 (UTC)
Germain Le Chapelain <germain@lanvaux.fr> wrote:
> > Let me know when it's out. If you would like to prepare an update,
> > that'd be great.
>
> I will ! As well as keeping on taking a look at what I can do (since I am obviously the one guy using MLDonkey from pkgsrc):
Alright so enclosed is what I got, but it works only for caml 4.08, so I had to manually downgrade /usr/pkgsrc/*/*caml* to before the upgrade to 4.09 to get it to work
I had cut a new release of mldonkey myself on my own GitHUB. Thereof the patches were no longer required (I think?)
I also started looking at what Ocaml 4.09 broke, and it appears that the content of the `config' folders should be updated to use camlp5 over camlp4,
but presumably other changes are needed.
I will ask OCaml why they make breaking changes in minor release
Meanwhile I cannot come up with better than creating `OCaml4.08' specific folders in pkgsrc.
This really isn't great.
Germain
--
Germain Le Chapelain <germain.lechapelain@lanvaux.fr>
Software Engineer
Lanvaux
--Multipart=_Tue__28_Jan_2020_10_44_02_-0800_eFx0TcF/gaQ7sunK
Content-Type: application/octet-stream;
name="diff"
Content-Disposition: attachment;
filename="diff"
Content-Transfer-Encoding: base64
SW5kZXg6IE1ha2VmaWxlLmNvbW1vbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zzcm9vdC9wa2dz
cmMvbmV0L21sZG9ua2V5L01ha2VmaWxlLmNvbW1vbix2CnJldHJpZXZpbmcgcmV2aXNpb24gMS41
MwpkaWZmIC11IC1yMS41MyBNYWtlZmlsZS5jb21tb24KLS0tIE1ha2VmaWxlLmNvbW1vbgkxOCBK
YW4gMjAyMCAyMzozMzoxOCAtMDAwMAkxLjUzCisrKyBNYWtlZmlsZS5jb21tb24JMjggSmFuIDIw
MjAgMTc6MTc6NTQgLTAwMDAKQEAgLTMsOSArMywxMSBAQAogIyB1c2VkIGJ5IG5ldC9tbGRvbmtl
eS9NYWtlZmlsZQogIyB1c2VkIGJ5IG5ldC9tbGRvbmtleS1ndWkvTWFrZWZpbGUKIAotRElTVE5B
TUU9CW1sZG9ua2V5LTMuMS41CitESVNUTkFNRT0JbWxkb25rZXktMy4xLjcKK0dJVEhVQl9SRUxF
QVNFPSAzLjEuNwogQ0FURUdPUklFUz0JbmV0Ci1NQVNURVJfU0lURVM9CSR7TUFTVEVSX1NJVEVf
U09VUkNFRk9SR0U6PW1sZG9ua2V5L30KK01BU1RFUl9TSVRFUz0JJHtNQVNURVJfU0lURV9HSVRI
VUI6PWdsZWNoYXBlbGFpbi99CitHSVRIVUJfUFJPSkVDVD0gbWxkb25rZXkKIEVYVFJBQ1RfU1VG
WD0JLnRhci5iejIKIAogTUFJTlRBSU5FUj0JcGtnc3JjLXVzZXJzQE5ldEJTRC5vcmcKSW5kZXg6
IGRpc3RpbmZvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L3BrZ3NyYy9uZXQvbWxkb25r
ZXkvZGlzdGluZm8sdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNjUKZGlmZiAtdSAtcjEuNjUgZGlz
dGluZm8KLS0tIGRpc3RpbmZvCTE0IE1hciAyMDE4IDE0OjA1OjM3IC0wMDAwCTEuNjUKKysrIGRp
c3RpbmZvCTI4IEphbiAyMDIwIDE3OjE3OjU0IC0wMDAwCkBAIC0xLDQzICsxLDYgQEAKICROZXRC
U0Q6IGRpc3RpbmZvLHYgMS42NSAyMDE4LzAzLzE0IDE0OjA1OjM3IGRob2xsYW5kIEV4cCAkCiAK
LVNIQTEgKG1sZG9ua2V5LTMuMS41LnRhci5iejIpID0gN2JjNGY5MjcyZWNmZTY0MDNlZWY3MDYy
NzY2YjI2YmYzMjFlMzAxNQotUk1EMTYwIChtbGRvbmtleS0zLjEuNS50YXIuYnoyKSA9IDYzYTIx
YWVmNDdhNzUxMGI3Zjk4Njc1NDQzNDVjOGYwM2VkYzg5YzMKLVNIQTUxMiAobWxkb25rZXktMy4x
LjUudGFyLmJ6MikgPSA5NmU3NWFjZjkxZDdlY2M0MTQ5MGY4OThlMDZkMjg0ZGEyNzQwNGM3ZTU2
N2YxNzM5MzZkODExMzg4NWEzYjRiNmJjOTMzNDEzNThmOTJhMzBkM2Y2OTllZWY2ODFkOTdjZTU2
NDE0YTM3YmIwMmE1MzVhZDJkYTRkNGFkMTNhMwotU2l6ZSAobWxkb25rZXktMy4xLjUudGFyLmJ6
MikgPSAyODQ3MzgyIGJ5dGVzCi1TSEExIChwYXRjaC1jb25maWdfTWFrZWZpbGUuaW4pID0gODRm
MjM1ZjdhZDRlNmE5Y2RlYzgwN2EyNGQzZjExZjc2OWEwMTM5OQotU0hBMSAocGF0Y2gtY29uZmln
X2NvbmZpZ3VyZS5pbikgPSAwZjE4Nzc1NGQ1OTBhNTY1YjIyZWY0MDIzNTFkYmUxOGM0NTZhOGM1
Ci1TSEExIChwYXRjaC1zcmNfY29uZmlnX3VuaXhfb3Nfc3R1YnMuYy5jKSA9IDZhYmU4ZWY5YTA0
MGJlMDcxNmUzZDZjODhiNDg3NjRiNmRkN2VkNTUKLVNIQTEgKHBhdGNoLXNyY19uZXR3b3Jrc19k
b25rZXlfZG9ua2V5R2xvYmFscy5tbCkgPSA1ZjBiMzYyMTNiNmU2MTg1MDc3Y2Q1YzhkODJiMzE0
YjFjNTBjOGMyCi1TSEExIChwYXRjaC1zcmNfdXRpbHNfY2RrX2J6aXAyLm1sKSA9IDc3ZjdiOTZh
MTI5MzBkZjM4NDNjMzhiYWE2OWE5MGFkNzNhMjZmOGQKLVNIQTEgKHBhdGNoLXNyY191dGlsc19j
ZGtfYnppcDIubWxpKSA9IGM1NGZjZjMzNTQxYWRhNTI1ZDMzZDY0ODVhOTM2MmJiMWNiNWM4Y2YK
LVNIQTEgKHBhdGNoLXNyY191dGlsc19jZGtfYnpsaWIubWwpID0gZmQxM2UxNTNkNDg0ZWQ2ZDA3
ZGZlYWFmNWUxOTU2MGNhYzkyZTBhMgotU0hBMSAocGF0Y2gtc3JjX3V0aWxzX2Nka19iemxpYi5t
bGkpID0gMjA1N2FlODQ3OTg1MWFkNDliNWZkNTYzMGU1MWM2M2Y1YzNkMDhmMwotU0hBMSAocGF0
Y2gtc3JjX3V0aWxzX2Nka19maWxlbmFtZTIubWwpID0gMDhjMWRhMTZlZTE4YzMyYjJlZmU0MzQy
MDMwMDU0YThlMzk2OTYwYgotU0hBMSAocGF0Y2gtc3JjX3V0aWxzX2Nka19nZHN0dWJzLmMpID0g
OWQ4ZWY4MWZjZjM1MTVhYjUzMzc3NjlhZWYxMmM2YWFjYmI0ZWI4MQotU0hBMSAocGF0Y2gtc3Jj
X3V0aWxzX2Nka19nZW5sZXgyLm1sKSA9IDY3OTU1NDE3OGVmNjQxYWU1NzM1MjM1OTllY2IwNTg3
YzRjZWZiNzgKLVNIQTEgKHBhdGNoLXNyY191dGlsc19jZGtfZ3ppcC5tbCkgPSBjMDQ0ZTE1ZGY2
NDVmMzI2MjY2NGNhMTM2ZmRkYWJmN2U1ZTJhMGQxCi1TSEExIChwYXRjaC1zcmNfdXRpbHNfY2Rr
X2d6aXAubWxpKSA9IDllYWVmMGNmYWUzODQ0NzQyY2ExNGExYWNhM2M5MDBhZTIyZTgxM2MKLVNI
QTEgKHBhdGNoLXNyY191dGlsc19jZGtfc3RyaW5nMi5tbCkgPSA4ZjczZjliZTY5OWRmYTkyZTIz
NjBjMWNlOTRiMjZkNGQ1ZTFlNjJjCi1TSEExIChwYXRjaC1zcmNfdXRpbHNfY2RrX3N0cmluZzIu
bWxpKSA9IDVlZDVjZGM2ZmIxMmI5NjRiYjY1ZDg2MWEzMzkwMWU5ZWM2OGQ1MDQKLVNIQTEgKHBh
dGNoLXNyY191dGlsc19jZGtfdGFyLm1sY3BwKSA9IDc1ZTJjYWI1ZDFlM2QxZTg4MGExM2JkMGY3
YjJlMjlmN2MwY2EyYmUKLVNIQTEgKHBhdGNoLXNyY191dGlsc19jZGtfdW5peDIubWwpID0gMzg5
M2RlM2Q3MDcwNGZjNjI1YjZjYjJlMmU0MDU5MTFiOTJhMzJhYgotU0hBMSAocGF0Y2gtc3JjX3V0
aWxzX2Nka196aXAubWwpID0gYTg3NTA1M2E5MGM5MTFlMmYwN2ZjZmM3NWFhMzA3ZTZiYTdjZDVi
NAotU0hBMSAocGF0Y2gtc3JjX3V0aWxzX2Nka196bGliLm1sKSA9IGEyYWQzY2RkZTM3ZmU5ZWUz
MjljMWU5MTkzZTc3NDRiZGExNjdhNGEKLVNIQTEgKHBhdGNoLXNyY191dGlsc19jZGtfemxpYi5t
bGkpID0gYmY2MTI1ZTE4MTJlY2U3NWQ0OGVlM2E3ZmRhODhlZjlmMTcyYmQyNgotU0hBMSAocGF0
Y2gtc3JjX3V0aWxzX2Nka196bGlic3R1YnMuYykgPSBjZDAwNTkwM2YwNTBlMmM5ZmVlMWY3NDVh
ZGE0MGY1ZGFkMmUzOTg1Ci1TSEExIChwYXRjaC1zcmNfdXRpbHNfZXh0bGliX0lPLm1sKSA9IDhk
ODg5Yzg4MzQ1YmE1ZTYyMjIwMDU1ODc2MGIyMjFhYmRlNGFiN2EKLVNIQTEgKHBhdGNoLXNyY191
dGlsc19leHRsaWJfSU8ubWxpKSA9IDhmNDFiMjBhYTc2MmY3YmEyMmZlYzk1ODg2MjAxNWY4MWFk
YzI5NTIKLVNIQTEgKHBhdGNoLXNyY191dGlsc19saWJfZnN0X2hhc2guYykgPSBjOTY5OTlhMDlk
MzkyMjkzZmM2ZGM5OTdmM2EyZDU0NjViZDJlOGQ4Ci1TSEExIChwYXRjaC1zcmNfdXRpbHNfbGli
X21kNC5tbCkgPSAzZDI4M2QwMWZmMWE5NWNiMjg5M2I1MmJjY2VmZDYzZDFjMjhmNmM2Ci1TSEEx
IChwYXRjaC1zcmNfdXRpbHNfbGliX21kNC5tbGkpID0gYWQ2YzQwODVmNmVmODAzZTBlOTdiZTE1
YWQ3MzgwYmM2ZjI0NTU1ZQotU0hBMSAocGF0Y2gtc3JjX3V0aWxzX2xpYl9taXNjLm1sKSA9IDk0
N2E4ZjI0ZDFlYTJhMDViOGE4M2QyZDdkYTg0YzdmOWQ5OTE2MDIKLVNIQTEgKHBhdGNoLXNyY191
dGlsc19saWJfbWlzYzIubWxjcHApID0gMDc3ZGU2ODI5YTBkNzM2NzM1MmM1YjZlYTU1NjJjNDJl
NDQxYTM5NgotU0hBMSAocGF0Y2gtc3JjX3V0aWxzX2xpYl9vcHRpb25zLm1sNCkgPSBhYTdhNzUy
Zjg5NGEwOWQyYTFmZTNmNjllMTc5NmQ1NjBmMjQxZTI0Ci1TSEExIChwYXRjaC1zcmNfdXRpbHNf
bGliX29zX3N0dWJzLmgpID0gYTY3MDc4MjkzMTFjNDZkZDU5OGQyNjljNDY1YTAyZjBmYThmYzcw
MQotU0hBMSAocGF0Y2gtc3JjX3V0aWxzX2xpYl9zeXNsb2cubWwpID0gZTM5OTNlNmEzYTAwOGJj
N2U1MmViNDE0ZTk4MGFmYjQxNjU4ZGFmYgotU0hBMSAocGF0Y2gtc3JjX3V0aWxzX2xpYl90aWdl
ci5jKSA9IGQ0YjNiOWEzZGUwYTY0ZGVlNDQyOTExYTRkOWIzMGQwNzUwOTFhN2UKLVNIQTEgKHBh
dGNoLXNyY191dGlsc19saWJfdW5peDMyLm1sKSA9IDgxZjRiMTVlY2U1NTNiYjdhNDZhMDQ2MDI2
YmIzZDJmNzRkNWQyYjIKLVNIQTEgKHBhdGNoLXNyY191dGlsc19saWJfdW5peDMyLm1saSkgPSAz
OWFlODM4NWYyYjQzYmNiOTYxNDc2YzYzOWFjZmJhY2U0Nzc0MTk3Ci1TSEExIChwYXRjaC1zcmNf
dXRpbHNfbGliX3VybC5tbCkgPSBhYTExOTQ5OTdmNDRlNzQzN2FkYTMwMTIwNTg0NTU5NjRjNDU3
M2YyCi1TSEExIChwYXRjaC1zcmNfdXRpbHNfbGliX3ZlcmlmaWNhdGlvbkJpdG1hcC5tbCkgPSBm
OGQ3YWYwZWZmMTY3NGNhODNhOThhODAwZTUzZTJhNDFkYTk5MjJhCi1TSEExIChwYXRjaC1zcmNf
dXRpbHNfbmV0X3Rlcm1pbmFsLm1sKSA9IGY2MDFlYTdmYWNjM2YzMWY5ZjI4ODU2N2EwOTRmYmQz
ZTFiZGE3MGMKK1NIQTEgKG1sZG9ua2V5LTMuMS43LnRhci5iejIpID0gY2I3MjY3NjBlOWNlNDNj
YTA3OWEyZTZmNjM2ZGFiMDMwYjBhYjM1MgorUk1EMTYwIChtbGRvbmtleS0zLjEuNy50YXIuYnoy
KSA9IGFiMmZkN2E2ZTk2OTg4NzNlNmNiNmU3NWNhYTYwN2Y5NzdmMjlmYzkKK1NIQTUxMiAobWxk
b25rZXktMy4xLjcudGFyLmJ6MikgPSBhZGUwY2MwMDliMzI4NzgzZTE2ZjgyZGYwNzAwY2U4Nzc0
NTAxYTQ0ZmI4ZDhhYjI3MThlYTRmNTIwOTMwNTFkMDFhM2M2YWI2Mzc1M2IzYmQyOGE3MTg5ZmI4
NTFmM2QzOGRiNzFmMDA5ZTQxMDE3ZDQ4NDljN2M1OWFhMGI2NAorU2l6ZSAobWxkb25rZXktMy4x
LjcudGFyLmJ6MikgPSAyNzQxMDIyIGJ5dGVzCg==
--Multipart=_Tue__28_Jan_2020_10_44_02_-0800_eFx0TcF/gaQ7sunK--
From: Germain Le Chapelain <germain.lechapelain@lanvaux.fr>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
germain@lanvaux.fr
Subject: Re: pkg/54695: MLDonkey Does Not Build
Date: Tue, 28 Jan 2020 10:51:38 -0800
On Tue, 28 Jan 2020 19:00:02 +0000 (UTC)
Germain Le Chapelain <germain.lechapelain@lanvaux.fr> wrote:
> Alright so enclosed is what I got, but it works only for caml 4.08, so I had to manually downgrade /usr/pkgsrc/*/*caml* to before the upgrade to 4.09 to get it to work
>
I don't know what happened with my attachment.
Here is the diff:
====>8====>8====
Index: Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/net/mldonkey/Makefile.common,v
retrieving revision 1.53
diff -u -r1.53 Makefile.common
--- Makefile.common 18 Jan 2020 23:33:18 -0000 1.53
+++ Makefile.common 28 Jan 2020 17:17:54 -0000
@@ -3,9 +3,11 @@
# used by net/mldonkey/Makefile
# used by net/mldonkey-gui/Makefile
-DISTNAME= mldonkey-3.1.5
+DISTNAME= mldonkey-3.1.7
+GITHUB_RELEASE= 3.1.7
CATEGORIES= net
-MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=mldonkey/}
+MASTER_SITES= ${MASTER_SITE_GITHUB:=glechapelain/}
+GITHUB_PROJECT= mldonkey
EXTRACT_SUFX= .tar.bz2
MAINTAINER= pkgsrc-users@NetBSD.org
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/net/mldonkey/distinfo,v
retrieving revision 1.65
diff -u -r1.65 distinfo
--- distinfo 14 Mar 2018 14:05:37 -0000 1.65
+++ distinfo 28 Jan 2020 17:17:54 -0000
@@ -1,43 +1,6 @@
$NetBSD: distinfo,v 1.65 2018/03/14 14:05:37 dholland Exp $
-SHA1 (mldonkey-3.1.5.tar.bz2) = 7bc4f9272ecfe6403eef7062766b26bf321e3015
-RMD160 (mldonkey-3.1.5.tar.bz2) = 63a21aef47a7510b7f9867544345c8f03edc89c3
-SHA512 (mldonkey-3.1.5.tar.bz2) = 96e75acf91d7ecc41490f898e06d284da27404c7e567f173936d8113885a3b4b6bc93341358f92a30d3f699eef681d97ce56414a37bb02a535ad2da4d4ad13a3
-Size (mldonkey-3.1.5.tar.bz2) = 2847382 bytes
-SHA1 (patch-config_Makefile.in) = 84f235f7ad4e6a9cdec807a24d3f11f769a01399
-SHA1 (patch-config_configure.in) = 0f187754d590a565b22ef402351dbe18c456a8c5
-SHA1 (patch-src_config_unix_os_stubs.c.c) = 6abe8ef9a040be0716e3d6c88b48764b6dd7ed55
-SHA1 (patch-src_networks_donkey_donkeyGlobals.ml) = 5f0b36213b6e6185077cd5c8d82b314b1c50c8c2
-SHA1 (patch-src_utils_cdk_bzip2.ml) = 77f7b96a12930df3843c38baa69a90ad73a26f8d
-SHA1 (patch-src_utils_cdk_bzip2.mli) = c54fcf33541ada525d33d6485a9362bb1cb5c8cf
-SHA1 (patch-src_utils_cdk_bzlib.ml) = fd13e153d484ed6d07dfeaaf5e19560cac92e0a2
-SHA1 (patch-src_utils_cdk_bzlib.mli) = 2057ae8479851ad49b5fd5630e51c63f5c3d08f3
-SHA1 (patch-src_utils_cdk_filename2.ml) = 08c1da16ee18c32b2efe4342030054a8e396960b
-SHA1 (patch-src_utils_cdk_gdstubs.c) = 9d8ef81fcf3515ab5337769aef12c6aacbb4eb81
-SHA1 (patch-src_utils_cdk_genlex2.ml) = 679554178ef641ae573523599ecb0587c4cefb78
-SHA1 (patch-src_utils_cdk_gzip.ml) = c044e15df645f3262664ca136fddabf7e5e2a0d1
-SHA1 (patch-src_utils_cdk_gzip.mli) = 9eaef0cfae3844742ca14a1aca3c900ae22e813c
-SHA1 (patch-src_utils_cdk_string2.ml) = 8f73f9be699dfa92e2360c1ce94b26d4d5e1e62c
-SHA1 (patch-src_utils_cdk_string2.mli) = 5ed5cdc6fb12b964bb65d861a33901e9ec68d504
-SHA1 (patch-src_utils_cdk_tar.mlcpp) = 75e2cab5d1e3d1e880a13bd0f7b2e29f7c0ca2be
-SHA1 (patch-src_utils_cdk_unix2.ml) = 3893de3d70704fc625b6cb2e2e405911b92a32ab
-SHA1 (patch-src_utils_cdk_zip.ml) = a875053a90c911e2f07fcfc75aa307e6ba7cd5b4
-SHA1 (patch-src_utils_cdk_zlib.ml) = a2ad3cdde37fe9ee329c1e9193e7744bda167a4a
-SHA1 (patch-src_utils_cdk_zlib.mli) = bf6125e1812ece75d48ee3a7fda88ef9f172bd26
-SHA1 (patch-src_utils_cdk_zlibstubs.c) = cd005903f050e2c9fee1f745ada40f5dad2e3985
-SHA1 (patch-src_utils_extlib_IO.ml) = 8d889c88345ba5e622200558760b221abde4ab7a
-SHA1 (patch-src_utils_extlib_IO.mli) = 8f41b20aa762f7ba22fec958862015f81adc2952
-SHA1 (patch-src_utils_lib_fst_hash.c) = c96999a09d392293fc6dc997f3a2d5465bd2e8d8
-SHA1 (patch-src_utils_lib_md4.ml) = 3d283d01ff1a95cb2893b52bccefd63d1c28f6c6
-SHA1 (patch-src_utils_lib_md4.mli) = ad6c4085f6ef803e0e97be15ad7380bc6f24555e
-SHA1 (patch-src_utils_lib_misc.ml) = 947a8f24d1ea2a05b8a83d2d7da84c7f9d991602
-SHA1 (patch-src_utils_lib_misc2.mlcpp) = 077de6829a0d7367352c5b6ea5562c42e441a396
-SHA1 (patch-src_utils_lib_options.ml4) = aa7a752f894a09d2a1fe3f69e1796d560f241e24
-SHA1 (patch-src_utils_lib_os_stubs.h) = a6707829311c46dd598d269c465a02f0fa8fc701
-SHA1 (patch-src_utils_lib_syslog.ml) = e3993e6a3a008bc7e52eb414e980afb41658dafb
-SHA1 (patch-src_utils_lib_tiger.c) = d4b3b9a3de0a64dee442911a4d9b30d075091a7e
-SHA1 (patch-src_utils_lib_unix32.ml) = 81f4b15ece553bb7a46a046026bb3d2f74d5d2b2
-SHA1 (patch-src_utils_lib_unix32.mli) = 39ae8385f2b43bcb961476c639acfbace4774197
-SHA1 (patch-src_utils_lib_url.ml) = aa1194997f44e7437ada3012058455964c4573f2
-SHA1 (patch-src_utils_lib_verificationBitmap.ml) = f8d7af0eff1674ca83a98a800e53e2a41da9922a
-SHA1 (patch-src_utils_net_terminal.ml) = f601ea7facc3f31f9f288567a094fbd3e1bda70c
+SHA1 (mldonkey-3.1.7.tar.bz2) = cb726760e9ce43ca079a2e6f636dab030b0ab352
+RMD160 (mldonkey-3.1.7.tar.bz2) = ab2fd7a6e9698873e6cb6e75caa607f977f29fc9
+SHA512 (mldonkey-3.1.7.tar.bz2) = ade0cc009b328783e16f82df0700ce8774501a44fb8d8ab2718ea4f52093051d01a3c6ab63753b3bd28a7189fb851f3d38db71f009e41017d4849c7c59aa0b64
+Size (mldonkey-3.1.7.tar.bz2) = 2741022 bytes
====8<====8<====
--
Germain Le Chapelain <germain.lechapelain@lanvaux.fr>
Software Engineer
Lanvaux
Responsible-Changed-From-To: pkg-manager->jaapb
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Mon, 03 Feb 2020 12:51:03 +0000
Responsible-Changed-Why:
Jaap, any opinion on those patches?
From: Germain Le Chapelain <germain.lechapelain@lanvaux.fr>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/54695 (MLDonkey Does Not Build)
Date: Mon, 3 Feb 2020 09:47:14 -0800
On Mon, 3 Feb 2020 12:51:04 +0000 (UTC)
bsiegert@NetBSD.org wrote:
> Jaap, any opinion on those patches?
It still doesn't work (requires an older OCaml) I was more sharing my progress
However the build as a mechanism to download `locally' OCaml 4.08
I think we should use that instead (for the reasons mentioned in my earlier reply,)
I have been trying to kick it locally with `CONFIGURE_ARGS+= --batch_enable=YES' but I get an error when it tries launching WGET :|
(If I launch the command myself, all the same as I expect it from the configure script, then it works)
Germain
--
Germain Le Chapelain <germain.lechapelain@lanvaux.fr>
Software Engineer
Lanvaux
From: Jaap Boender <jaapb@kerguelen.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/54695 (MLDonkey Does Not Build)
Date: Tue, 4 Feb 2020 11:41:09 +0100
It's a recurring problem with OCaml - software that isn't maintained
well goes out of date really quickly, usually with the next release of
OCaml.
This is a problem that needs to be solved upstream - ideally by having
OCaml stop breaking things at every release, but that's not going to
happen any time soon; therefore it is up to mldonkey to make sure they
stay current with new OCaml versions. I have the feeling that mldonkey
is a bit of a derelict project at the moment (from the discussion on the
forum, I don't see anything to contradict this).
I tend to update the OCaml version in pkgsrc when enough kinks have been
worked out, i.e. when not too much stuff breaks; this took a long time
for 4.08; for 4.09 there has been far less fallout and in fact I think
mldonkey is the first package that actually breaks in its latest version
(again seeming to confirm my impression that it's a bit derelict at the
moment).
I'm open to a different update policy (for example, defining a few
packages that have so many users that no update can be done unless these
packages compile - unison, I suppose, would be high on that list), but
that discussion probably shouldn't be held here.
OCaml doesn't deal well with mixing packages compiled by different
versions of the compiler, so I do feel that having multiple versions in
pkgsrc is asking for trouble. Downloading a version locally in one
package is not a wonderful solution either, for the same reasons.
For the current bug, therefore, I'd say that patching mldonkey to work
with 4.09 is the way to go, either upstream or in pkgsrc. (4.10 is
already on the way too - the beta version is in wip if you'd care to
have a look.)
From: coypu@sdf.org
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/54695 (MLDonkey Does Not Build)
Date: Tue, 4 Feb 2020 21:45:32 +0000
If this package is very important for you, but ocaml is difficult, I
wonder whether you can locally "vendor" an ocaml and the few
ocaml dependencies it needs.
Looking at how MLDonkey is a network-facing program, I wouldn't want to
be using it in this state, personally. There might be subtle network
security issues fixed in the dependencies.
From: Germain Le Chapelain <germain.lechapelain@lanvaux.fr>
To: gnats-bugs@netbsd.org
Cc: Jaap Boender <jaapb@kerguelen.org>, jaapb@netbsd.org,
gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org, germain@lanvaux.fr
Subject: Re: pkg/54695 (MLDonkey Does Not Build)
Date: Tue, 4 Feb 2020 16:20:11 -0800
On Tue, 4 Feb 2020 10:45:01 +0000 (UTC)
Jaap Boender <jaapb@kerguelen.org> wrote:
> It's a recurring problem with OCaml
I forgot to mention: my plan was to also bring it up on their forum.
In the form of a question, like in Jeopardy. =)
(The question being: `Why do you have breaking changes in-between minor revisions.'
I'll do so after reporting the duplicate TOC entries per chapter in the pkgsrc Manual PDF ;))
> [its] beta version is in wip if you'd care to
> have a look.)
That's the thing, though :I really don't.
And most respectfully too: I really dig what they are going for and everything.
But all I am in for here is downloading movies and animes.
There are sporadic updates to MLDonkey's Git [1]. Mainly aimed at fixing the build; as well as removing features that became irrelevant.
I think it's just edonkey and bittorrent which have fallen off popularity.
Whatever happened to sharing? I ask
Anyways, MLDonkey is pretty much the only headless option, and second overhall most popular on *Nix after aMule.
Anyways I will keep looking at fixing that batch mode for compiling OCaml locally in the configure script:
This will work as intended: if the user happens to have a compatible version of OCaml installed, it should use that, if not it will silently download and use a temporary one that's fit for MLDonkey. (at leasst I think.)
As a separate step, one could also update to work with 4.09 or even .10, as you suggest
I wonder if someone will on the upstream?
I am tempted to just wait and only bother the Caml people; and mldonkey if the patch to configure is relevant.
Kind regards,
Germain
--
Germain Le Chapelain <germain.lechapelain@lanvaux.fr>
Software Engineer
Lanvaux
[1] https://github.com/ygrek/mldonkey/commits/master
From: Jaap Boender <jaapb@kerguelen.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/54695 (MLDonkey Does Not Build)
Date: Wed, 5 Feb 2020 09:26:28 +0100
Not having read the original post thoroughly (apologies for that), I had
a look at updating mldonkey to the version from ygrek's GitHub
repository, and then I ran into a problem the OP already mentioned:
mldonkey needs Camlp4.
Camlp4 is considered obsolete; upstream reluctantly made it available
with 4.08, while making it VERY clear that there would not be an update
for 4.09 (or any future version of OCaml). So yes, mldonkey needs to be
updated to either use camlp5 or PPX. Neither of those things is likely
to be easy (camlp5 would be my bet for the easiest update, but that
would still need a moderate amount of nontrivial work).
At this point, there basically are three options:
1) Take charge of mldonkey upstream and get it in sync with the times
(even previous updates, like the unsafe-string patches have been quick
fixes rather than thorough overhauls, so this is likely to be
time-consuming; great way to learn OCaml, though...)
2) I'm not a fan, but at this point using opam might be an option - it
does have provision for keeping old versions of OCaml around and will
allow you to use mldonkey without too much hassle. No idea how well it
will play with pkgsrc, though, especially if you're using other OCaml
packages. (This is not likely to be a viable long term solution:
eventually mldonkey will stop working under opam too!)
3) Either keep a local copy of OCaml 4.08 around, as coypu suggests, or
use the local-download-solution that the OP suggests. Neither of these
will win any beauty prizes, but it's probably the only way to actually
get a pkgsrc-compiled version of mldonkey. (Needless to say, this not
really a viable long term solution either)
From a pkgsrc point of view, we may need to start thinking about
removing mldonkey entirely - upstream obviously hasn't been paying
attention for a while now, and unless the situation changes it's not
going to build any time soon. But that's a discussion for pkgsrc-users@.
From: Germain Le Chapelain <germain.lechapelain@lanvaux.fr>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/54695
Date: Fri, 8 May 2020 22:05:37 -0700
Hi!
It crashes on startup now:
2020/05/08 21:36:26 [DNS] Resolving [germ] ...
2020/05/08 21:36:26 [DNS] Resolving [www.mldonkey.org] ...
0 in alloc_host_entry
1 in unix_gethostbyname
2 in camlIp__make_entry_from_name_1176 of src/utils/net/ip.ml:172
3 in camlIp__get_entry_cached_1185 of src/utils/net/ip.ml:226
4 in camlIp__from_name_1198 of src/utils/net/ip.ml:240
5 in camlDriverMain__resolve_name_1142 of src/daemon/driver/driverMain.ml:378
6 in camlList__exists_1136 of list.ml:131
GDB is on line 390 of driverMain.ml:
in
let hostnames =
["www.mldonkey.org"; "mldonkey.sf.net"; "www.mldonkey.net"; "www.google.com"]
in
=> DriverInteractive.dns_works := List.exists resolve_name hostnames;
I can (and may) dig deeper by debugging in OCaml as well. I am rolling on the old one though, that OCaml auto-install: 4.01.0)
(Also, I have replied on misc/54954 but the bug is still on the `feedback-required' state.)
Kindest regards,
Germain
--
Germain Le Chapelain <germain.lechapelain@lanvaux.fr>
Software Engineer
Lanvaux
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home