NetBSD Problem Report #54740

From tsutsui@ceres.dti.ne.jp  Thu Dec  5 16:21:05 2019
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 28E8F7A188
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  5 Dec 2019 16:21:05 +0000 (UTC)
Message-Id: <201912051620.xB5GKt74004919@ceres.dti.ne.jp>
Date: Fri, 6 Dec 2019 01:20:55 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: syslogd(8) Could not open /dev/crypto: Device not configured
X-Send-Pr-Version: 3.95

>Number:         54740
>Category:       bin
>Synopsis:       syslogd(8) Could not open /dev/crypto: Device not configured
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    tsutsui
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Dec 05 16:25:00 +0000 2019
>Closed-Date:    Mon Dec 09 16:30:13 +0000 2019
>Last-Modified:  Sun Sep 13 15:55:01 +0000 2020
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0_RC1
>Organization:
>Environment:
System: NetBSD zaurus 9.0_RC1 NetBSD 9.0_RC1 (GENERIC)
Architecture: earm
Machine: zaurus, but affects all ports that don't have pseudo-device crypto
>Description:
On startup syslogd(8) started by /etc/rc.d/syslogd complains
Could not open /dev/crypto: Device not configured
on zaurus and dreamcast etc.

>How-To-Repeat:
start syslogd(8) on a kernel without pseudo-device crypto?

>Fix:
The message from openssl libcrypto,
src/crypto/external/bsd/openssl/dist/crypto/engine/eng_devcrypto.c ,
but there is a local change to suppress the message on ENOENT:
 http://cvsweb.netbsd.org/bsdweb.cgi/src/crypto/external/bsd/openssl/dist/crypto/engine/eng_devcrypto.c?annotate=1.4
---
1.3       christos  762:     if ((cfd = open("/dev/crypto", O_RDWR, 0)) < 0) {
1.4     ! christos  763: #ifndef ENGINE_DEVCRYPTO_DEBUG
        !           764:         if (errno != ENOENT)
        !           765: #endif
        !           766:             fprintf(stderr, "Could not open /dev/crypto: %s\n", strerror(errno));
1.1       christos  767:         return;
                    768:     }
---
but we should rather disable it on ENXIO?

---
Izumi Tsutsui

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54740 CVS commit: src/crypto/external/bsd/openssl/dist/crypto/engine
Date: Thu, 5 Dec 2019 12:52:06 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Thu Dec  5 17:52:06 UTC 2019

 Modified Files:
 	src/crypto/external/bsd/openssl/dist/crypto/engine: eng_devcrypto.c

 Log Message:
 PR/54740: Izumi Tsutsui: Disable cryptoengine unavailable message when
 device is not configured (ENXIO).


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 \
     src/crypto/external/bsd/openssl/dist/crypto/engine/eng_devcrypto.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: gnats-admin->tsutsui
Responsible-Changed-By: tsutsui@NetBSD.org
Responsible-Changed-When: Sat, 07 Dec 2019 19:34:46 +0000
Responsible-Changed-Why:
I've confirmed chiristos@'s fix on emips as a submitter.


State-Changed-From-To: open->needs-pullups
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Sat, 07 Dec 2019 19:34:46 +0000
State-Changed-Why:
I'll send a pullup request soon.


State-Changed-From-To: needs-pullups->pending-pullups
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Sat, 07 Dec 2019 19:47:31 +0000
State-Changed-Why:
[pullup-9 #530]


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54740 CVS commit: [netbsd-9] src/crypto/external/bsd/openssl/dist/crypto/engine
Date: Mon, 9 Dec 2019 16:02:37 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Mon Dec  9 16:02:37 UTC 2019

 Modified Files:
 	src/crypto/external/bsd/openssl/dist/crypto/engine [netbsd-9]:
 	    eng_devcrypto.c

 Log Message:
 Pull up following revision(s) (requested by tsutsui in ticket #530):

 	crypto/external/bsd/openssl/dist/crypto/engine/eng_devcrypto.c: revision 1.5

 PR/54740: Izumi Tsutsui: Disable cryptoengine unavailable message when
 device is not configured (ENXIO).


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.4.4.1 \
     src/crypto/external/bsd/openssl/dist/crypto/engine/eng_devcrypto.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Mon, 09 Dec 2019 16:30:13 +0000
State-Changed-Why:
Pulled up.


From: "Izumi Tsutsui" <tsutsui@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54740 CVS commit: src/crypto/external/bsd/openssl/dist/crypto/engine
Date: Sat, 12 Sep 2020 09:37:01 +0000

 Module Name:	src
 Committed By:	tsutsui
 Date:		Sat Sep 12 09:37:01 UTC 2020

 Modified Files:
 	src/crypto/external/bsd/openssl/dist/crypto/engine: eng_devcrypto.c

 Log Message:
 Restore a local change for PR/54740 lost during openssl 1.1.1e merge.

 syslogd(8) complains "Could not open /dev/crypto: Device not configured"
 again when pseudo-device crypto(4) is not configured in a kernel.
  http://cvsweb.netbsd.org/bsdweb.cgi/src/crypto/external/bsd/openssl/dist/crypto/engine/eng_devcrypto.c#rev1.5
  http://cvsweb.netbsd.org/bsdweb.cgi/src/crypto/external/bsd/openssl/dist/crypto/engine/eng_devcrypto.c#rev1.7

 Should be pullued up to netbsd-9.


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 \
     src/crypto/external/bsd/openssl/dist/crypto/engine/eng_devcrypto.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54740 CVS commit: [netbsd-9] src/crypto/external/bsd/openssl/dist/crypto/engine
Date: Sun, 13 Sep 2020 15:51:06 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sun Sep 13 15:51:06 UTC 2020

 Modified Files:
 	src/crypto/external/bsd/openssl/dist/crypto/engine [netbsd-9]:
 	    eng_devcrypto.c

 Log Message:
 Pull up following revision(s) (requested by tsutsui in ticket #1084):

 	crypto/external/bsd/openssl/dist/crypto/engine/eng_devcrypto.c: revision 1.8

 Restore a local change for PR/54740 lost during openssl 1.1.1e merge.
 syslogd(8) complains "Could not open /dev/crypto: Device not configured"
 again when pseudo-device crypto(4) is not configured in a kernel.

  http://cvsweb.netbsd.org/bsdweb.cgi/src/crypto/external/bsd/openssl/dist/crypto/engine/eng_devcrypto.c#rev1.5
  http://cvsweb.netbsd.org/bsdweb.cgi/src/crypto/external/bsd/openssl/dist/crypto/engine/eng_devcrypto.c#rev1.7

 Should be pullued up to netbsd-9.


 To generate a diff of this commit:
 cvs rdiff -u -r1.4.4.3 -r1.4.4.4 \
     src/crypto/external/bsd/openssl/dist/crypto/engine/eng_devcrypto.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search