NetBSD Problem Report #54836

From tsutsui@ceres.dti.ne.jp  Sun Jan  5 18:10:32 2020
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id C89907A1B3
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  5 Jan 2020 18:10:32 +0000 (UTC)
Message-Id: <202001051810.005IAMMG002175@ceres.dti.ne.jp>
Date: Mon, 6 Jan 2020 03:10:22 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: Wrong install binary set suffix in INSTALL notes
X-Send-Pr-Version: 3.95

>Number:         54836
>Category:       install
>Synopsis:       Wrong install binary set suffix in INSTALL notes
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    martin
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 05 18:15:00 +0000 2020
>Closed-Date:    Sun Jan 12 04:53:14 +0000 2020
>Last-Modified:  Sun Jan 12 04:53:14 +0000 2020
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0_RC1
>Organization:
>Environment:
System: NetBSD 9.0_RC1
Architecture: all
Machine: all but except amd64, sparc64, and alpha
>Description:
https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0_RC1/i386/INSTALL.html
https://cdn.netbsd.org/pub/NetBSD/NetBSD-9.0_RC1/sun3/INSTALL.html
etc. use ".tar.xz" for set names:
> You will at a minimum need one of the kernel sets, typically kern-GENERIC.tar.xz, as well as base.tar.xz and etc.tar.xz. In a typical workstation installation you will probably want all the installation sets. 
 :
>  The i386 binary distribution sets are distributed as gzipped tar files named with the extension .tar.xz, e.g. base.tar.xz. 

>  The sun3 binary distribution sets are distributed as gzipped tar files named with the extension .tar.xz, e.g. base.tar.xz. 

but they use .tgz for set names.

>How-To-Repeat:
See above.

>Fix:
Wrong .if condition in src/distrib/notes/Makefile.inc? (untested)

Index: Makefile.inc
===================================================================
RCS file: /cvsroot/src/distrib/notes/Makefile.inc,v
retrieving revision 1.52
diff -u -p -d -r1.52 Makefile.inc
--- Makefile.inc	30 Nov 2019 00:28:27 -0000	1.52
+++ Makefile.inc	5 Jan 2020 18:06:47 -0000
@@ -29,7 +29,7 @@ whatis: .OPTIONAL

 PRESET=	${GFLAGS} -U -dM=${M} -dV=${DISTRIBVER} -d.CURDIR=${.CURDIR} -r${M}=1
 PRESET+=	-rmajor=${DISTRIBVER:C/\..*$//}
-.if ${USE_XZ_SETS}
+.if ${USE_XZ_SETS} == "yes"
 PRESET+=	-dsetsuffix=tar.xz
 .else
 PRESET+=	-dsetsuffix=tgz


Definition in src/share/mk/bsd.own.mk:
---
# Default to USE_XZ_SETS on some 64bit architectures where decompressor
# memory will likely not be in short supply.
# Since pigz can not create .xz format files currently, disable .xz
# format if USE_PIGZGZIP is enabled.
.if ${USE_PIGZGZIP} == "no" && \
		(${MACHINE} == "amd64" || \
		 ${MACHINE} == "sparc64" || \
		 ${MACHINE} == "alpha")
USE_XZ_SETS?= yes
.else
USE_XZ_SETS?= no
.endif 
---

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: install-manager->martin
Responsible-Changed-By: martin@NetBSD.org
Responsible-Changed-When: Sun, 05 Jan 2020 18:40:23 +0000
Responsible-Changed-Why:
my bug


State-Changed-From-To: open->pending-pullups
State-Changed-By: martin@NetBSD.org
State-Changed-When: Sun, 05 Jan 2020 18:40:23 +0000
State-Changed-Why:
[pullup-9 #608]


From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54836 CVS commit: src/distrib/notes
Date: Sun, 5 Jan 2020 18:37:55 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Sun Jan  5 18:37:55 UTC 2020

 Modified Files:
 	src/distrib/notes: Makefile.inc

 Log Message:
 PR install/54836: fix broken conditional, passing the wrong set name suffix
 to groff.


 To generate a diff of this commit:
 cvs rdiff -u -r1.52 -r1.53 src/distrib/notes/Makefile.inc

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "SAITOH Masanobu" <msaitoh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54836 CVS commit: [netbsd-9] src/distrib/notes
Date: Wed, 8 Jan 2020 07:53:30 +0000

 Module Name:	src
 Committed By:	msaitoh
 Date:		Wed Jan  8 07:53:30 UTC 2020

 Modified Files:
 	src/distrib/notes [netbsd-9]: Makefile.inc

 Log Message:
 Pull up following revision(s) (requested by martin in ticket #608):
 	distrib/notes/Makefile.inc: revision 1.53
 PR install/54836: fix broken conditional, passing the wrong set name suffix
 to groff.


 To generate a diff of this commit:
 cvs rdiff -u -r1.43.18.5 -r1.43.18.6 src/distrib/notes/Makefile.inc

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Sun, 12 Jan 2020 04:53:14 +0000
State-Changed-Why:
Pulled up and confirmed in netbsd-9 daily snapshot.


>Unformatted:

Home	PR Database Search