NetBSD Problem Report #54921

From www@netbsd.org  Sun Feb  2 12:59:58 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id D074F1A9213
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  2 Feb 2020 12:59:58 +0000 (UTC)
Message-Id: <20200202125957.AE4D11A9228@mollari.NetBSD.org>
Date: Sun,  2 Feb 2020 12:59:57 +0000 (UTC)
From: isaki@pastel-flower.jp
Reply-To: isaki@pastel-flower.jp
To: gnats-bugs@NetBSD.org
Subject: sysinst partition editor fails on x68k/9.0_RC2
X-Send-Pr-Version: www-1.0

>Number:         54921
>Category:       install
>Synopsis:       sysinst partition editor fails on x68k/9.0_RC2
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    martin
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 02 16:38:23 +0000 2020
>Closed-Date:    Tue Feb 11 08:46:32 +0000 2020
>Last-Modified:  Tue Feb 11 08:46:32 +0000 2020
>Originator:     Tetsuya Isaki
>Release:        NetBSD-9.0_RC2
>Organization:
>Environment:
NetBSD 9.0_RC2 x68k
>Description:
sysinst partition editor fails on x68k/9.0_RC2, and it has two problems.

1. x68k's partition editor displayed incomplete error message:

   | The order of partition  is wrong.  Edit again?

  It should be %s ?
  (arch/mvme68k/msg.md.en has the same?)

----------
RCS file: /cvsroot/src/usr.sbin/sysinst/arch/x68k/msg.md.en,v
retrieving revision 1.1
diff -u -r1.1 msg.md.en
--- arch/x68k/msg.md.en	26 Jul 2014 19:30:47 -0000	1.1
+++ arch/x68k/msg.md.en	2 Feb 2020 10:00:31 -0000
@@ -56,7 +56,7 @@
 }

 message ordering
-{The order of partition %c is wrong.  Edit again?}
+{The order of partition %s is wrong.  Edit again?}

 message emptypart
 {There is an valid partition %c after empty partition(s).
----------


2. The partition editor always displayed above error message.
  In arch/x68k/md.c:md_check_partitions(), install->infos seems be
  bsd disklabel.  If it's true, it should skip RAW_PART (sdNc) ?

----------
RCS file: /cvsroot/src/usr.sbin/sysinst/arch/x68k/md.c,v
retrieving revision 1.8.2.1
diff -u -r1.8.2.1 md.c
--- arch/x68k/md.c	17 Dec 2019 09:44:50 -0000	1.8.2.1
+++ arch/x68k/md.c	2 Feb 2020 10:00:31 -0000
@@ -163,6 +163,8 @@
 	char desc[STRSIZE];

 	for (i = 0; i < install->num; i++) {
+		if (i == RAW_PART)
+			continue;
 		if (i > 0) {
 			if (install->infos[i].cur_start < last_end) {
 				snprintf(desc, sizeof desc,
----------


With this two patches, I was able to complete the installation.

>How-To-Repeat:
Before installation, I prepared three Human68k partitions on the disk.
 1 non Human68k (for bsd ffs)
 2 non Human68k (for bsd swap)
 3 Human68k

Boot from sysinst floppies.
Choose "a: Install NetBSD to hard disk"
Choose "b: Yes"
Choose "a: sd0 (512M)"
Choose "a: Use existing disklabel partitions"

Choose "a:" and set newfs=yes, mount=yes, mountpoint=/.  I left all
other parameters(values) in the table untouched.
 |  a:     64   819263  819200       FFS NI  /
 |  b: 819264   884799   65536      swap
 |  c:      0  1048575 1048576  Whole disk
 |  d: 884800  1046591  161792     MSDOS

Here I choose "x: Partition sizes ok", then the message will be displayed.

 | The order of partition  is wrong.  Edit again?

>Fix:
See above.

>Release-Note:

>Audit-Trail:
From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54921 CVS commit: src/usr.sbin/sysinst/arch
Date: Mon, 3 Feb 2020 10:37:46 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Mon Feb  3 10:37:46 UTC 2020

 Modified Files:
 	src/usr.sbin/sysinst/arch/mvme68k: msg.md.de msg.md.en msg.md.es
 	    msg.md.fr msg.md.pl
 	src/usr.sbin/sysinst/arch/x68k: msg.md.en

 Log Message:
 PR install/54921: message "ordering" takes a %s argument.


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 src/usr.sbin/sysinst/arch/mvme68k/msg.md.de \
     src/usr.sbin/sysinst/arch/mvme68k/msg.md.en \
     src/usr.sbin/sysinst/arch/mvme68k/msg.md.es \
     src/usr.sbin/sysinst/arch/mvme68k/msg.md.fr \
     src/usr.sbin/sysinst/arch/mvme68k/msg.md.pl
 cvs rdiff -u -r1.2 -r1.3 src/usr.sbin/sysinst/arch/x68k/msg.md.en

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54921 CVS commit: src/usr.sbin/sysinst/arch
Date: Mon, 3 Feb 2020 13:09:29 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Mon Feb  3 13:09:29 UTC 2020

 Modified Files:
 	src/usr.sbin/sysinst/arch/hp300: md.c
 	src/usr.sbin/sysinst/arch/mvme68k: md.c
 	src/usr.sbin/sysinst/arch/x68k: md.c

 Log Message:
 PR install/54921: skip non-user partitions when checking for overlaps


 To generate a diff of this commit:
 cvs rdiff -u -r1.9 -r1.10 src/usr.sbin/sysinst/arch/hp300/md.c
 cvs rdiff -u -r1.9 -r1.10 src/usr.sbin/sysinst/arch/mvme68k/md.c
 cvs rdiff -u -r1.9 -r1.10 src/usr.sbin/sysinst/arch/x68k/md.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: install-manager->martin
Responsible-Changed-By: martin@NetBSD.org
Responsible-Changed-When: Mon, 03 Feb 2020 13:12:05 +0000
Responsible-Changed-Why:
My bug


State-Changed-From-To: open->feedback
State-Changed-By: martin@NetBSD.org
State-Changed-When: Mon, 03 Feb 2020 13:12:51 +0000
State-Changed-Why:
Probably fixed in -current, waiting for test results before requesting
pullup to -9.


From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: install/54921: sysinst partition editor fails on x68k/9.0_RC2
Date: Mon, 3 Feb 2020 14:10:59 +0100

 Good catch!

 I have commited the message changes (for all affected architectures) and
 tried to solve the raw partition issue slightly different.
 Could you test with a installer from HEAD?

 Thanks!

 Martin

From: Tetsuya Isaki <isaki@pastel-flower.jp>
To: gnats-bugs@netbsd.org
Cc: martin@netbsd.org,
	gnats-admin@netbsd.org,
	netbsd-bugs@netbsd.org
Subject: Re: install/54921: sysinst partition editor fails on x68k/9.0_RC2
Date: Tue, 04 Feb 2020 18:54:24 +0900

 At Mon,  3 Feb 2020 13:15:01 +0000 (UTC),
 Martin Husemann wrote:
 >  I have commited the message changes (for all affected architectures) and
 >  tried to solve the raw partition issue slightly different.
 >  Could you test with a installer from HEAD?

 I did the same work as steps I wrote before in this pr and 
 was able to install without any problems.
 Thank you!
 ---
 Tetsuya Isaki <isaki@pastel-flower.jp / isaki@NetBSD.org>

From: "Manuel Bouyer" <bouyer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/54921 CVS commit: [netbsd-9] src/usr.sbin/sysinst
Date: Mon, 10 Feb 2020 21:39:38 +0000

 Module Name:	src
 Committed By:	bouyer
 Date:		Mon Feb 10 21:39:38 UTC 2020

 Modified Files:
 	src/usr.sbin/sysinst [netbsd-9]: bsddisklabel.c defs.h disklabel.c
 	    disks.c mbr.c msg.mi.de msg.mi.en msg.mi.es msg.mi.fr msg.mi.pl
 	    partman.c target.c txtwalk.c upgrade.c
 	src/usr.sbin/sysinst/arch/hp300 [netbsd-9]: md.c
 	src/usr.sbin/sysinst/arch/i386 [netbsd-9]: md.c
 	src/usr.sbin/sysinst/arch/mac68k [netbsd-9]: md.c
 	src/usr.sbin/sysinst/arch/mvme68k [netbsd-9]: md.c msg.md.de msg.md.en
 	    msg.md.es msg.md.fr msg.md.pl
 	src/usr.sbin/sysinst/arch/x68k [netbsd-9]: md.c msg.md.en

 Log Message:
 Pull up following revision(s) (requested by martin in ticket #693):
 	usr.sbin/sysinst/arch/x68k/msg.md.en: revision 1.2
 	usr.sbin/sysinst/arch/x68k/md.c: revision 1.10
 	usr.sbin/sysinst/arch/mvme68k/msg.md.fr: revision 1.2
 	usr.sbin/sysinst/arch/x68k/msg.md.en: revision 1.3
 	usr.sbin/sysinst/arch/mvme68k/msg.md.fr: revision 1.3
 	usr.sbin/sysinst/msg.mi.en: revision 1.28
 	usr.sbin/sysinst/arch/hp300/md.c: revision 1.10
 	usr.sbin/sysinst/msg.mi.es: revision 1.22
 	usr.sbin/sysinst/target.c: revision 1.12
 	usr.sbin/sysinst/arch/mvme68k/md.c: revision 1.10
 	usr.sbin/sysinst/arch/i386/md.c: revision 1.30
 	usr.sbin/sysinst/arch/mvme68k/msg.md.pl: revision 1.2
 	usr.sbin/sysinst/arch/mvme68k/msg.md.pl: revision 1.3
 	usr.sbin/sysinst/bsddisklabel.c: revision 1.39
 	usr.sbin/sysinst/arch/mvme68k/msg.md.de: revision 1.2
 	usr.sbin/sysinst/arch/mac68k/md.c: revision 1.9
 	usr.sbin/sysinst/disklabel.c: revision 1.35
 	usr.sbin/sysinst/arch/mvme68k/msg.md.de: revision 1.3
 	usr.sbin/sysinst/defs.h: revision 1.55
 	usr.sbin/sysinst/disks.c: revision 1.63
 	usr.sbin/sysinst/disks.c: revision 1.64
 	usr.sbin/sysinst/mbr.c: revision 1.31
 	usr.sbin/sysinst/disks.c: revision 1.65
 	usr.sbin/sysinst/txtwalk.c: revision 1.3
 	usr.sbin/sysinst/txtwalk.c: revision 1.4
 	usr.sbin/sysinst/arch/mvme68k/msg.md.en: revision 1.2
 	usr.sbin/sysinst/arch/mvme68k/msg.md.en: revision 1.3
 	usr.sbin/sysinst/msg.mi.fr: revision 1.26
 	usr.sbin/sysinst/msg.mi.pl: revision 1.29
 	usr.sbin/sysinst/arch/mvme68k/msg.md.es: revision 1.2
 	usr.sbin/sysinst/upgrade.c: revision 1.15
 	usr.sbin/sysinst/arch/mvme68k/msg.md.es: revision 1.3
 	usr.sbin/sysinst/upgrade.c: revision 1.16
 	usr.sbin/sysinst/partman.c: revision 1.50
 	usr.sbin/sysinst/msg.mi.de: revision 1.21
 remove unused "emptypart" message (or moved to ifdef notyet area)
 PR install/54921: message "ordering" takes a %s argument.
 PR install/54921: skip non-user partitions when checking for overlaps
 bootxx_name() - fix oversight in previous change (do not assume first
 partition is the root partition)
 PR install/54934: always use -f on the installboot invocation. We come
 here post-newfs (and maybe should have dd'd zeros to the start of the
 disk before newfs instead).
 Remove a bogus assert: when reading disklabel partitions and the outer
 (MBR) partitioning has changed, but the changes have not yet been written
 back to disk, we need to ignore the kernels idea of the disklabel and
 instead continue with an empty one.
 Deal with partitioning schemes having no inner counterpart.
 Avoid NULL derefs.
 Do not assum a partitioning scheme that supports innner partitions always
 needs to actually have such partitions defined.
 PR bin/54944: deal with escaped spaces in NAME= syntax in /etc/fstab.
 PR bin/54944: explicitly reject GPT protective MBRs.
 PR bin/54944: make the "explicit single wedge" selection also work for
 upgrades.
 Reformat a query to add an automatically detected swap partition
 so it fits on narrow screens.
 Make re-install sets also work for an explicit selected root wedge
 Fix copy&pasto in previous - from kre.
 Only a single partition can ever have the "extend" flag (grow to available
 size).
 Do not use -P for tar extractions - the in tree tar has been fixed.
 Finish conversion to generic partitioning backend


 To generate a diff of this commit:
 cvs rdiff -u -r1.23.2.9 -r1.23.2.10 src/usr.sbin/sysinst/bsddisklabel.c
 cvs rdiff -u -r1.42.2.6 -r1.42.2.7 src/usr.sbin/sysinst/defs.h
 cvs rdiff -u -r1.10.2.8 -r1.10.2.9 src/usr.sbin/sysinst/disklabel.c
 cvs rdiff -u -r1.44.2.13 -r1.44.2.14 src/usr.sbin/sysinst/disks.c
 cvs rdiff -u -r1.19.2.5 -r1.19.2.6 src/usr.sbin/sysinst/mbr.c
 cvs rdiff -u -r1.13.2.6 -r1.13.2.7 src/usr.sbin/sysinst/msg.mi.de
 cvs rdiff -u -r1.19.2.7 -r1.19.2.8 src/usr.sbin/sysinst/msg.mi.en
 cvs rdiff -u -r1.14.2.6 -r1.14.2.7 src/usr.sbin/sysinst/msg.mi.es
 cvs rdiff -u -r1.17.2.7 -r1.17.2.8 src/usr.sbin/sysinst/msg.mi.fr
 cvs rdiff -u -r1.20.2.7 -r1.20.2.8 src/usr.sbin/sysinst/msg.mi.pl
 cvs rdiff -u -r1.41.2.4 -r1.41.2.5 src/usr.sbin/sysinst/partman.c
 cvs rdiff -u -r1.8.2.3 -r1.8.2.4 src/usr.sbin/sysinst/target.c
 cvs rdiff -u -r1.1.30.1 -r1.1.30.2 src/usr.sbin/sysinst/txtwalk.c
 cvs rdiff -u -r1.12.2.2 -r1.12.2.3 src/usr.sbin/sysinst/upgrade.c
 cvs rdiff -u -r1.8.2.1 -r1.8.2.2 src/usr.sbin/sysinst/arch/hp300/md.c
 cvs rdiff -u -r1.20.2.5 -r1.20.2.6 src/usr.sbin/sysinst/arch/i386/md.c
 cvs rdiff -u -r1.8 -r1.8.2.1 src/usr.sbin/sysinst/arch/mac68k/md.c
 cvs rdiff -u -r1.8.2.1 -r1.8.2.2 src/usr.sbin/sysinst/arch/mvme68k/md.c
 cvs rdiff -u -r1.1 -r1.1.30.1 src/usr.sbin/sysinst/arch/mvme68k/msg.md.de \
     src/usr.sbin/sysinst/arch/mvme68k/msg.md.en \
     src/usr.sbin/sysinst/arch/mvme68k/msg.md.es \
     src/usr.sbin/sysinst/arch/mvme68k/msg.md.fr \
     src/usr.sbin/sysinst/arch/mvme68k/msg.md.pl
 cvs rdiff -u -r1.8.2.1 -r1.8.2.2 src/usr.sbin/sysinst/arch/x68k/md.c
 cvs rdiff -u -r1.1 -r1.1.30.1 src/usr.sbin/sysinst/arch/x68k/msg.md.en

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: feedback->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Tue, 11 Feb 2020 08:46:32 +0000
State-Changed-Why:
Confirmed fixed and pulled up - thanks for the report!


>Unformatted:

Home	PR Database Search