NetBSD Problem Report #55070

From www@netbsd.org  Fri Mar 13 20:55:33 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 0FBC21A9213
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 13 Mar 2020 20:55:33 +0000 (UTC)
Message-Id: <20200313205532.2905F1A924B@mollari.NetBSD.org>
Date: Fri, 13 Mar 2020 20:55:32 +0000 (UTC)
From: roy@marples.name
Reply-To: roy@marples.name
To: gnats-bugs@NetBSD.org
Subject: compiler_rt does not build with clang with MKIPFILTER=no
X-Send-Pr-Version: www-1.0

>Number:         55070
>Category:       bin
>Synopsis:       compiler_rt does not build with clang with MKIPFILTER=no
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kamil
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 13 21:00:00 +0000 2020
>Closed-Date:    Sun Mar 15 23:54:09 +0000 2020
>Last-Modified:  Sun Mar 15 23:54:09 +0000 2020
>Originator:     Roy Marples
>Release:        9.99.49
>Organization:
>Environment:
$ uname -a
NetBSD cube.marples.name 9.99.48 NetBSD 9.99.48 (GENERIC) #3: Tue Mar  3 20:14:40 UTC 2020  roy@cube.marples.name:/usr/obj/sys/arch/amd64/compile.amd64/GENERIC amd64
>Description:
/usr/src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc:165:10: fatal error: 'netinet/ip_fil.h' file not found
#include <netinet/ip_fil.h>
         ^~~~~~~~~~~~~~~~~~

>How-To-Repeat:
Enable build for clang and set MKIPFILTER=no
>Fix:

>Release-Note:

>Audit-Trail:
From: Roy Marples <roy@marples.name>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/55070: compiler_rt does not build with clang with
 MKIPFILTER=no
Date: Sat, 14 Mar 2020 22:28:08 +0000

 This patch makes it compile for me.

 Index: 
 sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc
 ===================================================================
 RCS file: 
 /cvsroot/src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc,v
 retrieving revision 1.5
 diff -u -p -r1.5 sanitizer_platform_limits_netbsd.cc
 --- 
 sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc 
   31 Jan 2020 14:01:36 -0000      1.5
 +++ 
 sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc 
   14 Mar 2020 22:23:57 -0000
 @@ -162,9 +162,11 @@
   #include <net/slip.h>
   #include <netbt/hci.h>
   #include <netinet/ip_compat.h>
 +#if 0
   #include <netinet/ip_fil.h>
   #include <netinet/ip_nat.h>
   #include <netinet/ip_proxy.h>
 +#endif
   #include <netinet6/in6_var.h>
   #include <netinet6/nd6.h>
   #include <netsmb/smb_dev.h>
 @@ -412,7 +414,9 @@ typedef __sanitizer_nvlist_ref_t nvlist_
   // ioctl arguments
   unsigned struct_altqreq_sz = sizeof(altqreq);
   unsigned struct_amr_user_ioctl_sz = sizeof(amr_user_ioctl);
 +#if 0
   unsigned struct_ap_control_sz = sizeof(ap_control);
 +#endif
   unsigned struct_apm_ctl_sz = sizeof(apm_ctl);
   unsigned struct_apm_event_info_sz = sizeof(apm_event_info);
   unsigned struct_apm_power_info_sz = sizeof(apm_power_info);
 @@ -572,7 +576,9 @@ unsigned struct_ioc_vol_sz = sizeof(ioc_
   unsigned struct_ioctl_pt_sz = sizeof(ioctl_pt);
   unsigned struct_ioppt_sz = sizeof(ioppt);
   unsigned struct_iovec_sz = sizeof(iovec);
 +#if 0
   unsigned struct_ipfobj_sz = sizeof(ipfobj);
 +#endif
   unsigned struct_irda_params_sz = sizeof(irda_params);
   unsigned struct_isp_fc_device_sz = sizeof(isp_fc_device);
   unsigned struct_isp_fc_tsk_mgmt_sz = sizeof(isp_fc_tsk_mgmt);
 @@ -1680,11 +1686,13 @@ unsigned IOCTL_SIOCZBTSTATS = SIOCZBTSTA
   unsigned IOCTL_SIOCBTDUMP = SIOCBTDUMP;
   unsigned IOCTL_SIOCSBTSCOMTU = SIOCSBTSCOMTU;
   unsigned IOCTL_SIOCGBTFEAT = SIOCGBTFEAT;
 +#if 0
   unsigned IOCTL_SIOCADNAT = SIOCADNAT;
   unsigned IOCTL_SIOCRMNAT = SIOCRMNAT;
   unsigned IOCTL_SIOCGNATS = SIOCGNATS;
   unsigned IOCTL_SIOCGNATL = SIOCGNATL;
   unsigned IOCTL_SIOCPURGENAT = SIOCPURGENAT;
 +#endif
   unsigned IOCTL_SIOCCONNECTX = SIOCCONNECTX;
   unsigned IOCTL_SIOCCONNECTXDEL = SIOCCONNECTXDEL;
   unsigned IOCTL_SIOCSIFINFO_FLAGS = SIOCSIFINFO_FLAGS;




 Makes me wonder though, are the values even used?

 Roy

Responsible-Changed-From-To: bin-bug-people->kamil
Responsible-Changed-By: kamil@NetBSD.org
Responsible-Changed-When: Sat, 14 Mar 2020 23:39:08 +0100
Responsible-Changed-Why:
Take.


State-Changed-From-To: open->closed
State-Changed-By: kamil@NetBSD.org
State-Changed-When: Mon, 16 Mar 2020 00:54:09 +0100
State-Changed-Why:
Fixed in src/sys/external/bsd/compiler_rt/dist/lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc r1.6

> 
> Makes me wonder though, are the values even used?

Without this code, ioctl IPFILTER codes are uninitialized.


>Unformatted:

Home	PR Database Search