NetBSD Problem Report #55088

From paul@whooppee.com  Thu Mar 19 19:18:54 2020
Return-Path: <paul@whooppee.com>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id EE0531A9213
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 19 Mar 2020 19:18:53 +0000 (UTC)
Message-Id: <20200319191751.2093330F2C3@speedy.whooppee.com>
Date: Thu, 19 Mar 2020 12:17:51 -0700 (PDT)
From: paul@whooppee.com
Reply-To: paul@whooppee.com
To: gnats-bugs@NetBSD.org
Subject: SYSCTL_SETUP seems not to work for built-in modules in rump
X-Send-Pr-Version: 3.95

>Number:         55088
>Category:       kern
>Synopsis:       SYSCTL_SETUP seems not to work for built-in modules in rump
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pgoyette
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 19 19:20:00 +0000 2020
>Closed-Date:    Sun Mar 22 13:36:21 +0000 2020
>Last-Modified:  Sun Mar 22 13:36:21 +0000 2020
>Originator:     Paul Goyette
>Release:        NetBSD 9.99.46
>Organization:
+--------------------+--------------------------+-----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul@whooppee.com     |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette@netbsd.org   |
+--------------------+--------------------------+-----------------------+
>Environment:


System: NetBSD speedy.whooppee.com 9.99.46 NetBSD 9.99.46 (SPEEDY 2020-02-07 16:26:35 UTC) #1: Fri Feb 7 19:37:58 UTC 2020 paul@speedy.whooppee.com:/build/netbsd-local/obj/amd64/sys/arch/amd64/compile/SPEEDY amd64
Architecture: x86_64
Machine: amd64
>Description:
Rump kernels appear not to properly process SYSCTL_SETUP functions for
built-in modules.  (Presumably this is a result of the way rump processes
link sets, and is expected to also affect link_set_evcnts.)  As a result,
the ATF tests for dev/swsensor fail.

>How-To-Repeat:
Insert printf()s in swsensor's modcmd to confirm that the module is
initialized.  Similarly, add printf()s to swsensor's SYSCTL_SETUP func
to confirm if the set-up function is called.  Build a complete rump
set-up (or, do a ``build.sh release'') and install it.

Now, invoke rump with something similar to

	export RUMP_SERVER=unix://test_socket_name
	rump_allserver -l rumpvfs -l rumpdev -l rumpdev_sysmon ${RUMP_SERVER}

You should see that the module is loaded and its modcmd() is called,
yet you will not see that the SYSCTL_SETUP function has executed.

Execute rump.modstat to confirm that the swsensor module exists as a
built-in module.



>Fix:
Unknown.


>Release-Note:

>Audit-Trail:
From: "Paul Goyette" <pgoyette@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55088 CVS commit: src/tests/dev/sysmon
Date: Thu, 19 Mar 2020 20:10:50 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Thu Mar 19 20:10:49 UTC 2020

 Modified Files:
 	src/tests/dev/sysmon: t_swsensor.sh

 Log Message:
 Mark the swsensor tests "expected failure" since the rump world doesn't
 seem to handle the SYSCTL_SETUP stuff.  PR kern/55088


 To generate a diff of this commit:
 cvs rdiff -u -r1.9 -r1.10 src/tests/dev/sysmon/t_swsensor.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: kern-bug-people->pgoyette
Responsible-Changed-By: pgoyette@NetBSD.org
Responsible-Changed-When: Sat, 21 Mar 2020 04:37:11 +0000
Responsible-Changed-Why:
Take - it's mine.


From: "Paul Goyette" <pgoyette@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55088 CVS commit: src
Date: Sat, 21 Mar 2020 04:48:38 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Sat Mar 21 04:48:38 UTC 2020

 Modified Files:
 	src/lib/librumpuser: rumpuser_dl.c
 	src/sys/rump: ldscript.rump

 Log Message:
 Teach rump how to process __link_set_sysctl_funcs so it can handle
 modules the same as a real kernel.

 Partly addresses PR kern/55088 - __link_set_evcnts not yet handled
 (that will happen later)


 To generate a diff of this commit:
 cvs rdiff -u -r1.31 -r1.32 src/lib/librumpuser/rumpuser_dl.c
 cvs rdiff -u -r1.3 -r1.4 src/sys/rump/ldscript.rump

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Paul Goyette" <pgoyette@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55088 CVS commit: src
Date: Sun, 22 Mar 2020 13:30:11 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Sun Mar 22 13:30:11 UTC 2020

 Modified Files:
 	src/lib/librumpuser: rumpuser_dl.c
 	src/sys/rump/include/rump: rumpuser.h
 	src/sys/rump/librump/rumpkern: rump.c

 Log Message:
 Teach rump to process __link_set_evcnts entries.  (Second part of
 fix for PR kern/55088)


 To generate a diff of this commit:
 cvs rdiff -u -r1.32 -r1.33 src/lib/librumpuser/rumpuser_dl.c
 cvs rdiff -u -r1.115 -r1.116 src/sys/rump/include/rump/rumpuser.h
 cvs rdiff -u -r1.342 -r1.343 src/sys/rump/librump/rumpkern/rump.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: pgoyette@NetBSD.org
State-Changed-When: Sun, 22 Mar 2020 13:36:21 +0000
State-Changed-Why:
It's fixed


>Unformatted:

Home	PR Database Search