NetBSD Problem Report #55140

From miguel@miguel.cc  Fri Apr  3 19:05:47 2020
Return-Path: <miguel@miguel.cc>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 4DC321A9213
	for <gnats-bugs@gnats.NetBSD.org>; Fri,  3 Apr 2020 19:05:47 +0000 (UTC)
Message-Id: <20200403190542.GA15015@ip-172-31-24-33.eu-west-1.compute.internal>
Date: Fri, 3 Apr 2020 19:05:42 +0000
From: nomadium@debian.org
Sender: Miguel Landaeta <miguel@miguel.cc>
Reply-To: nomadium@debian.org
To: gnats-bugs@NetBSD.org
Subject: Add support for DWA-121 rev B1 to urtwn(4)
X-Send-Pr-Version: 3.95

>Number:         55140
>Category:       kern
>Synopsis:       Add support for DWA-121 rev B1 to urtwn(4)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 03 19:10:00 +0000 2020
>Closed-Date:    Fri Apr 24 19:01:30 +0000 2020
>Last-Modified:  Fri Apr 24 19:01:30 +0000 2020
>Originator:     Miguel Landaeta
>Release:        HEAD
>Organization:
>Environment:
NetBSD joss.nomadium.net 9.99.52 NetBSD 9.99.52 (GENERIC64) #1: Thu Apr  2 17:54:31 UTC 2020
miguel@joss.nomadium.net:/usr/obj/sys/arch/evbarm/compile/GENERIC64 evbarm
Architecture: aarch64
Machine: evbarm
>Description:
Add support for DWA-121 rev B1 to urtwn(4)

[     7.433394] urtwn0 at uhub8 port 1
[     7.433394] urtwn0: Realtek (0x2001) product 331b (0x331b), rev 2.00/0.00, addr 3
[     7.543398] urtwn0: MAC/BB RTL8188EU, RF 6052 1T1R, address 60:63:4c:xx:xx:xx
[     7.543398] urtwn0: 1 rx pipe, 2 tx pipes

miguel@joss:~$ sysctl kern.version
kern.version = NetBSD 9.99.52 (GENERIC64) #1: Thu Apr  2 17:54:31 UTC 2020
        miguel@joss.nomadium.net:/usr/obj/sys/arch/evbarm/compile/GENERIC64


>How-To-Repeat:

>Fix:
Index: sys/dev/usb/if_urtwn.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/if_urtwn.c,v
retrieving revision 1.84
diff -u -r1.84 if_urtwn.c
--- sys/dev/usb/if_urtwn.c	15 Mar 2020 23:04:51 -0000	1.84
+++ sys/dev/usb/if_urtwn.c	2 Apr 2020 18:58:40 -0000
@@ -212,6 +212,7 @@
 	URTWN_RTL8188E_DEV(REALTEK, RTL8188EU),
 	URTWN_RTL8188E_DEV(ABOCOM, RTL8188EU),
 	URTWN_RTL8188E_DEV(TPLINK, RTL8188EU),
+	URTWN_RTL8188E_DEV(DLINK, DWA121B1),

 	/* URTWN_RTL8192EU */
 	URTWN_RTL8192EU_DEV(DLINK,	DWA131E),
Index: sys/dev/usb/usbdevs
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs,v
retrieving revision 1.777
diff -u -r1.777 usbdevs
--- sys/dev/usb/usbdevs	13 Mar 2020 07:42:26 -0000	1.777
+++ sys/dev/usb/usbdevs	2 Apr 2020 18:58:40 -0000
@@ -1401,6 +1401,7 @@
 product DLINK DWA131B		0x330d	DWA-131 rev B
 product DLINK DWA125D1		0x330f	DWA-125 rev D1
 product DLINK DWA131E		0x3319	DWA-131 rev E
+product DLINK DWA121B1		0x331b	DWA-121 rev B1
 product DLINK DWL122		0x3700	Wireless DWL122
 product DLINK DWLG120		0x3701	DWL-G120
 product DLINK DWL120F		0x3702	DWL-120 rev F
Index: sys/dev/usb/usbdevs.h
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs.h,v
retrieving revision 1.767
diff -u -r1.767 usbdevs.h
--- sys/dev/usb/usbdevs.h	13 Mar 2020 07:43:14 -0000	1.767
+++ sys/dev/usb/usbdevs.h	2 Apr 2020 18:58:40 -0000
@@ -1408,6 +1408,7 @@
 #define	USB_PRODUCT_DLINK_DWA131B	0x330d		/* DWA-131 rev B */
 #define	USB_PRODUCT_DLINK_DWA125D1	0x330f		/* DWA-125 rev D1 */
 #define	USB_PRODUCT_DLINK_DWA131E	0x3319		/* DWA-131 rev E */
+#define	USB_PRODUCT_DLINK_DWA121B1	0x331b		/* DWA-121 rev B1 */
 #define	USB_PRODUCT_DLINK_DWL122	0x3700		/* Wireless DWL122 */
 #define	USB_PRODUCT_DLINK_DWLG120	0x3701		/* DWL-G120 */
 #define	USB_PRODUCT_DLINK_DWL120F	0x3702		/* DWL-120 rev F */

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->feedback
State-Changed-By: skrll@NetBSD.org
State-Changed-When: Sat, 04 Apr 2020 10:02:22 +0000
State-Changed-Why:
Patches committed. OK to close?


From: Miguel Landaeta <miguel@miguel.cc>
To: gnats-bugs@netbsd.org
Cc: kern-bug-people@netbsd.org, netbsd-bugs@netbsd.org, gnats-admin@netbsd.org, 
	skrll@netbsd.org, Miguel Landaeta <nomadium@debian.org>
Subject: Re: kern/55140 (Add support for DWA-121 rev B1 to urtwn(4))
Date: Mon, 6 Apr 2020 21:21:22 +0100

 Thanks for the prompt reply and handling.

 Today I booted -current and could verify the device is now detected and working.

 You can resolve this issue.

 Cheers,
 Miguel.


 On Sat, Apr 4, 2020 at 11:10 AM <skrll@netbsd.org> wrote:
 >
 > Synopsis: Add support for DWA-121 rev B1 to urtwn(4)
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: skrll@NetBSD.org
 > State-Changed-When: Sat, 04 Apr 2020 10:02:22 +0000
 > State-Changed-Why:
 > Patches committed. OK to close?
 >
 >
 >


 --
 Miguel Landaeta, miguel at miguel.cc
 secure email with PGP 0x6E608B637D8967E9 available at http://keyserver.pgp.com/
 "Faith means not wanting to know what is true." -- Nietzsche

State-Changed-From-To: feedback->needs-pullups
State-Changed-By: maya@NetBSD.org
State-Changed-When: Tue, 07 Apr 2020 00:36:11 +0000
State-Changed-Why:
Probably worth putting in netbsd-9.


State-Changed-From-To: needs-pullups->pending-pullups
State-Changed-By: maya@NetBSD.org
State-Changed-When: Fri, 24 Apr 2020 09:22:57 +0000
State-Changed-Why:
pullup-9 #848


State-Changed-From-To: pending-pullups->closed
State-Changed-By: maya@NetBSD.org
State-Changed-When: Fri, 24 Apr 2020 19:01:30 +0000
State-Changed-Why:
thanks for the patch.


>Unformatted:

Home	PR Database Search