NetBSD Problem Report #55199

From www@netbsd.org  Thu Apr 23 11:06:54 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id AD9F51A9218
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 23 Apr 2020 11:06:54 +0000 (UTC)
Message-Id: <20200423110653.ABA0D1A924D@mollari.NetBSD.org>
Date: Thu, 23 Apr 2020 11:06:53 +0000 (UTC)
From: webpages@sprow.co.uk
Reply-To: webpages@sprow.co.uk
To: gnats-bugs@NetBSD.org
Subject: Add missing receive error status bit definitions to bcmgenet.h
X-Send-Pr-Version: www-1.0

>Number:         55199
>Category:       kern
>Synopsis:       Add missing receive error status bit definitions to bcmgenet.h
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 23 11:10:00 +0000 2020
>Closed-Date:    Sat Apr 25 10:22:08 +0000 2020
>Last-Modified:  Sat Apr 25 10:25:01 +0000 2020
>Originator:     Robert Sprowson
>Release:        
>Organization:
>Environment:
>Description:
Only bit 2 is currently defined (and, infact, not used) but there are others. Add these - see attached patch.
>How-To-Repeat:

>Fix:
--- bcmgenetreg.1.2.h	2020-04-23 11:58:57 +0100
+++ bcmgenetreg.h	2020-04-23 11:01:36 +0100
@@ -138,7 +138,12 @@
 #define	 GENET_RX_DESC_STATUS_OWN	__BIT(15)
 #define	 GENET_RX_DESC_STATUS_EOP	__BIT(14)
 #define	 GENET_RX_DESC_STATUS_SOP	__BIT(13)
-#define	 GENET_RX_DESC_STATUS_RX_ERROR	__BIT(2)
+#define	 GENET_RX_DESC_STATUS_ALL_ERRS	__BITS(4,0)
+#define	 GENET_RX_DESC_STATUS_LEN_ERR	__BIT(4)
+#define	 GENET_RX_DESC_STATUS_FRAME_ERR	__BIT(3)
+#define	 GENET_RX_DESC_STATUS_RX_ERR	__BIT(2)
+#define	 GENET_RX_DESC_STATUS_CRC_ERR	__BIT(1)
+#define	 GENET_RX_DESC_STATUS_OVRUN_ERR	__BIT(0)
 #define	GENET_RX_DESC_ADDRESS_LO(idx)	(GENET_RX_BASE + GENET_DMA_DESC_SIZE * (idx) + 0x04)
 #define	GENET_RX_DESC_ADDRESS_HI(idx)	(GENET_RX_BASE + GENET_DMA_DESC_SIZE * (idx) + 0x08)


>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: jmcneill@NetBSD.org
State-Changed-When: Sat, 25 Apr 2020 10:22:08 +0000
State-Changed-Why:
Patch applied, thanks!


From: "Jared D. McNeill" <jmcneill@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55199 CVS commit: src/sys/dev/ic
Date: Sat, 25 Apr 2020 10:21:42 +0000

 Module Name:	src
 Committed By:	jmcneill
 Date:		Sat Apr 25 10:21:41 UTC 2020

 Modified Files:
 	src/sys/dev/ic: bcmgenetreg.h

 Log Message:
 Add missing receive error status bit definitions, from Robert Sprowson in
 PR# kern/55199


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 src/sys/dev/ic/bcmgenetreg.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search