NetBSD Problem Report #55360

From gson@gson.org  Mon Jun  8 12:18:36 2020
Return-Path: <gson@gson.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id DCC6B1A9219
	for <gnats-bugs@gnats.NetBSD.org>; Mon,  8 Jun 2020 12:18:36 +0000 (UTC)
Message-Id: <20200608121831.6DFD3253EE2@guava.gson.org>
Date: Mon,  8 Jun 2020 15:18:31 +0300 (EEST)
From: gson@gson.org (Andreas Gustafsson)
Reply-To: gson@gson.org (Andreas Gustafsson)
To: gnats-bugs@NetBSD.org
Subject: usr.bin/make/t_make:include_sub, include_subsub test cases fail since inception
X-Send-Pr-Version: 3.95

>Number:         55360
>Category:       bin
>Synopsis:       usr.bin/make/t_make:include_sub, include_subsub test cases fail since inception
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    rillig
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jun 08 12:20:00 +0000 2020
>Closed-Date:    Wed Jun 10 03:39:56 +0000 2020
>Last-Modified:  Wed Jun 10 03:39:56 +0000 2020
>Originator:     Andreas Gustafsson
>Release:        NetBSD-current, source date >= 2020.05.17.12.36.26
>Organization:
>Environment:
System: NetBSD
Architecture: x86_64
Machine: amd64
>Description:

The include_sub and include_subsub test cases of the usr.bin/make/t_make test
program have been failing ever since they were added in this commit:

  2020.05.17.12.36.26 rillig src/distrib/sets/lists/tests/mi 1.841
  2020.05.17.12.36.26 rillig src/usr.bin/make/unit-tests/Makefile 1.58
  2020.05.17.12.36.26 rillig src/usr.bin/make/unit-tests/include-main.exp 1.1
  2020.05.17.12.36.26 rillig src/usr.bin/make/unit-tests/include-main.mk 1.1
  2020.05.17.12.36.26 rillig src/usr.bin/make/unit-tests/include-sub.mk 1.1
  2020.05.17.12.36.26 rillig src/usr.bin/make/unit-tests/include-subsub.mk 1.1

If they are failing on purpose to demonstrate a known bug, they should
be marked as "expected failures" with a reference to a PR.

>How-To-Repeat:

Run the ATF tests.

>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: bin-bug-people->rillig
Responsible-Changed-By: gson@NetBSD.org
Responsible-Changed-When: Mon, 08 Jun 2020 12:23:15 +0000
Responsible-Changed-Why:
Over to committer.


From: "Roland Illig" <rillig@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55360 CVS commit: src/tests/usr.bin/make
Date: Mon, 8 Jun 2020 19:50:11 +0000

 Module Name:	src
 Committed By:	rillig
 Date:		Mon Jun  8 19:50:11 UTC 2020

 Modified Files:
 	src/tests/usr.bin/make: t_make.sh

 Log Message:
 usr.bin/make: fix test failure

 The two files include-sub.mk and include-subsub.mk were never intended to
 be test cases on their own.  They belong to include-main.mk.

 Fixes PR bin/55360.


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 src/tests/usr.bin/make/t_make.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: rillig@NetBSD.org
State-Changed-When: Wed, 10 Jun 2020 03:39:56 +0000
State-Changed-Why:
Fixed. Thanks for the PR.


>Unformatted:

Home	PR Database Search