NetBSD Problem Report #55401

From www@netbsd.org  Fri Jun 19 15:50:18 2020
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id B905E1A9217
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 19 Jun 2020 15:50:18 +0000 (UTC)
Message-Id: <20200619155017.CC4E21A921F@mollari.NetBSD.org>
Date: Fri, 19 Jun 2020 15:50:17 +0000 (UTC)
From: venture37@geeklan.co.uk
Reply-To: venture37@geeklan.co.uk
To: gnats-bugs@NetBSD.org
Subject: pktools/pkg_install 'IS_URL' macro redefined during bootstrap
X-Send-Pr-Version: www-1.0

>Number:         55401
>Category:       pkg
>Synopsis:       pktools/pkg_install 'IS_URL' macro redefined during bootstrap
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    agc
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 19 15:55:00 +0000 2020
>Last-Modified:  Sun Aug 23 09:01:33 +0000 2020
>Originator:     Sevan Janiyan
>Release:        pkgrsc-current
>Organization:
>Environment:
FreeBSD 12.1-RELEASE amd64
>Description:
cc -DHAVE_CONFIG_H -DDEF_LOG_DIR=\"/tmp/pkg3/pkgdb\" -I/usr/pkgsrc/bootstrap/work/libnbcompat -I/usr/pkgsrc/bootstrap/work/libarchive/libarchive -I. -I. -DSYSCONFDIR=\"/tmp/pkg3/etc\" -DBOOTSTRAP -g -O2 -c pkg_io.c
In file included from pkg_io.c:58:
./lib.h:243:9: warning: 'IS_URL' macro redefined [-Wmacro-redefined]
#define IS_URL(str)     (URLlength(str) > 0)
        ^
pkg_io.c:53:9: note: previous definition is here
#define IS_URL(x) 0
        ^
1 warning generated.
>How-To-Repeat:

>Fix:
Index: pkgtools/pkg_install/files/lib/pkg_io.c
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pkg_install/files/lib/pkg_io.c,v
retrieving revision 1.13
diff -u -p -r1.13 pkg_io.c
--- pkgtools/pkg_install/files/lib/pkg_io.c     16 Jul 2017 16:51:48 -0000      1.13
+++ pkgtools/pkg_install/files/lib/pkg_io.c     19 Jun 2020 15:48:11 -0000
@@ -48,14 +48,14 @@ __RCSID("$NetBSD: pkg_io.c,v 1.13 2017/0
 #endif
 #include <stdlib.h>

+#include "lib.h"
+
 #ifdef BOOTSTRAP
 #undef IS_URL
 #define IS_URL(x) 0
 #else
 #include <fetch.h>
 #endif
-
-#include "lib.h"

 struct pkg_path {
        TAILQ_ENTRY(pkg_path) pl_link;

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->freebsd-pkg-people
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Wed, 24 Jun 2020 11:46:55 +0000
Responsible-Changed-Why:
FreeBSD problem


Responsible-Changed-From-To: freebsd-pkg-people->pkg-manager
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Wed, 24 Jun 2020 12:22:28 +0000
Responsible-Changed-Why:
Manifests on FreeBSD but probably not strictly FreeBSD related
(via private email from <sevan)


Responsible-Changed-From-To: pkg-manager->agc
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Sun, 23 Aug 2020 09:01:33 +0000
Responsible-Changed-Why:
to pkg_install MAINTAINER
(if you think the patch is ok, send it back to me and I'll go commit it
)


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.