NetBSD Problem Report #55612

From martin@aprisoft.de  Fri Aug 28 16:52:34 2020
Return-Path: <martin@aprisoft.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 63BB31A923A
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 28 Aug 2020 16:52:34 +0000 (UTC)
Message-Id: <20200828165224.243135CC7A5@emmas.aprisoft.de>
Date: Fri, 28 Aug 2020 18:52:24 +0200 (CEST)
From: martin@NetBSD.org
Reply-To: martin@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: libarchive tests pollute /tmp w/o cleanup
X-Send-Pr-Version: 3.95

>Number:         55612
>Category:       bin
>Synopsis:       libarchive tests pollute /tmp w/o cleanup
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 28 16:55:00 +0000 2020
>Closed-Date:    Wed May 17 11:26:52 +0000 2023
>Last-Modified:  Mon Jun 10 00:00:01 +0000 2024
>Originator:     Martin Husemann
>Release:        NetBSD 9.99.71
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD h-pulse.aprisoft.de 9.99.71 NetBSD 9.99.71 (GENERIC64) #154: Fri Aug 28 10:38:10 CEST 2020 martin@seven-days-to-the-wolves.aprisoft.de:/work/src/sys/arch/evbarm/compile/GENERIC64 evbarm
Architecture: aarch64
Machine: evbarm
>Description:

Running the /usr/tests/lib/libarchive tests pollutes /tmp and does not clean
up. Tests are not supposed to make changes anywhere outside the temporary
ATF directory, and also are expected to clean up fully.

>How-To-Repeat:

ls -l /tmp; cd /usr/tests/lib/libarchive && atf-run; ls -l /tmp

>Fix:
Set TMPDIR to . during the test?

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55612 CVS commit: src/external/bsd/libarchive/dist/libarchive/test
Date: Fri, 28 Aug 2020 14:44:54 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Fri Aug 28 18:44:54 UTC 2020

 Modified Files:
 	src/external/bsd/libarchive/dist/libarchive/test:
 	    test_write_disk_secure.c

 Log Message:
 PR/55612: Martin Husemann: libarchive tests pollute /tmp w/o cleanup
 Make tests obey $TMPDIR.


 To generate a diff of this commit:
 cvs rdiff -u -r1.3 -r1.4 \
     src/external/bsd/libarchive/dist/libarchive/test/test_write_disk_secure.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55612 CVS commit: src/tests/lib/libarchive
Date: Fri, 28 Aug 2020 14:46:05 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Fri Aug 28 18:46:05 UTC 2020

 Modified Files:
 	src/tests/lib/libarchive: t_libarchive.sh

 Log Message:
 PR/55612: Martin Husemann: libarchive tests pollute /tmp w/o cleanup
 Set $TMPDIR to where we are.


 To generate a diff of this commit:
 cvs rdiff -u -r1.6 -r1.7 src/tests/lib/libarchive/t_libarchive.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Wed, 17 May 2023 11:26:52 +0000
State-Changed-Why:
christos fixed it in 2020


From: "Taylor R Campbell" <riastradh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/55612 CVS commit: src/external/bsd/libarchive/dist/libarchive/test
Date: Sun, 9 Jun 2024 23:58:23 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Sun Jun  9 23:58:23 UTC 2024

 Modified Files:
 	src/external/bsd/libarchive/dist/libarchive/test:
 	    test_write_disk_secure.c

 Log Message:
 libarchive test_write_disk_secure.c: Restore hunk of local change.

 This was part of a change added in revision 1.4 in order to avoid
 cluttering /tmp (PR 55612), and lost in the 3.7.4 merge:

 https://mail-index.netbsd.org/source-changes/2020/08/28/msg121149.html


 To generate a diff of this commit:
 cvs rdiff -u -r1.5 -r1.6 \
     src/external/bsd/libarchive/dist/libarchive/test/test_write_disk_secure.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search