NetBSD Problem Report #55976
From gson@gson.org Thu Feb 4 18:46:59 2021
Return-Path: <gson@gson.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
by mollari.NetBSD.org (Postfix) with ESMTPS id 5B35F1A9217
for <gnats-bugs@gnats.NetBSD.org>; Thu, 4 Feb 2021 18:46:59 +0000 (UTC)
Message-Id: <20210204184628.3962B253EDE@guava.gson.org>
Date: Thu, 4 Feb 2021 20:46:28 +0200 (EET)
From: gson@gson.org (Andreas Gustafsson)
Reply-To: gson@gson.org (Andreas Gustafsson)
To: gnats-bugs@NetBSD.org
Subject: usr.bin/xlint/lint1/t_integration:all_messages test case fails
X-Send-Pr-Version: 3.95
>Number: 55976
>Category: bin
>Synopsis: usr.bin/xlint/lint1/t_integration:all_messages test case fails
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: bin-bug-people
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Thu Feb 04 18:50:00 +0000 2021
>Closed-Date: Sat Feb 12 21:11:18 +0000 2022
>Last-Modified: Sat Feb 12 21:11:18 +0000 2022
>Originator: Andreas Gustafsson
>Release: NetBSD-current, source date >= 2021.01.05.22.38.51
>Organization:
>Environment:
System: NetBSD
Architecture: i386
Machine: i386
>Description:
On Jan 6, the NetBSD Test Fixture reported:
This is an automatically generated notice of a new failure of the
NetBSD test suite.
The newly failing test case is:
usr.bin/xlint/lint1/t_integration:all_messages
The above test failed in each of the last 4 test runs, and passed in
at least 26 consecutive runs before that.
The following commits were made between the last successful test and
the failed test:
2021.01.05.22.17.40 mlelstv src/share/man/man4/dk.4,v 1.8
2021.01.05.22.38.51 rillig src/tests/usr.bin/xlint/lint1/msg_324.c,v 1.2
2021.01.05.22.38.51 rillig src/tests/usr.bin/xlint/lint1/msg_324.exp,v 1.2
Logs can be found at:
http://releng.NetBSD.org/b5reports/i386/commits-2021.01.html#2021.01.05.22.38.51
This is still failing as of today.
>How-To-Repeat:
Run the tests.
>Fix:
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: rillig@NetBSD.org
State-Changed-When: Thu, 04 Feb 2021 19:21:49 +0000
State-Changed-Why:
This was fixed on msg_324.c 1.4 from 2021-01-06 09:23:04.
State-Changed-From-To: closed->open
State-Changed-By: gson@NetBSD.org
State-Changed-When: Thu, 04 Feb 2021 19:56:35 +0000
State-Changed-Why:
It was re-broken after being fixed.
From: Andreas Gustafsson <gson@gson.org>
To: rillig@NetBSD.org
Cc: gnats-bugs@netbsd.org
Subject: Re: bin/55976 (usr.bin/xlint/lint1/t_integration:all_messages test case fails)
Date: Thu, 4 Feb 2021 21:55:31 +0200
rillig@NetBSD.org wrote:
> State-Changed-From-To: open->closed
> State-Changed-By: rillig@NetBSD.org
> State-Changed-When: Thu, 04 Feb 2021 19:21:49 +0000
> State-Changed-Why:
> This was fixed on msg_324.c 1.4 from 2021-01-06 09:23:04.
Yes, but it was broken again on 2021-01-08 21:25:03:
http://releng.netbsd.org/b5reports/i386/commits-2021.01.html#2021.01.08.21.25.03
and still failed today:
http://releng.netbsd.org/b5reports/i386/2021/2021.02.04.15.08.44/test.html#usr.bin_xlint_lint1_t_integration_all_messages
--
Andreas Gustafsson, gson@gson.org
From: Roland Illig <roland.illig@gmx.de>
To: Andreas Gustafsson <gson@NetBSD.org>
Cc: gnats-bugs@netbsd.org
Subject: Re: bin/55976 (usr.bin/xlint/lint1/t_integration:all_messages test
case fails)
Date: Thu, 4 Feb 2021 23:41:31 +0100
On 04.02.2021 20:55, Andreas Gustafsson wrote:
> rillig@NetBSD.org wrote:
>> State-Changed-From-To: open->closed
>> State-Changed-By: rillig@NetBSD.org
>> State-Changed-When: Thu, 04 Feb 2021 19:21:49 +0000
>> State-Changed-Why:
>> This was fixed on msg_324.c 1.4 from 2021-01-06 09:23:04.
>
> Yes, but it was broken again on 2021-01-08 21:25:03:
>
> http://releng.netbsd.org/b5reports/i386/commits-2021.01.html#2021.01.=
08.21.25.03
>
> and still failed today:
>
> http://releng.netbsd.org/b5reports/i386/2021/2021.02.04.15.08.44/test=
.html#usr.bin_xlint_lint1_t_integration_all_messages
Given that the test is called "all_messages" and contains 338 sub-tests,
it's no surprise that some of them fail from time to time since lint
behaves differently on 32-bit and 64-bit platforms. It's not the same
sub-tests that fail though. The PR is about message 324, while
currently messages 56 and 259 fail.
I am fixing these tests as soon as I notice them, from my point of view
there is no need to file a PR for that. For 259 I'm unsure how to fix
it for all platforms at once, therefore I only committed some
documentation that the test fails on i386.
In my pre-commit hook, I verify that the tests run fine on x86_64, to
prevent me from committing complete crap. I should probably add i386 to
that as well. From lint's point of view, there is no difference between
i386 and sparc, they are both ILP32 platforms. Therefore I think its
unnecessary to test sparc or sparc64 as well.
Roland
From: "Roland Illig" <rillig@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/55976 CVS commit: src/usr.bin/xlint/lint1
Date: Mon, 1 Mar 2021 00:51:01 +0000
Module Name: src
Committed By: rillig
Date: Mon Mar 1 00:51:01 UTC 2021
Modified Files:
src/usr.bin/xlint/lint1: lex.c
Log Message:
lint: only warn once about integer constant overflow on 32-bit
Previously, the test msg_056.c warned twice about the integer literal,
but only on 32-bit platforms. On 64-bit platforms, there was only a
single warning since the integer constant was converted to type
__uint128_t, and this prevented the second warning. On 32-bit targets,
there is no __uint128_t though.
Fixes part of PR bin/55976.
To generate a diff of this commit:
cvs rdiff -u -r1.10 -r1.11 src/usr.bin/xlint/lint1/lex.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->closed
State-Changed-By: rillig@NetBSD.org
State-Changed-When: Sat, 12 Feb 2022 21:11:18 +0000
State-Changed-Why:
The lint tests no longer fail. It is possible now to add
platform-specific tests, which was the original problem.
Thanks for the PR.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.46 2020/01/03 16:35:01 leot Exp $
$NetBSD: gnats_config.sh,v 1.9 2014/08/02 14:16:04 spz Exp $
Copyright © 1994-2020
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.