NetBSD Problem Report #55996

From mouse@Stone.Rodents-Montreal.ORG  Wed Feb 17 14:00:41 2021
Return-Path: <mouse@Stone.Rodents-Montreal.ORG>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 20CFB1A9217
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 17 Feb 2021 14:00:41 +0000 (UTC)
Message-Id: <202102171400.JAA28091@Stone.Rodents-Montreal.ORG>
Date: Wed, 17 Feb 2021 09:00:37 -0500 (EST)
From: Mouse <mouse@Rodents-Montreal.ORG>
Reply-To: mouse@Rodents-Montreal.ORG
To: gnats-bugs@NetBSD.org
Subject: postinstall fix manconf could be more helpful
X-Send-Pr-Version: 3.95

>Number:         55996
>Category:       toolchain
>Synopsis:       postinstall fix manconf could be more helpful
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    toolchain-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 17 14:05:00 +0000 2021
>Originator:     Mouse
>Release:        NetBSD 9.1
>Organization:
	Dis-
>Environment:
System: NetBSD example.example.com 9.1 NetBSD 9.1 (GENERIC) #0: Sun Oct 18 19:24:30 UTC 2020 mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
	I'm not sure toolchain is the right category.  It looked
	likeliest for something bearing on the tools used to build and
	install the world; of course, please reassign if I guessed
	wrong in this regard.

	This machine was upgrade-installed from 5.2 to 9.1.  I then did
	a build-of-the-world, because its end use involves a few tweaks
	to the system.  But, when fixing postinstall whines, I found
	manconf to be..unhelpful.  It just says you might want to copy
	a new version in, without any indication where a new version
	might be found.  (Fortunately, there is only one man.conf under
	/usr/src, but it still would be nice to be pointed at it.)
>How-To-Repeat:
	Upgrade a 5.2 machine to 9.1, do a build of the world, try to
	fix the things postinstall complains about, and notice it's
	difficult to fix manconf.
>Fix:
	Um...change the message printed by postinstall?  Possibly
	something like

 		msg "The file /etc/man.conf has not been adapted to mandoc usage; you"
-		msg "probably want to copy a new version over. ${notfixed}"
+		msg "probably want to copy a new version over,"
+		msg "such as /usr/src/etc/man.conf.${notfixed:+  }${notfixed}"
 	fi

	(That (a) is hand-constructed and hence (b) probably contains
	errors as is, (c) probably should have /usr/src replaced with
	wherever the -s argument is stashed, and (d) admittedly
	contains an attempt at the aesthetics fix of eliminating the
	whitespace before $notfixed if $notfixed is empty, which
	arguably should be a separate change but doesn't seem worth its
	own PR.  But it should give the idea.)

Home	PR Database Search