NetBSD Problem Report #56119

From john@lilith.zia.io  Tue Apr 20 20:14:55 2021
Return-Path: <john@lilith.zia.io>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 981C51A9247
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 20 Apr 2021 20:14:55 +0000 (UTC)
Message-Id: <20210420201451.5E4CF35EF7E@lilith.zia.io>
Date: Tue, 20 Apr 2021 20:12:55 +0000 (UTC)
From: john@ziaspace.com
Reply-To: john@ziaspace.com
To: gnats-bugs@NetBSD.org
Subject: multimedia/ffmpeg4 fails on NetBSD/m68k
X-Send-Pr-Version: 3.95

>Number:         56119
>Category:       pkg
>Synopsis:       multimedia/ffmpeg4 fails on NetBSD/m68k
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 20 20:15:00 +0000 2021
>Closed-Date:    Fri May 07 11:59:09 +0000 2021
>Last-Modified:  Fri May 07 11:59:09 +0000 2021
>Originator:     John Klos
>Release:        NetBSD 9.0_STABLE
>Organization:

>Environment:


System: NetBSD lilith.zia.io 9.0_STABLE NetBSD 9.0_STABLE (LILITH-$Revision: 9.0p $) #0: Sun May 10 18:23:43 UTC 2020 john@daisy.zia.io:/usr/obj-amiga/sys/arch/amiga/compile/LILITH amiga
Architecture: m68k
Machine: amiga
>Description:

Compiling multimedia/ffmpeg4 on NetBSD/m68k fails. The previous version of 
ffmpeg4 compiles and runs fine.

In file included from fftools/cmdutils.c:37:0:
./libavresample/avresample.h:158:13: note: declared here
CC      fftools/ffmpeg.o
fftools/ffmpeg.c: In function 'init_input_stream':
fftools/ffmpeg.c:2963:9: warning: 'thread_safe_callbacks' is deprecated [-Wdeprecated-declarations]
In file included from ./libavformat/avformat.h:312:0,
                 from fftools/ffmpeg.c:43:
./libavcodec/avcodec.h:1812:9: note: declared here
LD      ffmpeg4_g
ld: /usr/lib/libc.so and /usr/lib/crt0.o: warning: multiple common of `environ'
ld: libavformat/libavformat.so: undefined reference to `__atomic_fetch_sub_8'
ld: libavformat/libavformat.so: undefined reference to `__atomic_load_8'
ld: libavformat/libavformat.so: undefined reference to `__atomic_store_8'
ld: libavformat/libavformat.so: undefined reference to `__atomic_fetch_add_8'
gmake: *** [Makefile:124: ffmpeg4_g] Error 1
*** Error code 2

>How-To-Repeat:

>Fix:


>Release-Note:

>Audit-Trail:
From: nia <nia@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/56119: multimedia/ffmpeg4 fails on NetBSD/m68k
Date: Tue, 20 Apr 2021 20:28:39 +0000

 --MxZaDA5EFSq5NxMJ
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline

 Please test this diff

 --MxZaDA5EFSq5NxMJ
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="m68k-atomic64.mk"

 Index: mk/atomic64.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mk/atomic64.mk,v
 retrieving revision 1.2
 diff -u -r1.2 atomic64.mk
 --- mk/atomic64.mk	1 Jan 2021 00:06:29 -0000	1.2
 +++ mk/atomic64.mk	20 Apr 2021 20:27:35 -0000
 @@ -21,4 +21,8 @@
  .  include "../../devel/libatomic/buildlink3.mk"
  .endif

 +.if ${MACHINE_ARCH} == "m68k"
 +.  include "../../devel/libatomic/buildlink3.mk"
 +.endif
 +
  .endif
 Index: multimedia/ffmpeg4/Makefile.common
 ===================================================================
 RCS file: /cvsroot/pkgsrc/multimedia/ffmpeg4/Makefile.common,v
 retrieving revision 1.23
 diff -u -r1.23 Makefile.common
 --- multimedia/ffmpeg4/Makefile.common	10 Apr 2021 08:50:43 -0000	1.23
 +++ multimedia/ffmpeg4/Makefile.common	20 Apr 2021 20:27:35 -0000
 @@ -85,4 +85,5 @@
  .include "../../devel/zlib/buildlink3.mk"
  .include "../../textproc/libxml2/buildlink3.mk"
  .include "../../mk/pthread.buildlink3.mk"
 +.include "../../mk/atomic64.mk"
  .include "../../mk/bsd.pkg.mk"

 --MxZaDA5EFSq5NxMJ--

From: "John D. Baker" <jdbaker@consolidated.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/56119: multimedia/ffmpeg4 fails on NetBSD/m68k
Date: Wed, 21 Apr 2021 08:35:56 -0500 (CDT)

 Not just m68k, but likely all 32-bit platforms.  I get exactly the same
 failure building on netbsd-9/i386.

 -- 
 |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
 |\ / jdbaker[snail]consolidated[flyspeck]net  OpenBSD            FreeBSD
 | X  No HTML/proprietary data in email.   BSD just sits there and works!
 |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645

From: "John D. Baker" <jdbaker@consolidated.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/56119: multimedia/ffmpeg4 fails on NetBSD/m68k
Date: Wed, 21 Apr 2021 09:04:12 -0500 (CDT)

 On Wed, 21 Apr 2021, John D. Baker wrote:

 > I've copied the patch by nia, modified for i386, and am re-trying the
 > build now...

 I thought it was weird, but now I see the issue.  "i386" is handled
 through "-march=586", but until the patch, "ffmpeg4" didn't attempt
 to include "../../mk/atomic64.mk".

 Reverting that part of the patch and trying again.

 -- 
 |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
 |\ / jdbaker[snail]consolidated[flyspeck]net  OpenBSD            FreeBSD
 | X  No HTML/proprietary data in email.   BSD just sits there and works!
 |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645

From: "John D. Baker" <jdbaker@consolidated.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/56119: multimedia/ffmpeg4 fails on NetBSD/m68k
Date: Wed, 21 Apr 2021 08:48:03 -0500 (CDT)

 I've copied the patch by nia, modified for i386, and am re-trying the
 build now...

 -- 
 |/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
 |\ / jdbaker[snail]consolidated[flyspeck]net  OpenBSD            FreeBSD
 | X  No HTML/proprietary data in email.   BSD just sits there and works!
 |/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645

From: John Klos <john@ziaspace.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56119: multimedia/ffmpeg4 fails on NetBSD/m68k
Date: Sun, 2 May 2021 19:12:24 +0000 (UTC)

 > Please test this diff

 A fully clean build with those diffs gives the same error.

 John

From: Rin Okuyama <rokuyama.rk@gmail.com>
To: gnats-bugs@netbsd.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
 pkgsrc-bugs@netbsd.org, john@ziaspace.com
Cc: 
Subject: Re: pkg/56119: multimedia/ffmpeg4 fails on NetBSD/m68k
Date: Mon, 3 May 2021 23:51:06 +0900

 I observe a similar error for NetBSD/powerpc. Just include
 mk/atomic64.mk is not sufficient, and I need

 ----
 Index: devel/libatomic/buildlink3.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/libatomic/buildlink3.mk,v
 retrieving revision 1.2
 diff -p -u -r1.2 buildlink3.mk
 --- devel/libatomic/buildlink3.mk	2 Jun 2020 21:27:05 -0000	1.2
 +++ devel/libatomic/buildlink3.mk	3 May 2021 14:49:26 -0000
 @@ -9,6 +9,10 @@ BUILDLINK_API_DEPENDS.libatomic+=	libato
   BUILDLINK_ABI_DEPENDS.libatomic+=	libatomic>=10.0
   BUILDLINK_PKGSRCDIR.libatomic?=		../../devel/libatomic

 +# XXX
 +BUILDLINK_LDADD.libatomic+=	-latomic
 +BUILDLINK_LDFLAGS.libatomic?=	${BUILDLINK_LDADD.libatomic}
 +
   .include "../../mk/pthread.buildlink3.mk"
   .endif

 ----

 Thoughts?

 Thanks,
 rin

From: John Klos <john@ziaspace.com>
To: Rin Okuyama <rokuyama.rk@gmail.com>
Cc: gnats-bugs@netbsd.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
        pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56119: multimedia/ffmpeg4 fails on NetBSD/m68k
Date: Tue, 4 May 2021 07:29:47 +0000 (UTC)

 > I observe a similar error for NetBSD/powerpc. Just include
 > mk/atomic64.mk is not sufficient, and I need
 >
 > ----
 > Index: devel/libatomic/buildlink3.mk
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/devel/libatomic/buildlink3.mk,v
 > retrieving revision 1.2
 > diff -p -u -r1.2 buildlink3.mk
 > --- devel/libatomic/buildlink3.mk	2 Jun 2020 21:27:05 -0000	1.2
 > +++ devel/libatomic/buildlink3.mk	3 May 2021 14:49:26 -0000
 > @@ -9,6 +9,10 @@ BUILDLINK_API_DEPENDS.libatomic+=	libato
 > BUILDLINK_ABI_DEPENDS.libatomic+=	libatomic>=10.0
 > BUILDLINK_PKGSRCDIR.libatomic?=		../../devel/libatomic
 > +# XXX
 > +BUILDLINK_LDADD.libatomic+=	-latomic
 > +BUILDLINK_LDFLAGS.libatomic?=	${BUILDLINK_LDADD.libatomic}
 > +
 > .include "../../mk/pthread.buildlink3.mk"
 > .endif
 > ----

 This fixes the build and provides a working ffmpeg4 binary. It fixes 
 net/bind916, too.

 Thanks!
 John

From: nia <nia@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/56119: multimedia/ffmpeg4 fails on NetBSD/m68k
Date: Fri, 7 May 2021 06:32:19 +0000

 On Mon, May 03, 2021 at 02:55:02PM +0000, Rin Okuyama wrote:
 >  Thoughts?
 >  
 >  Thanks,
 >  rin
 >  

 Please commit it if it works.

From: "Rin Okuyama" <rin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56119 CVS commit: pkgsrc/mk
Date: Fri, 7 May 2021 11:32:01 +0000

 Module Name:	pkgsrc
 Committed By:	rin
 Date:		Fri May  7 11:32:01 UTC 2021

 Modified Files:
 	pkgsrc/mk: atomic64.mk

 Log Message:
 64-bit atomic ops are lacking for m68k.

 Part of PR pkg/56119 from nia.

 XXX
 We need this for other architectures also...


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/mk/atomic64.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Rin Okuyama <rokuyama.rk@gmail.com>
To: "gnats-bugs@NetBSD.org" <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/56119 (multimedia/ffmpeg4 fails on NetBSD/m68k)
Date: Fri, 7 May 2021 20:35:27 +0900

 -------- Forwarded Message --------
 Subject: CVS commit: pkgsrc/devel/libatomic
 Date: Fri, 7 May 2021 11:34:48 +0000
 From: Rin Okuyama <rin@netbsd.org>
 Reply-To: rin@netbsd.org
 To: pkgsrc-changes@NetBSD.org

 Module Name:	pkgsrc
 Committed By:	rin
 Date:		Fri May  7 11:34:48 UTC 2021

 Modified Files:
 	pkgsrc/devel/libatomic: buildlink3.mk

 Log Message:
 Set BUILDLINK_{LDADD,LDFLAGS}, which is required at least for
 multimedia/ffmpeg4 and net/bind916 (reported by jklos).


 To generate a diff of this commit:
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/devel/libatomic/buildlink3.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


From: "Rin Okuyama" <rin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56119 CVS commit: pkgsrc/multimedia/ffmpeg4
Date: Fri, 7 May 2021 11:40:11 +0000

 Module Name:	pkgsrc
 Committed By:	rin
 Date:		Fri May  7 11:40:11 UTC 2021

 Modified Files:
 	pkgsrc/multimedia/ffmpeg4: Makefile Makefile.common

 Log Message:
 ffmpeg4: Include atomic64.mk for m68k and powerpc. Bump revision.

 Fixes PR pkg/56119 from nia.


 To generate a diff of this commit:
 cvs rdiff -u -r1.49 -r1.50 pkgsrc/multimedia/ffmpeg4/Makefile
 cvs rdiff -u -r1.23 -r1.24 pkgsrc/multimedia/ffmpeg4/Makefile.common

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: rin@NetBSD.org
State-Changed-When: Fri, 07 May 2021 11:59:09 +0000
State-Changed-Why:
Should be fixed now.

XXX
We need to adjust atomic64.mk for architectures other than i386, m68k, and
powerpc, that do not have 64-bit atomic ops...


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.