NetBSD Problem Report #56249

From paul@whooppee.com  Tue Jun 15 15:56:25 2021
Return-Path: <paul@whooppee.com>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 344C31A921F
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 15 Jun 2021 15:56:25 +0000 (UTC)
Message-Id: <20210615155622.530FC30F2C4@speedy.whooppee.com>
Date: Tue, 15 Jun 2021 08:56:22 -0700 (PDT)
From: paul@whooppee.com
Reply-To: paul@whooppee.com
To: gnats-bugs@NetBSD.org
Subject: ``dump -[Ww]'' exits on missing NAME=label
X-Send-Pr-Version: 3.95

>Number:         56249
>Category:       bin
>Synopsis:       ``dump -[Ww]'' exits on missing NAME=label
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 15 16:00:00 +0000 2021
>Last-Modified:  Mon Aug 21 12:15:01 +0000 2023
>Originator:     Paul Goyette
>Release:        NetBSD 9.99.84
>Organization:
+--------------------+--------------------------+----------------------+
| Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:    |
| (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul@whooppee.com    |
| Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette@netbsd.org  |
|                    |                          | pgoyette99@gmail.com |
+--------------------+--------------------------+----------------------+
>Environment:


System: NetBSD speedy.whooppee.com 9.99.84 NetBSD 9.99.84 (SPEEDY 2021-06-09 18:05:06 UTC) #0: Wed Jun 9 20:58:57 UTC 2021 paul@speedy.whooppee.com:/build/netbsd-local/obj/amd64/sys/arch/amd64/compile/SPEEDY amd64
Architecture: x86_64
Machine: amd64
>Description:

The dump(8) command, with the -w or -W command line option, fails "hard"
if there is a line in /etc/fstab with NAME=label in the first field and
no partition currently exists with that name.  This causes the entire
scan for filesystem-needs-dump to abort, rather than reporting on the
remaining partitions.

Note that if the partition is specified as /dev/sd0 the operation will
succeed even if the specified device does not exist.  It would be
useful if dump(8) would treat a missing NAME=label similarly.
>How-To-Repeat:

See above.
>Fix:
Please


>Audit-Trail:
From: Paul Goyette <paul@whooppee.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/56249: ``dump -[Ww]'' exits on missing NAME=label
Date: Thu, 27 Jan 2022 08:29:10 -0800 (PST)

 This doesn't seem to be specific to dump(8), but rather it is an
 artifact of the way we're handling the NAME= stuff in fstab.

 In particular, if the device containing the named partition isn't
 currently attached, the translation fails, and it seems that most
 consumers treat this as a fatal error.  In contrast, when a
 "legacy" partition spec refers to a currently-not-present device
 the condition is silently ignored.

 It would be much more useful if the NAME= translation failure
 would be silently ignored.  This would allow for better handling
 of removable GPT-format devices.



 +--------------------+--------------------------+----------------------+
 | Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:    |
 | (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul@whooppee.com    |
 | Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette@netbsd.org  |
 | & Network Engineer |                          | pgoyette99@gmail.com |
 +--------------------+--------------------------+----------------------+

From: "Michael van Elst" <mlelstv@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56249 CVS commit: src/sbin/dump
Date: Mon, 14 Mar 2022 18:38:11 +0000

 Module Name:	src
 Committed By:	mlelstv
 Date:		Mon Mar 14 18:38:11 UTC 2022

 Modified Files:
 	src/sbin/dump: optr.c

 Log Message:
 Silently ignore fstab entries with NAME= entries that cannot be resolved.
 Fixes PR 56249.


 To generate a diff of this commit:
 cvs rdiff -u -r1.43 -r1.44 src/sbin/dump/optr.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56249 CVS commit: [netbsd-9] src/sbin/dump
Date: Mon, 21 Aug 2023 12:14:23 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Mon Aug 21 12:14:23 UTC 2023

 Modified Files:
 	src/sbin/dump [netbsd-9]: optr.c

 Log Message:
 Pull up following revision(s) (requested by manu in ticket #1717):

 	sbin/dump/optr.c: revision 1.44

 Silently ignore fstab entries with NAME= entries that cannot be resolved.

 Fixes PR 56249.


 To generate a diff of this commit:
 cvs rdiff -u -r1.43 -r1.43.2.1 src/sbin/dump/optr.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search