NetBSD Problem Report #56342

From www@netbsd.org  Sun Aug  1 12:35:32 2021
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id B68B51A921F
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  1 Aug 2021 12:35:32 +0000 (UTC)
Message-Id: <20210801123531.5C67E1A923A@mollari.NetBSD.org>
Date: Sun,  1 Aug 2021 12:35:31 +0000 (UTC)
From: jonthn+pkgsrc@pinacea.com
Reply-To: jonthn+pkgsrc@pinacea.com
To: gnats-bugs@NetBSD.org
Subject: Fix developers/lua-compat53
X-Send-Pr-Version: www-1.0

>Number:         56342
>Category:       pkg
>Synopsis:       Fix devel/lua-compat53
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    macos-pkg-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Aug 01 12:40:00 +0000 2021
>Last-Modified:  Sat May 18 19:30:53 +0000 2024
>Originator:     Jonathan Buschmann
>Release:        current
>Organization:
>Environment:
>Description:
devel/lua-compat53 does not link on macOS as it's using -shared and -bundle at the same time.
Similar to the problem for devel/lua-BitOp

Below a possible fix.
>How-To-Repeat:

>Fix:
diff --git i/devel/lua-compat53/Makefile w/devel/lua-compat53/Makefile
index 3c1151a01ce..cc4ef0361f7 100644
--- i/devel/lua-compat53/Makefile
+++ w/devel/lua-compat53/Makefile
@@ -21,6 +21,12 @@ INSTALLATION_DIRS+=	${LUA_LDIR} ${LUA_CDIR} ${LUA_INCDIR}
 INSTALLATION_DIRS+=	${LUA_LDIR}/compat53
 INSTALLATION_DIRS+=	${LUA_CDIR}/compat53

+.include "../../mk/bsd.prefs.mk"
+
+.if ${OPSYS} == "Darwin"
+MAKE_ENV+=		NO_SHARED_FLAG=true
+.endif
+
 pre-build:
 	${CP} -f ${FILESDIR}/Makefile ${WRKSRC}/Makefile

diff --git i/devel/lua-compat53/files/Makefile w/devel/lua-compat53/files/Makefile
index 28330669a7a..3fd065bccfe 100644
--- i/devel/lua-compat53/files/Makefile
+++ w/devel/lua-compat53/files/Makefile
@@ -1,7 +1,9 @@
 # $NetBSD: Makefile,v 1.2 2020/07/11 13:48:49 nia Exp $

 CFLAGS+=	-fPIC -Wall
+.if empty(NO_SHARED_FLAG:M*)
 LDFLAGS+=	-shared
+.endif

 all: utf8.so table.so string.so tests/testmod.so


>Release-Note:

>Audit-Trail:
From: nia <nia@NetBSD.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/56342: Fix developers/lua-compat53
Date: Sun, 1 Aug 2021 12:45:17 +0000

 Where is the -bundle flag even coming from? I don't understand.

Responsible-Changed-From-To: pkg-manager->macos-pkg-people
Responsible-Changed-By: bsiegert@NetBSD.org
Responsible-Changed-When: Thu, 04 Nov 2021 10:05:38 +0000
Responsible-Changed-Why:
Darwin issue


>Unformatted:

Home	PR Database Search