NetBSD Problem Report #56389

From martin@aprisoft.de  Sun Sep  5 18:38:05 2021
Return-Path: <martin@aprisoft.de>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id B9D291A9239
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  5 Sep 2021 18:38:05 +0000 (UTC)
Message-Id: <20210905183755.8E80E5CC84B@emmas.aprisoft.de>
Date: Sun,  5 Sep 2021 20:37:55 +0200 (CEST)
From: martin@NetBSD.org
Reply-To: martin@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: build.sh fails if source is cloned from git but git is not installed on the build host
X-Send-Pr-Version: 3.95

>Number:         56389
>Category:       toolchain
>Synopsis:       build.sh fails if source is cloned from git but git is not installed on the build host
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Sep 05 18:40:00 +0000 2021
>Closed-Date:    Wed Sep 08 04:10:10 +0000 2021
>Last-Modified:  Wed Sep 08 04:10:10 +0000 2021
>Originator:     Martin Husemann
>Release:        NetBSD 9.99.86
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD whoever-brings-the-night.aprisoft.de 9.99.86 NetBSD 9.99.86 (WHOEVER) #361: Wed Jul 7 15:16:16 CEST 2021 martin@seven-days-to-the-wolves.aprisoft.de:/work/src/sys/arch/sparc64/compile/WHOEVER sparc64
Architecture: sparc64
Machine: sparc64
>Description:

After cloning sources from git, I am trying to build on multiple clients
which do not have git installed (and no connectivity to the outside).

Example command line:

===> build.sh command:    /home/source/ab/HEAD/src/build.sh -m acorn32 -B 202109010648Z -V NETBSD_OFFICIAL_RELEASE=no -D /home/builds/ab/HEAD/acorn32/202109010648Z-dest -M /home/builds/ab/HEAD/acorn32/202109010648Z-obj -R /home/builds/ab/HEAD/acorn32/202109010648Z-rlse -T /home/builds/ab/HEAD/acorn32/202109010648Z-tools -U -X /home/source/ab/HEAD/xsrc -P -x -N0 -V TMPDIR=/tmp -V BUILD=yes -V MAKECONF=/home/builds/etc/make.conf -V MKDEBUG=yes -j16 release iso-image

This fails with:

===> Tools built to /home/builds/ab/HEAD/acorn32/202109010648Z-tools
/home/source/ab/HEAD/src/build.sh: git: not found

ERROR: Failed to get timestamp for vcs=git in '/home/source/ab/HEAD/src/'
*** BUILD ABORTED ***

Work around would be to prune .git in the top of the source dir, but that
is kinda ugly. An env var or build.sh -V override/hack would be good enough.


>How-To-Repeat:
s/a

>Fix:
n/a

>Release-Note:

>Audit-Trail:
From: Martin Husemann <martin@duskware.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: toolchain/56389: build.sh fails if source is cloned from git but
 git is not installed on the build host
Date: Tue, 7 Sep 2021 19:29:32 +0200

 As Joerg pointed out, the -P argument for the clients makes no sense
 here. Will remove it and use -V MKREPRO_TIMESTAMP=... with the correct
 value from the git machine instead.

 We still need to strip the top level .git dir from the sourcesets,
 but that is an orthogonal issue.

 Martin

From: "Martin Husemann" <martin@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56389 CVS commit: src/distrib/sets
Date: Tue, 7 Sep 2021 18:02:46 +0000

 Module Name:	src
 Committed By:	martin
 Date:		Tue Sep  7 18:02:46 UTC 2021

 Modified Files:
 	src/distrib/sets: makesrctars

 Log Message:
 PR 56389: do not include top level .git or .hg directories
 in source sets.


 To generate a diff of this commit:
 cvs rdiff -u -r1.42 -r1.43 src/distrib/sets/makesrctars

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->pending-pullups
State-Changed-By: martin@NetBSD.org
State-Changed-When: Tue, 07 Sep 2021 18:12:58 +0000
State-Changed-Why:
[pullup-9 #1344]
[pullup-8 #1694]


From: "Soren Jacobsen" <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56389 CVS commit: [netbsd-8] src/distrib/sets
Date: Tue, 7 Sep 2021 22:28:31 +0000

 Module Name:	src
 Committed By:	snj
 Date:		Tue Sep  7 22:28:31 UTC 2021

 Modified Files:
 	src/distrib/sets [netbsd-8]: makesrctars

 Log Message:
 Pull up following revision(s) (requested by martin in ticket #1694):
 	distrib/sets/makesrctars: revision 1.43
 PR 56389: do not include top level .git or .hg directories
 in source sets.


 To generate a diff of this commit:
 cvs rdiff -u -r1.41 -r1.41.4.1 src/distrib/sets/makesrctars

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Soren Jacobsen" <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56389 CVS commit: [netbsd-9] src/distrib/sets
Date: Tue, 7 Sep 2021 22:29:46 +0000

 Module Name:	src
 Committed By:	snj
 Date:		Tue Sep  7 22:29:46 UTC 2021

 Modified Files:
 	src/distrib/sets [netbsd-9]: makesrctars

 Log Message:
 Pull up following revision(s) (requested by martin in ticket #1344):
 	distrib/sets/makesrctars: revision 1.43
 PR 56389: do not include top level .git or .hg directories
 in source sets.


 To generate a diff of this commit:
 cvs rdiff -u -r1.42 -r1.42.2.1 src/distrib/sets/makesrctars

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: martin@NetBSD.org
State-Changed-When: Wed, 08 Sep 2021 04:10:10 +0000
State-Changed-Why:
Fixed on all active branches


>Unformatted:

Home	PR Database Search