NetBSD Problem Report #56419

From jschauma@netmeister.org  Tue Sep 28 03:05:32 2021
Return-Path: <jschauma@netmeister.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 7CA231A921F
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 28 Sep 2021 03:05:32 +0000 (UTC)
Message-Id: <20210928030529.46EFE8586C@panix.netmeister.org>
Date: Mon, 27 Sep 2021 23:05:29 -0400 (EDT)
From: jschauma@netmeister.org
Reply-To: jschauma@netmeister.org
To: gnats-bugs@NetBSD.org
Subject: duplicate 'tm_isdst' in ctime(3)
X-Send-Pr-Version: 3.95

>Number:         56419
>Category:       misc
>Synopsis:       ctime(3) lists 'tm_isdst' twice
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 28 03:10:00 +0000 2021
>Closed-Date:    Sat Oct 09 23:24:57 +0000 2021
>Last-Modified:  Sat Oct 09 23:24:57 +0000 2021
>Originator:     Jan Schaumann
>Release:        NetBSD 9.2
>Organization:

>Environment:
>Description:

The manual page for ctime(3) lists the 'tm_isdst' field twice:

     Declarations of all the functions and externals, and the tm structure,
     are in the <time.h> header file.  The structure (of type) struct tm
     includes the following fields:
     [...]
       int tm_yday;     /* day of year (0 - 365) */
       int tm_isdst;    /* is summer time in effect? */
        int tm_isdst;   /* is daylight saving time in effect? */
       char *tm_zone;   /* abbreviation of timezone name (optional) */



>How-To-Repeat:
	man ctime
>Fix:

--- ctime.3.orig        2021-09-27 23:42:57.905264572 +0000
+++ ctime.3     2021-09-27 23:43:30.179095280 +0000
@@ -333,8 +333,7 @@
        int tm_year;     /* year - 1900 */
        int tm_wday;     /* day of week (Sunday = 0) */
        int tm_yday;     /* day of year (0 - 365) */
-       int tm_isdst;    /* is summer time in effect? */
-       int tm_isdst;   /* is daylight saving time in effect? */
+       int tm_isdst;    /* is daylight saving time in effect? */
        char *tm_zone;   /* abbreviation of timezone name (optional) */
        long tm_gmtoff;  /* offset from UT in seconds (optional) */
.Ed

>Release-Note:

>Audit-Trail:
From: "Kimmo Suominen" <kim@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56419 CVS commit: src/lib/libc/time
Date: Tue, 28 Sep 2021 06:45:09 +0000

 Module Name:	src
 Committed By:	kim
 Date:		Tue Sep 28 06:45:09 UTC 2021

 Modified Files:
 	src/lib/libc/time: ctime.3

 Log Message:
 Remove duplicate tm_isdst.  Fixes PR misc/56419 for HEAD.


 To generate a diff of this commit:
 cvs rdiff -u -r1.61 -r1.62 src/lib/libc/time/ctime.3

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: gutteridge@NetBSD.org
State-Changed-When: Sat, 09 Oct 2021 23:24:57 +0000
State-Changed-Why:
Patch applied in HEAD, probably not significant enough to pull up.

>Unformatted:

Home	PR Database Search