NetBSD Problem Report #56537

From www@netbsd.org  Sun Dec  5 11:12:20 2021
Return-Path: <www@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 5A1E51A923A
	for <gnats-bugs@gnats.NetBSD.org>; Sun,  5 Dec 2021 11:12:20 +0000 (UTC)
Message-Id: <20211205111218.C05E01A923B@mollari.NetBSD.org>
Date: Sun,  5 Dec 2021 11:12:18 +0000 (UTC)
From: pekdon@gmail.com
Reply-To: pekdon@gmail.com
To: gnats-bugs@NetBSD.org
Subject: jemalloc fails to build on Solaris 10
X-Send-Pr-Version: www-1.0

>Number:         56537
>Category:       pkg
>Synopsis:       jemalloc fails to build on Solaris 10
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          feedback
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 05 11:15:00 +0000 2021
>Closed-Date:    
>Last-Modified:  Mon May 23 00:35:54 +0000 2022
>Originator:     Claes Nästén
>Release:        trunk 2021-12-03
>Organization:
>Environment:
SunOS 5.10 i86pc i386 i86pc

>Description:
Building jemalloc failed with the following error:
>How-To-Repeat:
Build jemalloc on Solaris 10
>Fix:
Looking at the top level Makefile.in it sets the shell:

SHELL := /bin/sh

This is turn seems to lead to a generated file not being generated.

Just changing SHELL := /bin/sh to SHELL ?= /bin/sh resolved the issue for me.

--- a/devel/jemalloc/patches/patch-Makefile.in
+++ b/devel/jemalloc/patches/patch-Makefile.in
@@ -2,9 +2,18 @@ $NetBSD: patch-Makefile.in,v 1.2 2016/12/13 21:52:22 maya Exp $

 Fix permissions of installed static libraries.

---- Makefile.in.orig   2016-11-16 22:15:43.000000000 +0100
-+++ Makefile.in        2016-11-16 22:17:04.000000000 +0100
-@@ -348,8 +348,8 @@
+--- Makefile.in.orig   2019-08-05 20:02:00.000000000 +0000
++++ Makefile.in
+@@ -6,7 +6,7 @@ vpath % .
+ # Clear the default suffixes, so that built-in rules are not used.
+ .SUFFIXES :
+ 
+-SHELL := /bin/sh
++SHELL ?= /bin/sh
+ 
+ CC := @CC@
+ CXX := @CXX@
+@@ -482,8 +482,8 @@ endif
  install_lib_static: $(STATIC_LIBS)
        $(INSTALL) -d $(LIBDIR)
        @for l in $(STATIC_LIBS); do \

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/56537: jemalloc fails to build on Solaris 10
Date: Mon, 23 May 2022 00:00:23 +0000

 On Sun, Dec 05, 2021 at 11:15:01AM +0000, pekdon@gmail.com wrote:
  > Looking at the top level Makefile.in it sets the shell:
  > 
  > SHELL := /bin/sh
  > 
  > This is turn seems to lead to a generated file not being generated.
  > 
  > Just changing SHELL := /bin/sh to SHELL ?= /bin/sh resolved the
  > issue for me.

 That will, unfortunately, cause it to use whatever's in the build
 user's environment, which might be nothing and might even be csh.

 I've changed the pkgsrc makefile to set SHELL on the make command line
 instead, and set it from CONFIG_SHELL, which should override the
 setting in the makefile with something useful.

 -- 
 David A. Holland
 dholland@netbsd.org

From: David Holland <dholland-pkgchanges@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/56537: jemalloc fails to build on Solaris 10
Date: Mon, 23 May 2022 00:02:01 +0000

 Forgot to cite the PR number in the commit:

    ------

 From: "David A. Holland" <dholland@netbsd.org>
 To: pkgsrc-changes@NetBSD.org
 Subject: CVS commit: pkgsrc/devel/jemalloc
 Date: Sun, 22 May 2022 23:58:43 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Sun May 22 23:58:43 UTC 2022

 Modified Files:
 	pkgsrc/devel/jemalloc: Makefile

 Log Message:
 devel/jemalloc: set SHELL explicitly so it gets something useful on Solaris


 To generate a diff of this commit:
 cvs rdiff -u -r1.19 -r1.20 pkgsrc/devel/jemalloc/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.


 Modified files:

 Index: pkgsrc/devel/jemalloc/Makefile
 diff -u pkgsrc/devel/jemalloc/Makefile:1.19 pkgsrc/devel/jemalloc/Makefile:1.20
 --- pkgsrc/devel/jemalloc/Makefile:1.19	Mon May 24 19:49:58 2021
 +++ pkgsrc/devel/jemalloc/Makefile	Sun May 22 23:58:43 2022
 @@ -1,4 +1,4 @@
 -# $NetBSD: Makefile,v 1.19 2021/05/24 19:49:58 wiz Exp $
 +# $NetBSD: Makefile,v 1.20 2022/05/22 23:58:43 dholland Exp $

  DISTNAME=	jemalloc-5.2.1
  PKGREVISION=	3
 @@ -21,6 +21,7 @@ GNU_CONFIGURE=		yes
  CONFIGURE_ARGS+=	--enable-xmalloc
  CONFIGURE_ARGS+=	--with-xslroot=${PREFIX}/share/xsl/docbook/
  PKGCONFIG_OVERRIDE=	jemalloc.pc.in
 +BUILD_MAKE_FLAGS+=	SHELL=${CONFIG_SHELL}

  REPLACE_PERL=		bin/jeprof.in


State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 23 May 2022 00:35:54 +0000
State-Changed-Why:
hopefully fixed, please test


>Unformatted:

Home	PR Database Search