NetBSD Problem Report #56553

From tsutsui@ceres.dti.ne.jp  Sun Dec 19 09:31:24 2021
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id B45FA1A9239
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 19 Dec 2021 09:31:24 +0000 (UTC)
Message-Id: <202112190931.1BJ9VE2u009593@ceres.dti.ne.jp>
Date: Sun, 19 Dec 2021 18:31:14 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: "pkg_add firefox" doesn't install pciutils
X-Send-Pr-Version: 3.95

>Number:         56553
>Category:       pkg
>Synopsis:       "pkg_add firefox" doesn't install pciutils
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    ryoon
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 19 09:35:00 +0000 2021
>Closed-Date:    Tue Dec 21 17:42:36 +0000 2021
>Last-Modified:  Tue Dec 21 17:42:36 +0000 2021
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.2
>Organization:
>Environment:
System: NetBSD optiplex 9.2 NetBSD 9.2 (GENERIC) #0: Wed May 12 13:15:55 UTC 2021  mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
Recently pkgsrc/www/firefox has been changed to pull pciutils,
 https://mail-index.netbsd.org/pkgsrc-changes/2021/12/17/msg245287.html
but "pkg_add firefox" doesn't install pciutils.

>How-To-Repeat:
Build and pkg_add firefox.

>Fix:
pkgsrc/sysutils/pciutils/buildlink3.mk has
"BUILDLINK_DEPMETHOD.pciutils?= build"
by default, so maybe all applications that require libpci.so
should have
BUILDLINK_DEPMETHOD.pciutils+= full
line?

Additionally, it would be better to sort all buildlink3.mk
in current mozilla-common.mk.

---
Index: mozilla-common.mk
===================================================================
RCS file: /cvsroot/pkgsrc/www/firefox/mozilla-common.mk,v
retrieving revision 1.213
diff -u -p -d -r1.213 mozilla-common.mk
--- mozilla-common.mk	17 Dec 2021 20:08:42 -0000	1.213
+++ mozilla-common.mk	19 Dec 2021 09:02:54 -0000
@@ -181,14 +181,12 @@ CONFIGURE_ENV.NetBSD+=	ac_cv_thread_keyw
 # In unspecified case, clock_gettime(CLOCK_MONOTONIC, ...) fails.
 CONFIGURE_ENV.NetBSD+=	ac_cv_clock_monotonic=

-.include "../../sysutils/pciutils/buildlink3.mk"
 .include "../../mk/atomic64.mk"
 BUILDLINK_API_DEPENDS.libevent+=	libevent>=1.1
 .include "../../devel/libevent/buildlink3.mk"
 .include "../../devel/libffi/buildlink3.mk"
 BUILDLINK_API_DEPENDS.nspr+=	nspr>=4.32
 .include "../../devel/nspr/buildlink3.mk"
-.include "../../textproc/icu/buildlink3.mk"
 BUILDLINK_API_DEPENDS.nss+=	nss>=3.71
 .include "../../devel/nss/buildlink3.mk"
 .include "../../devel/zlib/buildlink3.mk"
@@ -202,13 +200,16 @@ BUILDLINK_DEPMETHOD.clang=	build
 .include "../../lang/clang/buildlink3.mk"
 RUST_REQ=	1.53.0
 .include "../../lang/rust/rust.mk"
+.include "../../multimedia/ffmpeg4/buildlink3.mk"
 # webrtc option requires internal libvpx
 #BUILDLINK_API_DEPENDS.libvpx+=	libvpx>=1.3.0
 #.include "../../multimedia/libvpx/buildlink3.mk"
 .include "../../net/libIDL/buildlink3.mk"
+BUILDLINK_DEPMETHOD.pciutils+=		full
+.include "../../sysutils/pciutils/buildlink3.mk"
 # textproc/hunspell 1.3 is too old
 #.include "../../textproc/hunspell/buildlink3.mk"
-.include "../../multimedia/ffmpeg4/buildlink3.mk"
+.include "../../textproc/icu/buildlink3.mk"
 .include "../../x11/libXt/buildlink3.mk"
 BUILDLINK_API_DEPENDS.pixman+= pixman>=0.25.2
 .include "../../x11/pixman/buildlink3.mk"

---
Izumi Tsutsui

>Release-Note:

>Audit-Trail:
From: "Maya Rashish" <maya@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/56553 CVS commit: pkgsrc
Date: Sun, 19 Dec 2021 09:48:00 +0000

 Module Name:	pkgsrc
 Committed By:	maya
 Date:		Sun Dec 19 09:48:00 UTC 2021

 Modified Files:
 	pkgsrc/sysutils/flashrom: Makefile
 	pkgsrc/sysutils/hal: Makefile
 	pkgsrc/sysutils/pciutils: buildlink3.mk
 	pkgsrc/sysutils/radeontool: Makefile
 	pkgsrc/sysutils/vbetool: Makefile
 	pkgsrc/sysutils/xentools411: Makefile
 	pkgsrc/sysutils/xentools413: Makefile
 	pkgsrc/sysutils/xentools415: Makefile
 	pkgsrc/www/firefox: Makefile
 	pkgsrc/x11/kde-workspace4: Makefile
 	pkgsrc/x11/qt5-qtwebengine: Makefile

 Log Message:
 sysutils/pciutils: no longer static, remove
 BUILDLINK_DEPMETHOD.pciutils?= build

 And pkgrevision bump consumers.

 Pointed out by tsutsui in PR pkg/56553


 To generate a diff of this commit:
 cvs rdiff -u -r1.13 -r1.14 pkgsrc/sysutils/flashrom/Makefile
 cvs rdiff -u -r1.98 -r1.99 pkgsrc/sysutils/hal/Makefile
 cvs rdiff -u -r1.9 -r1.10 pkgsrc/sysutils/pciutils/buildlink3.mk
 cvs rdiff -u -r1.9 -r1.10 pkgsrc/sysutils/radeontool/Makefile
 cvs rdiff -u -r1.11 -r1.12 pkgsrc/sysutils/vbetool/Makefile
 cvs rdiff -u -r1.29 -r1.30 pkgsrc/sysutils/xentools411/Makefile
 cvs rdiff -u -r1.25 -r1.26 pkgsrc/sysutils/xentools413/Makefile
 cvs rdiff -u -r1.7 -r1.8 pkgsrc/sysutils/xentools415/Makefile
 cvs rdiff -u -r1.504 -r1.505 pkgsrc/www/firefox/Makefile
 cvs rdiff -u -r1.98 -r1.99 pkgsrc/x11/kde-workspace4/Makefile
 cvs rdiff -u -r1.11 -r1.12 pkgsrc/x11/qt5-qtwebengine/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

Responsible-Changed-From-To: pkg-manager->ryoon
Responsible-Changed-By: hauke@NetBSD.org
Responsible-Changed-When: Sun, 19 Dec 2021 18:55:05 +0000
Responsible-Changed-Why:
Over to maintainer.


State-Changed-From-To: open->closed
State-Changed-By: tsutsui@NetBSD.org
State-Changed-When: Tue, 21 Dec 2021 17:42:36 +0000
State-Changed-Why:
Already fixed by maya@


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.