NetBSD Problem Report #56586

From manphiz@gmail.com  Tue Dec 28 11:48:09 2021
Return-Path: <manphiz@gmail.com>
Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	(Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified))
	by mollari.NetBSD.org (Postfix) with ESMTPS id 852591A9239
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 28 Dec 2021 11:48:09 +0000 (UTC)
Message-Id: <20211228114804.77F2822E1CB@yeeloong-netbsd.localdomain>
Date: Tue, 28 Dec 2021 03:48:04 -0800 (PST)
From: manphiz@gmail.com
Reply-To: manphiz@gmail.com
To: gnats-bugs@NetBSD.org
Subject: Support keeping worklog of succeeded packages in pbulk
X-Send-Pr-Version: 3.95

>Number:         56586
>Category:       pkg
>Synopsis:       Support keeping worklog in succeeded packages in pbulk
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 28 11:50:00 +0000 2021
>Last-Modified:  Sat May 21 00:05:00 +0000 2022
>Originator:     manphiz@gmail.com
>Release:        NetBSD 8.2
>Organization:
>Environment:
System: NetBSD yeeloong-netbsd 8.2 NetBSD 8.2 (LOONGSON) #0: Tue Mar 31 05:08:40 UTC 2020 mkrepro@mkrepro.NetBSD.org:/usr/src/sys/arch/evbmips/compile/LOONGSON evbmips
Architecture: mips64el
Machine: evbmips
>Description:

	Currently in pbulk only the logs of failed packages will be
	kept by default, but here is no way to keep the logs of
	successfully built packages, which may be useful for debugging
	packages that experience runtime issues by inspecting build
	logs such as CFLAGS/LDFLAGAS, or possible issues that didn't
	fail the build process.

>How-To-Repeat:
	N/A.  This is a feature suggestion with patch.
>Fix:

	The attached patch added this support by adding a
	"keep_wrklog" option in pbulk.conf.  When this option is set
	to "yes" the pkg-build script will not remove the build log.
	This is tested locally to be working.


Index: files/pbulk/pbulk.conf
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pbulk/files/pbulk/pbulk.conf,v
retrieving revision 1.26
diff -u -p -r1.26 pbulk.conf
--- files/pbulk/pbulk.conf	20 Aug 2021 06:38:31 -0000	1.26
+++ files/pbulk/pbulk.conf	28 Dec 2021 11:31:13 -0000
@@ -110,9 +110,11 @@ presolve=@PREFIX@/bin/pbulk-resolve
 pscan=@PREFIX@/bin/pbulk-scan

 # When a package build fails, it is often necessary to have a look at
-# the working directory or the installed files. When these options are
-# set to "yes", they will be archived in the log directory.
+# the build log, working directory, or the installed files. When these
+# options are set to "yes", they will be archived in the log
+# directory.
 #
+keep_wrklog=no
 keep_wrkdir=no
 keep_prefix=no

Index: files/pbulk/scripts/pkg-build
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/pbulk/files/pbulk/scripts/pkg-build,v
retrieving revision 1.31
diff -u -p -r1.31 pkg-build
--- files/pbulk/scripts/pkg-build	18 Dec 2016 09:36:38 -0000	1.31
+++ files/pbulk/scripts/pkg-build	28 Dec 2021 11:31:13 -0000
@@ -220,4 +220,6 @@ ${sync_package} ${pkgfile} ${pkgname} "$
 ${make} clean > ${bulklog}/${pkgname}/clean.log 2>&1 || true

 # Cleanup build logs on success
-rm -R ${bulklog}/${pkgname}
+if [ "$keep_wrklog" = yes ]; then
+	rm -R ${bulklog}/${pkgname}
+fi

>Audit-Trail:
From: Joerg Sonnenberger <joerg@bec.de>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Wed, 29 Dec 2021 14:53:36 +0100

 On Tue, Dec 28, 2021 at 11:50:00AM +0000, manphiz@gmail.com wrote:
 > 	Currently in pbulk only the logs of failed packages will be
 > 	kept by default, but here is no way to keep the logs of
 > 	successfully built packages, which may be useful for debugging
 > 	packages that experience runtime issues by inspecting build
 > 	logs such as CFLAGS/LDFLAGAS, or possible issues that didn't
 > 	fail the build process.

 I haven't run into a case where I want to keep the work log for a
 successful build in all my years and were I don't just rebuild the
 package interactively. Given how much space this would consume for a
 regular build, I really don't see the point.

 Joerg

From: manphiz <manphiz@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Wed, 29 Dec 2021 11:39:39 -0800

 On Wed, Dec 29, 2021 at 5:55 AM Joerg Sonnenberger <joerg@bec.de> wrote:
 >
 > The following reply was made to PR pkg/56586; it has been noted by GNATS.
 >
 > From: Joerg Sonnenberger <joerg@bec.de>
 > To: gnats-bugs@netbsd.org
 > Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
 > Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
 > Date: Wed, 29 Dec 2021 14:53:36 +0100
 >
 >  On Tue, Dec 28, 2021 at 11:50:00AM +0000, manphiz@gmail.com wrote:
 >  >      Currently in pbulk only the logs of failed packages will be
 >  >      kept by default, but here is no way to keep the logs of
 >  >      successfully built packages, which may be useful for debugging
 >  >      packages that experience runtime issues by inspecting build
 >  >      logs such as CFLAGS/LDFLAGAS, or possible issues that didn't
 >  >      fail the build process.
 >
 >  I haven't run into a case where I want to keep the work log for a
 >  successful build in all my years and were I don't just rebuild the
 >  package interactively. Given how much space this would consume for a
 >  regular build, I really don't see the point.
 >
 >  Joerg
 >

 Hi Joerg,

 My use case is for this issue[1].  For sudo it'll be easier to search
 the problem with "-Wl,-zrelro" flag without a big enough page size.
 And it'll help with the gnupg2 issue more.  If you check the build log
 I attached in [2], one of the utilities it built ended up in
 segmentation fault but didn't fail the build process, and the produced
 gpg2 program will segfault in runtime randomly too.  Because I built
 it using pbulk which didn't support keeping logs for successful
 packages and used a different prefix for all its builds, I had to
 rebuild everything in the pkgsrc tree to get this build log, and given
 Loongson being a 15+ year machine which wasn't even performant back
 then, it took me another whole day to build all the dependencies of
 gnupg2 to get this log.  It would be much easier if pbulk can just
 keep the build log for helping debugging runtime issues like this.

 As for the space concern, what I'm suggesting here is just to keep the
 build logs, and it's really not much compared with size of a work
 directory which pbulk already supports to keep by the "keep_wrkdir"
 options, so I wouldn't worry too much, especially when this is turned
 off by default.  Actually, I may take a step further by gzipping all
 the build logs to save more spaces if desired.

 [1] https://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=56559
 [2] https://mail-index.netbsd.org/port-mips/2021/12/21/msg001201.html

From: Joerg Sonnenberger <joerg@bec.de>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
	manphiz@gmail.com
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Thu, 30 Dec 2021 10:21:58 +0100

 On Wed, Dec 29, 2021 at 07:45:02PM +0000, manphiz wrote:
 >  I built
 >  it using pbulk which didn't support keeping logs for successful
 >  packages and used a different prefix for all its builds, I had to
 >  rebuild everything in the pkgsrc tree to get this build log.

 You can use the combination of DEPENDS_TARGET=bin-install and
 BINPKG_SITES= to use the binary packages without having to rebuild
 anything beyond the actual target package. This doesn't really convince
 me at all.

 Joerg

From: Benny Siegert <bsiegert@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org, 
	manphiz@gmail.com
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Thu, 30 Dec 2021 11:55:08 +0100

 Joerg, you do not have to use this option if you think it is not
 useful. But the submitter does have a use case for it, and a simple
 patch of less than 10 lines does not warrant this amount of discussion
 IMHO. I vote for adding the patch.

From: Jonathan Perkin <jperkin@joyent.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org,
	manphiz@gmail.com
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Thu, 30 Dec 2021 12:08:15 +0000

 * On 2021-12-30 at 11:00 GMT, Benny Siegert wrote:

 > Joerg, you do not have to use this option if you think it is not
 > useful. But the submitter does have a use case for it, and a simple
 > patch of less than 10 lines does not warrant this amount of discussion
 > IMHO. I vote for adding the patch.

 That may be, but note that the current patch does the exact opposite of 
 what it proposes, just in case someone is of the mind to blindly apply 
 it...

 -- 
 Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com

From: manphiz@gmail.com
To: Jonathan Perkin <jperkin@joyent.com>, gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Thu, 30 Dec 2021 04:31:31 -0800

 This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
 --------------8Q7Ahxbx8CKyQbxjG1sV13FK
 Content-Type: multipart/mixed; boundary="------------N39oHuh0a010JAaeT0ejhM5U";
  protected-headers="v1"
 From: manphiz@gmail.com
 To: Jonathan Perkin <jperkin@joyent.com>, gnats-bugs@netbsd.org
 Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
 Message-ID: <6639ca5e-88a8-3268-3106-84512e3b4a6b@gmail.com>
 Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
 References: <pr-pkg-56586@gnats.netbsd.org>
  <20211228114804.77F2822E1CB@yeeloong-netbsd.localdomain>
  <20211230110002.A66241A923C@mollari.NetBSD.org> <Yc2hL6eXJbzr01r0@joyent.com>
 In-Reply-To: <Yc2hL6eXJbzr01r0@joyent.com>

 --------------N39oHuh0a010JAaeT0ejhM5U
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: base64

 T24gMTIvMzAvMjEgNDowOCBBTSwgSm9uYXRoYW4gUGVya2luIHdyb3RlOg0KPiAqIE9uIDIw
 MjEtMTItMzAgYXQgMTE6MDAgR01ULCBCZW5ueSBTaWVnZXJ0IHdyb3RlOg0KPiANCj4+IEpv
 ZXJnLCB5b3UgZG8gbm90IGhhdmUgdG8gdXNlIHRoaXMgb3B0aW9uIGlmIHlvdSB0aGluayBp
 dCBpcyBub3QNCj4+IHVzZWZ1bC4gQnV0IHRoZSBzdWJtaXR0ZXIgZG9lcyBoYXZlIGEgdXNl
 IGNhc2UgZm9yIGl0LCBhbmQgYSBzaW1wbGUNCj4+IHBhdGNoIG9mIGxlc3MgdGhhbiAxMCBs
 aW5lcyBkb2VzIG5vdCB3YXJyYW50IHRoaXMgYW1vdW50IG9mIGRpc2N1c3Npb24NCj4+IElN
 SE8uIEkgdm90ZSBmb3IgYWRkaW5nIHRoZSBwYXRjaC4NCj4gDQo+IFRoYXQgbWF5IGJlLCBi
 dXQgbm90ZSB0aGF0IHRoZSBjdXJyZW50IHBhdGNoIGRvZXMgdGhlIGV4YWN0IG9wcG9zaXRl
 IG9mIA0KPiB3aGF0IGl0IHByb3Bvc2VzLCBqdXN0IGluIGNhc2Ugc29tZW9uZSBpcyBvZiB0
 aGUgbWluZCB0byBibGluZGx5IGFwcGx5IA0KPiBpdC4uLg0KPiANCg0KSGkgSm9uYXRoYW4s
 DQoNCllvdSBhcmUgcmlnaHQuICBQbGVhc2UgZmluZCB0aGUgZml4ZWQgcGF0Y2ggYmVsb3cu
 DQoNCg0KSW5kZXg6IGZpbGVzL3BidWxrL3BidWxrLmNvbmYNCj09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJD
 UyBmaWxlOiAvY3Zzcm9vdC9wa2dzcmMvcGtndG9vbHMvcGJ1bGsvZmlsZXMvcGJ1bGsvcGJ1
 bGsuY29uZix2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjYNCmRpZmYgLXUgLXAgLXIxLjI2
 IHBidWxrLmNvbmYNCi0tLSBmaWxlcy9wYnVsay9wYnVsay5jb25mCTIwIEF1ZyAyMDIxIDA2
 OjM4OjMxIC0wMDAwCTEuMjYNCisrKyBmaWxlcy9wYnVsay9wYnVsay5jb25mCTI4IERlYyAy
 MDIxIDExOjMxOjEzIC0wMDAwDQpAQCAtMTEwLDkgKzExMCwxMSBAQCBwcmVzb2x2ZT1AUFJF
 RklYQC9iaW4vcGJ1bGstcmVzb2x2ZQ0KICBwc2Nhbj1AUFJFRklYQC9iaW4vcGJ1bGstc2Nh
 bg0KDQogICMgV2hlbiBhIHBhY2thZ2UgYnVpbGQgZmFpbHMsIGl0IGlzIG9mdGVuIG5lY2Vz
 c2FyeSB0byBoYXZlIGEgbG9vayBhdA0KLSMgdGhlIHdvcmtpbmcgZGlyZWN0b3J5IG9yIHRo
 ZSBpbnN0YWxsZWQgZmlsZXMuIFdoZW4gdGhlc2Ugb3B0aW9ucyBhcmUNCi0jIHNldCB0byAi
 eWVzIiwgdGhleSB3aWxsIGJlIGFyY2hpdmVkIGluIHRoZSBsb2cgZGlyZWN0b3J5Lg0KKyMg
 dGhlIGJ1aWxkIGxvZywgd29ya2luZyBkaXJlY3RvcnksIG9yIHRoZSBpbnN0YWxsZWQgZmls
 ZXMuIFdoZW4gdGhlc2UNCisjIG9wdGlvbnMgYXJlIHNldCB0byAieWVzIiwgdGhleSB3aWxs
 IGJlIGFyY2hpdmVkIGluIHRoZSBsb2cNCisjIGRpcmVjdG9yeS4NCiAgIw0KK2tlZXBfd3Jr
 bG9nPW5vDQogIGtlZXBfd3JrZGlyPW5vDQogIGtlZXBfcHJlZml4PW5vDQoNCkluZGV4OiBm
 aWxlcy9wYnVsay9zY3JpcHRzL3BrZy1idWlsZA0KPT09PT09PT09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6
 IC9jdnNyb290L3BrZ3NyYy9wa2d0b29scy9wYnVsay9maWxlcy9wYnVsay9zY3JpcHRzL3Br
 Zy1idWlsZCx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMzENCmRpZmYgLXUgLXAgLXIxLjMx
 IHBrZy1idWlsZA0KLS0tIGZpbGVzL3BidWxrL3NjcmlwdHMvcGtnLWJ1aWxkCTE4IERlYyAy
 MDE2IDA5OjM2OjM4IC0wMDAwCTEuMzENCisrKyBmaWxlcy9wYnVsay9zY3JpcHRzL3BrZy1i
 dWlsZAkyOCBEZWMgMjAyMSAxMTozMToxMyAtMDAwMA0KQEAgLTIyMCw0ICsyMjAsNiBAQCAk
 e3N5bmNfcGFja2FnZX0gJHtwa2dmaWxlfSAke3BrZ25hbWV9ICIkDQogICR7bWFrZX0gY2xl
 YW4gPiAke2J1bGtsb2d9LyR7cGtnbmFtZX0vY2xlYW4ubG9nIDI+JjEgfHwgdHJ1ZQ0KDQog
 ICMgQ2xlYW51cCBidWlsZCBsb2dzIG9uIHN1Y2Nlc3MNCi1ybSAtUiAke2J1bGtsb2d9LyR7
 cGtnbmFtZX0NCitpZiBbICIka2VlcF93cmtsb2ciID0gbm8gXTsgdGhlbg0KKwlybSAtUiAk
 e2J1bGtsb2d9LyR7cGtnbmFtZX0NCitmaQ0KDQoNCg0K

 --------------N39oHuh0a010JAaeT0ejhM5U--

 --------------8Q7Ahxbx8CKyQbxjG1sV13FK
 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc"
 Content-Description: OpenPGP digital signature
 Content-Disposition: attachment; filename="OpenPGP_signature"

 -----BEGIN PGP SIGNATURE-----

 wsF5BAABCAAjFiEEiKQfd6o81mjI+LWALell7WOCXJMFAmHNpqMFAwAAAAAACgkQLell7WOCXJMv
 lg//Tw2RB3zNYAKshiYh7u63FMsUIwQNYNGqjLUcWFutERotJN4due5FmF/RyZOTBpfXVnH60qyV
 j5ysuXEPzks6KHPI0aZXjL8rqND9tmuJqS8giJbjyT1OfSMPTDeW8zwHyr0eUpG9vD5U5ZKDBiGI
 2W1EJclgjUG3aLP96YxjswvMOEsHYYcHw61DanewPnsi397rHrnN2L/y/SB+8+F1237WkRatpFds
 Qn0OqQP4csl2EN5keRZ0Ty2QhwI/nBK6y6GpSn+qCRpV9IvGnvNsUspiLmN7rkYb458pVHGbqdXw
 5gXJ9tmv0qC4r3pknziZ8bvMNdDExvfTwj4YIQo2OsH8VW++apOq8DiiFafdIZWsslVqmaaWcFE/
 mTh/HMNnpFsDgBY+LOyrM57U1BNq1dUE8Mc3WfdQ6wm3ncEwR6a21oK1OjE9qgzTne5T1DJekbFx
 Puqf/ZkxwoI5bWvjrq8xx3CnSmTQVtBburyLBzcD2f+B7xWMvSlTuIU8rle/w32LLRCD89L1jdsU
 W6gjBChJrLQK0eUBX0lp1Pd+itURSTezZBxvNCEv+BIMeBCuD6+vvQxAZ2EoND8Nbgo8qIXsIFo8
 qUssgWWTffYknPQ8yQuRxhGSlviJT4o5bHczCw/azb8GWlD1EfZggRUFz/Kefws/y6XmqAeIhlAB
 r/U=
 =ezmn
 -----END PGP SIGNATURE-----

 --------------8Q7Ahxbx8CKyQbxjG1sV13FK--

From: manphiz@gmail.com
To: Jonathan Perkin <jperkin@joyent.com>, gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Thu, 30 Dec 2021 04:38:52 -0800

 (My previous email was GPG signed and seemed to have become a garbage. 
 Re-sending without GPG.  Sorry for the noise.)

 On 12/30/21 4:08 AM, Jonathan Perkin wrote:
 > * On 2021-12-30 at 11:00 GMT, Benny Siegert wrote:
 > 
 >> Joerg, you do not have to use this option if you think it is not
 >> useful. But the submitter does have a use case for it, and a simple
 >> patch of less than 10 lines does not warrant this amount of discussion
 >> IMHO. I vote for adding the patch.
 > 
 > That may be, but note that the current patch does the exact opposite of 
 > what it proposes, just in case someone is of the mind to blindly apply 
 > it...
 > 

 Hi Jonathan,

 You are right.  Please find the fixed patch below.


 Index: files/pbulk/pbulk.conf
 ===================================================================
 RCS file: /cvsroot/pkgsrc/pkgtools/pbulk/files/pbulk/pbulk.conf,v
 retrieving revision 1.26
 diff -u -p -r1.26 pbulk.conf
 --- files/pbulk/pbulk.conf    20 Aug 2021 06:38:31 -0000    1.26
 +++ files/pbulk/pbulk.conf    28 Dec 2021 11:31:13 -0000
 @@ -110,9 +110,11 @@ presolve=@PREFIX@/bin/pbulk-resolve
   pscan=@PREFIX@/bin/pbulk-scan

   # When a package build fails, it is often necessary to have a look at
 -# the working directory or the installed files. When these options are
 -# set to "yes", they will be archived in the log directory.
 +# the build log, working directory, or the installed files. When these
 +# options are set to "yes", they will be archived in the log
 +# directory.
   #
 +keep_wrklog=no
   keep_wrkdir=no
   keep_prefix=no

 Index: files/pbulk/scripts/pkg-build
 ===================================================================
 RCS file: /cvsroot/pkgsrc/pkgtools/pbulk/files/pbulk/scripts/pkg-build,v
 retrieving revision 1.31
 diff -u -p -r1.31 pkg-build
 --- files/pbulk/scripts/pkg-build    18 Dec 2016 09:36:38 -0000    1.31
 +++ files/pbulk/scripts/pkg-build    28 Dec 2021 11:31:13 -0000
 @@ -220,4 +220,6 @@ ${sync_package} ${pkgfile} ${pkgname} "$
   ${make} clean > ${bulklog}/${pkgname}/clean.log 2>&1 || true

   # Cleanup build logs on success
 -rm -R ${bulklog}/${pkgname}
 +if [ "$keep_wrklog" = no ]; then
 +    rm -R ${bulklog}/${pkgname}
 +fi


From: Joerg Sonnenberger <joerg@bec.de>
To: Benny Siegert <bsiegert@gmail.com>
Cc: gnats-bugs@netbsd.org, pkg-manager@netbsd.org, gnats-admin@netbsd.org,
	pkgsrc-bugs@netbsd.org, manphiz@gmail.com
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Thu, 30 Dec 2021 19:59:15 +0100

 On Thu, Dec 30, 2021 at 11:55:08AM +0100, Benny Siegert wrote:
 > Joerg, you do not have to use this option if you think it is not
 > useful. But the submitter does have a use case for it, and a simple
 > patch of less than 10 lines does not warrant this amount of discussion
 > IMHO. I vote for adding the patch.

 Options have a cost. As such they have to be justified against the
 alternatives.

 Joerg

From: manphiz <manphiz@gmail.com>
To: Joerg Sonnenberger <joerg@bec.de>
Cc: Benny Siegert <bsiegert@gmail.com>, gnats-bugs@netbsd.org, pkg-manager@netbsd.org, 
	gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Thu, 30 Dec 2021 17:45:07 -0800

 On Thu, Dec 30, 2021 at 10:59 AM Joerg Sonnenberger <joerg@bec.de> wrote:
 >
 > On Thu, Dec 30, 2021 at 11:55:08AM +0100, Benny Siegert wrote:
 > > Joerg, you do not have to use this option if you think it is not
 > > useful. But the submitter does have a use case for it, and a simple
 > > patch of less than 10 lines does not warrant this amount of discussion
 > > IMHO. I vote for adding the patch.
 >
 > Options have a cost. As such they have to be justified against the
 > alternatives.
 >
 > Joerg

 Hi Joerg,

 Understood.  Still I would suggest adding this feature as it's easier
 to use compared to your suggested alternatives, which requires:

 * Knowing how to use DEPENDS_TARGET and BINPKG_SITES which are
 introduced at different places in the pkgsrc guide.

 * Making sure to use the same PKG_OPTIONS for the packages of interest
 in both pbulk and pkgsrc, which if not kept the same may not trigger
 the same issue.

 * Having to build it again, which means more time spent.  For me it's
 1-2 hours for building gnupg2 itself.

 If it can be done in pbulk itself by changing a single flag it can
 make life easier for pkgsrc newbies like myself.

 Thanks.

From: Joerg Sonnenberger <joerg@bec.de>
To: manphiz <manphiz@gmail.com>
Cc: Benny Siegert <bsiegert@gmail.com>, gnats-bugs@netbsd.org,
	pkg-manager@netbsd.org, gnats-admin@netbsd.org,
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Fri, 31 Dec 2021 03:56:59 +0100

 On Thu, Dec 30, 2021 at 05:45:07PM -0800, manphiz wrote:
 > On Thu, Dec 30, 2021 at 10:59 AM Joerg Sonnenberger <joerg@bec.de> wrote:
 > >
 > > On Thu, Dec 30, 2021 at 11:55:08AM +0100, Benny Siegert wrote:
 > > > Joerg, you do not have to use this option if you think it is not
 > > > useful. But the submitter does have a use case for it, and a simple
 > > > patch of less than 10 lines does not warrant this amount of discussion
 > > > IMHO. I vote for adding the patch.
 > >
 > > Options have a cost. As such they have to be justified against the
 > > alternatives.
 > >
 > > Joerg
 > 
 > Hi Joerg,
 > 
 > Understood.  Still I would suggest adding this feature as it's easier
 > to use compared to your suggested alternatives, which requires:
 > 
 > * Knowing how to use DEPENDS_TARGET and BINPKG_SITES which are
 > introduced at different places in the pkgsrc guide.
 > 
 > * Making sure to use the same PKG_OPTIONS for the packages of interest
 > in both pbulk and pkgsrc, which if not kept the same may not trigger
 > the same issue.
 > 
 > * Having to build it again, which means more time spent.  For me it's
 > 1-2 hours for building gnupg2 itself.
 > 
 > If it can be done in pbulk itself by changing a single flag it can
 > make life easier for pkgsrc newbies like myself.

 Like I said, I can't remember a case were I didn't want to do such a
 rebuild and learning how to reproduce the pbulk environment
 interactively seems much more useful than a hack that you could obtain
 by just commenting out the line in first place.

 In other words: I can't think of a good reason for having this flag ever
 set permanently in the config file and all other cases are better served
 by learning how to do the above.

 Joerg

From: manphiz <manphiz@gmail.com>
To: Joerg Sonnenberger <joerg@bec.de>
Cc: Benny Siegert <bsiegert@gmail.com>, gnats-bugs@netbsd.org, pkg-manager@netbsd.org, 
	gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Thu, 30 Dec 2021 19:54:47 -0800

 On Thu, Dec 30, 2021 at 6:57 PM Joerg Sonnenberger <joerg@bec.de> wrote:
 >
 > On Thu, Dec 30, 2021 at 05:45:07PM -0800, manphiz wrote:
 > > On Thu, Dec 30, 2021 at 10:59 AM Joerg Sonnenberger <joerg@bec.de> wrote:
 > > >
 > > > On Thu, Dec 30, 2021 at 11:55:08AM +0100, Benny Siegert wrote:
 > > > > Joerg, you do not have to use this option if you think it is not
 > > > > useful. But the submitter does have a use case for it, and a simple
 > > > > patch of less than 10 lines does not warrant this amount of discussion
 > > > > IMHO. I vote for adding the patch.
 > > >
 > > > Options have a cost. As such they have to be justified against the
 > > > alternatives.
 > > >
 > > > Joerg
 > >
 > > Hi Joerg,
 > >
 > > Understood.  Still I would suggest adding this feature as it's easier
 > > to use compared to your suggested alternatives, which requires:
 > >
 > > * Knowing how to use DEPENDS_TARGET and BINPKG_SITES which are
 > > introduced at different places in the pkgsrc guide.
 > >
 > > * Making sure to use the same PKG_OPTIONS for the packages of interest
 > > in both pbulk and pkgsrc, which if not kept the same may not trigger
 > > the same issue.
 > >
 > > * Having to build it again, which means more time spent.  For me it's
 > > 1-2 hours for building gnupg2 itself.
 > >
 > > If it can be done in pbulk itself by changing a single flag it can
 > > make life easier for pkgsrc newbies like myself.
 >
 > Like I said, I can't remember a case were I didn't want to do such a
 > rebuild and learning how to reproduce the pbulk environment
 > interactively seems much more useful than a hack that you could obtain
 > by just commenting out the line in first place.
 >
 > In other words: I can't think of a good reason for having this flag ever
 > set permanently in the config file and all other cases are better served
 > by learning how to do the above.
 >
 > Joerg

 Joerg, what you insisted got me curious about the "keep_wrkdir" flag
 whose effect can also be achieved by what you suggested but is somehow
 supported in pbulk.

From: Joerg Sonnenberger <joerg@bec.de>
To: manphiz <manphiz@gmail.com>
Cc: Benny Siegert <bsiegert@gmail.com>, gnats-bugs@netbsd.org,
	pkg-manager@netbsd.org, gnats-admin@netbsd.org,
	pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Fri, 31 Dec 2021 05:05:11 +0100

 On Thu, Dec 30, 2021 at 07:54:47PM -0800, manphiz wrote:
 > Joerg, what you insisted got me curious about the "keep_wrkdir" flag
 > whose effect can also be achieved by what you suggested but is somehow
 > supported in pbulk.

 The difference is that debugging a broken build using the wrkdir is
 *very* common. Before I run out of time working on those things, most of
 the time I didn't even bother to extract the distfiles and build patches
 directly from the saved work directory. Like I said, every single time
 that I had to debug a problem with a successful build, I wanted to have
 a full interactive build anyway.

 Joerg

From: manphiz <manphiz@gmail.com>
To: Joerg Sonnenberger <joerg@bec.de>
Cc: Benny Siegert <bsiegert@gmail.com>, gnats-bugs@netbsd.org, pkg-manager@netbsd.org, 
	gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Thu, 30 Dec 2021 20:25:33 -0800

 On Thu, Dec 30, 2021 at 8:05 PM Joerg Sonnenberger <joerg@bec.de> wrote:
 >
 > On Thu, Dec 30, 2021 at 07:54:47PM -0800, manphiz wrote:
 > > Joerg, what you insisted got me curious about the "keep_wrkdir" flag
 > > whose effect can also be achieved by what you suggested but is somehow
 > > supported in pbulk.
 >
 > The difference is that debugging a broken build using the wrkdir is
 > *very* common. Before I run out of time working on those things, most of
 > the time I didn't even bother to extract the distfiles and build patches
 > directly from the saved work directory.

 Exactly my purpose here: to save time and work on the problem instead
 of waiting for another rebuild.

 > Like I said, every single time
 > that I had to debug a problem with a successful build, I wanted to have
 > a full interactive build anyway.
 >
 > Joerg

 For my use cases I don't need a full interactive build, just the build
 log is enough and even better if I can get it earlier.

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk
Date: Sat, 21 May 2022 00:04:25 +0000

 On Thu, Dec 30, 2021 at 12:40:01PM +0000, manphiz@gmail.com wrote:
  >  >> Joerg, you do not have to use this option if you think it is not
  >  >> useful. But the submitter does have a use case for it, and a simple
  >  >> patch of less than 10 lines does not warrant this amount of discussion
  >  >> IMHO. I vote for adding the patch.
  >  > 
  >  > That may be, but note that the current patch does the exact opposite of 
  >  > what it proposes, just in case someone is of the mind to blindly apply 
  >  > it...
  >  
  >  Hi Jonathan,
  >  
  >  You are right.  Please find the fixed patch below.

 Can we get this merged already? It is useful (I can think of various
 cases where I'd want to audit successful logs with grep, and some of
 them are things that should really be done, e.g. hunting down packages
 that still have unsafe-temporary-files), and realistically the
 maintenance cost is pretty much zero.

 Joerg, please don't just be obstructive. Other people's suggestions
 sometimes have merit :-)

 -- 
 David A. Holland
 dholland@netbsd.org

Home	PR Database Search